Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

2021-01-27 Thread Magnus Ihse Bursie
On Tue, 26 Jan 2021 22:04:48 GMT, Vladimir Kempik wrote: >> make/autoconf/build-aux/autoconf-config.guess line 1275: >> >>> 1273: UNAME_PROCESSOR="aarch64" >>> 1274: fi >>> 1275: fi ;; >> >> Almost, but not quite, correct. We cannot change the a

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-01-27 Thread Magnus Ihse Bursie
On Mon, 25 Jan 2021 16:00:23 GMT, Bernhard Urban-Forster wrote: >> @luhenry , could you please check this comment, I think SA-agent was MS's >> job here. > > The target is identified by the header file now: > https://github.com/openjdk/jdk/pull/2200/files#diff-51442e74eeef2163f0f0643df0ae995083

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-01-27 Thread Magnus Ihse Bursie
On Tue, 26 Jan 2021 21:59:03 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

2021-01-27 Thread David Holmes
I don't know why the Skara tools decided to associate my comment with Alan Hayward's comment as they are not at all related. :( David On 27/01/2021 4:50 pm, David Holmes wrote: On Tue, 26 Jan 2021 12:34:11 GMT, Alan Hayward wrote: AIUI, the configure line needs passing a prebuilt JavaNativ

8259886 : Improve SSL session cache performance and scalability

2021-01-27 Thread Daniel Jeliński
Hi all, I'd like to modify the MemoryCache class that is used for caching SSL sessions in Java 11; when the cache is overloaded (full cache with no expired entries), the computational complexity of put operation is linear in the cache size. I am aware that the current Java versions are using state

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

2021-01-27 Thread Andrew Haley
On 1/26/21 6:42 PM, erik.joels...@oracle.com wrote: > My understanding is that Apple chose to not provide JNF for aarch64, so > if you want to build OpenJDK, you first need to build JNF yourself (it's > available in github). Phil is working on removing this dependency > completely, which will solve

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v7]

2021-01-27 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-01-27 Thread Vladimir Kempik
On Wed, 27 Jan 2021 08:36:19 GMT, Magnus Ihse Bursie wrote: > Build changes per se now looks okay. However, I agree with Erik that unless > this PR can wait for the JNF removal, at the very least the build docs needs > to be updated to explain how to successfully build for this platform. (I can

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-27 Thread Xue-Lei Andrew Fan
On Wed, 13 Jan 2021 18:46:10 GMT, Rajan Halade wrote: >> Clive Verghese has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Update copyright year >> - Add error handling guidelines >> - Fix bugids and use serv

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-27 Thread Clive Verghese
On Wed, 27 Jan 2021 17:46:03 GMT, Xue-Lei Andrew Fan wrote: >> Changes requested by rhalade (Reviewer). > > For the CSR request, I updated the component to security-libs/javax.net.ssl, > add 17 as one of the fix versions, and added myself as reviewer. Thank you. I will change the status of the

Re: 8259886 : Improve SSL session cache performance and scalability

2021-01-27 Thread Xue-Lei Fan
Hi Daniel, I would like to help you out. Did you have some numbers about the performance improvement of your evaluation? I had a draft re-write cache by using ConcurrentH

Re: 8259886 : Improve SSL session cache performance and scalability

2021-01-27 Thread Daniel Jeliński
Hi Xuelei, Thank you, that would be great. Yes, I created a microbenchmark and got some numbers. The benchmark just calls MemoryCache.put() in a loop; baseline results for different size & timeout values: Benchmark (size) (timeout) Mode Cnt ScoreError Units CacheBench.put 20480

Re: RFR: 8217633: Configurable extensions with system properties [v4]

2021-01-27 Thread Xue-Lei Andrew Fan
> The TLS protocols are designed to tolerant unknown TLS extensions. However, > although it is not common, there are a few TLS implementations that cannot > handle unknown extensions properly. As results in unexpected interoperability > issue when new extensions are introduced in JDK. The intero

RFR: 8256421: Add 2 HARICA roots to Oracle Root CA Program

2021-01-27 Thread Rajan Halade
Following two roots are added to cacerts store - CN=Hellenic Academic and Research Institutions RootCA 2015, O=Hellenic Academic and Research Institutions Cert. Authority, L=Athens, C=GR CN=Hellenic Academic and Research Institutions ECC RootCA 2015, O=Hellenic Academic and Research Institution

Re: RFR: 8217633: Configurable extensions with system properties [v3]

2021-01-27 Thread Xue-Lei Andrew Fan
> The TLS protocols are designed to tolerant unknown TLS extensions. However, > although it is not common, there are a few TLS implementations that cannot > handle unknown extensions properly. As results in unexpected interoperability > issue when new extensions are introduced in JDK. The intero