Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-02 Thread Daniel D . Daugherty
On Tue, 2 Feb 2021 11:59:08 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Re: fix(truststore): log about truststore not found prints every time the same value

2021-02-02 Thread Xue-Lei Fan
Hi Kevin, I think you are done with this PR. I created the bug for you, and you linked the bug with the PR. The PR now is integrated. Xuelei On Feb 2, 2021, at 1:24 PM, Kevin Davin wrote:  Hi everyone, I'm contacting you because I've opened a PR to fix a bug, but it seems to be required

[11u] RFR: 8244683: A TSA server used by tests

2021-02-02 Thread Doerr, Martin
Hi, JDK-8244683 is backported to 11.0.11-oracle. I'd like to backport it for parity. It doesn't apply cleanly. TimestampCheck.java: - The parts which get removed contain minor differences (see [1]) - Resolution: Take new version. TsaHandler.java and TsaSigner.java: - New code contains usages of

fix(truststore): log about truststore not found prints every time the same value

2021-02-02 Thread Kevin Davin
Hi everyone, I'm contacting you because I've opened a PR to fix a bug, but it seems to be required to have an issue associated with it. The OCA team said to me I've to ask you to open one for me. Is it ok for you ? Without it, my PR is blocked https://github.com/openjdk/jdk/pull/1690, and the

Integrated: 8260861: TrustStoreDescriptor log the same value

2021-02-02 Thread Davin Kevin
On Tue, 8 Dec 2020 09:35:26 GMT, Davin Kevin wrote: > If both jssecacerts and cacerts are not defined, the same log is printed > twice, talking about the jssecacerts instead of cacerts the second time.  This pull request has now been integrated. Changeset: 105d3e8f Author:Davin Kevin

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-02 Thread Bernhard Urban-Forster
On Tue, 2 Feb 2021 18:23:04 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > src/hotspot/os/posix/signals_posix.cpp line 1297: > >> 1295: kern_return_t kr;

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-02 Thread Gerard Ziemski
On Tue, 2 Feb 2021 18:52:29 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > Changes requested by gziemski (Committer). There were bunch of assembly code that

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-02 Thread Gerard Ziemski
On Tue, 2 Feb 2021 11:59:08 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Integrated: 8256421: Add 2 HARICA roots to cacerts truststore

2021-02-02 Thread Rajan Halade
On Thu, 28 Jan 2021 01:22:52 GMT, Rajan Halade wrote: > Following two roots are added to cacerts store - > > CN=Hellenic Academic and Research Institutions RootCA 2015, O=Hellenic > Academic and Research Institutions Cert. Authority, L=Athens, C=GR > > CN=Hellenic Academic and Research

Re: RFR: 8256421: Add 2 HARICA roots to Oracle Root CA Program

2021-02-02 Thread Sean Mullan
On Thu, 28 Jan 2021 01:22:52 GMT, Rajan Halade wrote: > Following two roots are added to cacerts store - > > CN=Hellenic Academic and Research Institutions RootCA 2015, O=Hellenic > Academic and Research Institutions Cert. Authority, L=Athens, C=GR > > CN=Hellenic Academic and Research

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v7]

2021-02-02 Thread Xue-Lei Andrew Fan
On Tue, 2 Feb 2021 01:15:25 GMT, Clive Verghese wrote: > Hi, > > Thank you for the feedback. > > I have verified that tier1 and tier2 tests pass on Windows, MacOS and Linux. Thank you! I will address the closed test failures. I will post you when the update is ready. - PR:

Re: RFR: 8259886 : Improve SSL session cache performance and scalability [v2]

2021-02-02 Thread djelinski
On Tue, 2 Feb 2021 02:37:39 GMT, Xue-Lei Andrew Fan wrote: > the benchmark performance improvement is a trade-off between CPU and memory, > by keeping expired entries while putting a new entry in the cache Not exactly. The memory use is capped by cache size. The patch is a trade off between

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-02-02 Thread Alan Hayward
On Tue, 2 Feb 2021 11:56:12 GMT, Vladimir Kempik wrote: > > > > Hello, hsdis is a separate out-of-tree project and is not part of this > > > > jep. > > > > > > > > > Unless there's something I'm missing it only requires a few lines of > > > change to src/utils/hsdis/makefile (it already has

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-02 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-02-02 Thread Vladimir Kempik
On Tue, 2 Feb 2021 11:14:12 GMT, Vladimir Kempik wrote: > > > > Hello, hsdis is a separate out-of-tree project and is not part of this > > > > jep. > > > > > > > > > Unless there's something I'm missing it only requires a few lines of > > > change to src/utils/hsdis/makefile (it already has

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

2021-02-02 Thread Vladimir Kempik
On Mon, 1 Feb 2021 14:06:32 GMT, Magnus Ihse Bursie wrote: >>> Hello, hsdis is a separate out-of-tree project and is not part of this jep. >> >> Unless there's something I'm missing it only requires a few lines of change >> to src/utils/hsdis/makefile (it already has support for macos x86_64)

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v7]

2021-02-02 Thread Magnus Ihse Bursie
On Mon, 1 Feb 2021 16:51:12 GMT, Weijun Wang wrote: >> This fix covers both >> >> - [[macOS]: Remove JNF dependency from >> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) >> - [[macOS]: Remove JNF dependency from >>