Re: RFR: 8257497: Key identifier compliance issue

2021-02-05 Thread Weijun Wang
On Fri, 5 Feb 2021 21:54:19 GMT, Sean Mullan wrote: > I think it would be useful to add a test that checks that `keytool` now > creates the AKID from the issuing CA's SKID. `keytool -ext` should be able to > create a certificate with your own AKID, but you need to specify the OID and > a hex-e

Re: RFR: 8257497: Key identifier compliance issue

2021-02-05 Thread Sean Mullan
On Mon, 1 Feb 2021 23:06:30 GMT, Hai-May Chao wrote: > This change is made for compliance with RFC 5280 section 4.2.1.1 for > Authority Key Identifier extension. I think it would be useful to add a test that checks that `keytool` now creates the AKID from the issuing CA's SKID. `keytool -ext`

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v3]

2021-02-05 Thread Fernando Guallini
On Fri, 5 Feb 2021 17:45:45 GMT, Rajan Halade wrote: >> test/jdk/javax/net/ssl/SSLSession/TestEnabledProtocols.java line 145: >> >>> 143: // The server side may have closed the socket. >>> 144: System.out.println("Client SSLException:"); >>> 145: ssle.printSta

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v3]

2021-02-05 Thread Fernando Guallini
> The server side is binding to the wildcard address which has been a source of > instability in many networking tests due to javax.net.ssl.SSLException: > Connection reset. Changing the following tests to bind to loopback address > fixes intermittent failures: > sun/security/ssl/SSLSocketImpl/R

Re: RFR: 8257497: Key identifier compliance issue

2021-02-05 Thread Hai-May Chao
On Fri, 5 Feb 2021 10:16:14 GMT, Sean Coffey wrote: >> This change is made for compliance with RFC 5280 section 4.2.1.1 for >> Authority Key Identifier extension. > > Marked as reviewed by coffeys (Reviewer). @coffeys Thanks for the review! - PR: https://git.openjdk.java.net/jdk/p

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v2]

2021-02-05 Thread Rajan Halade
On Thu, 4 Feb 2021 14:55:39 GMT, Daniel Fuchs wrote: >> Fernando Guallini has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Merge branch '8241372' of github.com:fguallini/jdk into 8241372 >> - remove not needed bug id from tests, run wi

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-05 Thread Anton Kozlov
On Tue, 2 Feb 2021 18:35:51 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > src/hotspot/cpu/aarch64/vm_version_aarch64.hpp line 93: > >> 91: CPU_MARVELL

Re: RFR: 8258915: Temporary buffer cleanup [v6]

2021-02-05 Thread Valerie Peng
On Fri, 29 Jan 2021 18:40:02 GMT, Weijun Wang wrote: >> Clean up temporary byte array, char array, and keyspec around keys and >> passwords. >> >> No new regression test. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > drb

Re: JSSE reference guide issue

2021-02-05 Thread Daniel Jeliński
Thanks! I didn't think of checking the bug report page. Will keep it in mind. Regards, Daniel pt., 5 lut 2021 o 15:40 Seán Coffey napisał(a): > > Another option for reporting is to use the https://bugreport.java.com > portal. Component = documentation. > > regards, > Sean. > > On 05/02/2021 14:03

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-05 Thread Anton Kozlov
On Wed, 3 Feb 2021 23:29:30 GMT, Gerard Ziemski wrote: >> using ` ```c ` >> https://docs.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks >> >> I was wrong about `SIGFPE` / `EXC_MASK_ARITHMETIC`, it's used on i386, >> x86_64: >> https://github.com/openjdk/jdk/blob/2

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v12]

2021-02-05 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Gerard Ziemski
On Fri, 5 Feb 2021 12:26:27 GMT, Anton Kozlov wrote: >> Marked as reviewed by ihse (Reviewer). > >> I haven't got a MacOS AArch64 system right now. Is it possible to >> enable W^X in Linux in order to kick the tyres? > > I've just got rid of asserts that fired on Linux sometime :) As for W^X lik

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-05 Thread daniel . daugherty
On 2/5/21 4:51 AM, Magnus Ihse Bursie wrote: On Tue, 2 Feb 2021 21:20:52 GMT, Daniel D. Daugherty wrote: Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision: support macos_aarch64 in hsdis make/autoconf/flags.m4 line 140: 138:

Re: JSSE reference guide issue

2021-02-05 Thread Seán Coffey
Another option for reporting is to use the https://bugreport.java.com portal. Component = documentation. regards, Sean. On 05/02/2021 14:03, Sean Mullan wrote: If you have a JBS account, you can file a bug in the docs/guides category. However, I have also forwarded your email to our internal

Re: JSSE reference guide issue

2021-02-05 Thread Sean Mullan
If you have a JBS account, you can file a bug in the docs/guides category. However, I have also forwarded your email to our internal docs engineer, so we will follow-up on it. Thanks, Sean On 2/5/21 2:42 AM, Daniel Jeliński wrote: Hi all, What's the right spot to report documentation issues?

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

2021-02-05 Thread Anton Kozlov
On Mon, 25 Jan 2021 22:48:50 GMT, Chris Plummer wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Refactor CDS disabling >> - Redo builsys support for aarch64-darwin > > src/jdk.hotspot.agent/macosx/native/libsapr

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v11]

2021-02-05 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Anton Kozlov
On Fri, 5 Feb 2021 09:57:54 GMT, Magnus Ihse Bursie wrote: >> Anton Kozlov has updated the pull request incrementally with six additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos >> - Add comments to WX transitions >> >

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v2]

2021-02-05 Thread Daniel Fuchs
On Fri, 5 Feb 2021 10:48:00 GMT, Fernando Guallini wrote: >> The server side is binding to the wildcard address which has been a source >> of instability in many networking tests due to javax.net.ssl.SSLException: >> Connection reset. Changing the following tests to bind to loopback address >

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v2]

2021-02-05 Thread Fernando Guallini
On Thu, 4 Feb 2021 15:11:39 GMT, Daniel Fuchs wrote: >> Fernando Guallini has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Merge branch '8241372' of github.com:fguallini/jdk into 8241372 >> - remove not needed bug id from tests, run wi

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v2]

2021-02-05 Thread Fernando Guallini
> The server side is binding to the wildcard address which has been a source of > instability in many networking tests due to javax.net.ssl.SSLException: > Connection reset. Changing the following tests to bind to loopback address > fixes intermittent failures: > sun/security/ssl/SSLSocketImpl/R

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v2]

2021-02-05 Thread Fernando Guallini
On Thu, 4 Feb 2021 14:50:24 GMT, Daniel Fuchs wrote: >> Fernando Guallini has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Merge branch '8241372' of github.com:fguallini/jdk into 8241372 >> - remove not needed bug id from tests, run wi

Re: RFR: 8257497: Key identifier compliance issue

2021-02-05 Thread Sean Coffey
On Mon, 1 Feb 2021 23:06:30 GMT, Hai-May Chao wrote: > This change is made for compliance with RFC 5280 section 4.2.1.1 for > Authority Key Identifier extension. Marked as reviewed by coffeys (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2343

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Magnus Ihse Bursie
On Wed, 3 Feb 2021 20:01:15 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Magnus Ihse Bursie
On Fri, 5 Feb 2021 09:49:11 GMT, Andrew Haley wrote: >> I reviewed bsd_aarch64.cpp digging bit deeper and left some comments. > >> > Umm, so how does patching work? We don't even know if other threads are >> > executing the code we need to patch. >> >> I thought java can handle that scenario in

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Andrew Haley
On Thu, 4 Feb 2021 23:05:56 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with six additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos >> - Add comments to WX transitions >> >>

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-05 Thread Magnus Ihse Bursie
On Tue, 2 Feb 2021 21:20:52 GMT, Daniel D. Daugherty wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > make/autoconf/flags.m4 line 140: > >> 138: else >> 139: MACOSX_VERS