Re: RFR: 8257497: Key identifier compliance issue [v5]

2021-02-16 Thread Hai-May Chao
On Tue, 16 Feb 2021 18:33:52 GMT, Sean Mullan wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reduced one param to createV3Extensions > > src/java.base/share/classes/sun/security/tools/keytool/Main.java line 1484:

Re: RFR: 8257497: Key identifier compliance issue [v6]

2021-02-16 Thread Hai-May Chao
> This change is made for compliance with RFC 5280 section 4.2.1.1 for > Authority Key Identifier extension. Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision: Compare keys using encoded bytes - Changes: - all:

Re: RFR: 8259886 : Improve SSL session cache performance and scalability [v2]

2021-02-16 Thread djelinski
On Wed, 10 Feb 2021 19:19:33 GMT, djelinski wrote: >>> Thanks for your review! Some comments below. >>> >>> > A full handshake or OCSP status grabbing could counteract all the >>> > performance gain with the cache update. >>> >>> Yes, but that's unlikely. Note that K=3 is before K=1 in the

Re: RFR: 8259886 : Improve SSL session cache performance and scalability [v4]

2021-02-16 Thread djelinski
> Under certain load, MemoryCache operations take a substantial fraction of the > time needed to complete SSL handshakes. This series of patches improves > performance characteristics of MemoryCache, at the cost of a functional > change: expired entries are no longer guaranteed to be removed

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v12]

2021-02-16 Thread Andrey Turbanov
> 8080272 Refactor I/O stream copying to use > InputStream.transferTo/readAllBytes and Files.copy Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo

Integrated: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset

2021-02-16 Thread Fernando Guallini
On Thu, 4 Feb 2021 13:00:47 GMT, Fernando Guallini wrote: > The server side is binding to the wildcard address which has been a source of > instability in many networking tests due to javax.net.ssl.SSLException: > Connection reset. Changing the following tests to bind to loopback address >

Re: RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v5]

2021-02-16 Thread Rajan Halade
On Thu, 11 Feb 2021 12:39:54 GMT, Fernando Guallini wrote: >> The server side is binding to the wildcard address which has been a source >> of instability in many networking tests due to javax.net.ssl.SSLException: >> Connection reset. Changing the following tests to bind to loopback address

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v9]

2021-02-16 Thread Andrey Turbanov
On Mon, 8 Feb 2021 21:18:44 GMT, Philippe Marschall wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo >> fix review comments > >

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v9]

2021-02-16 Thread Andrey Turbanov
On Tue, 9 Feb 2021 11:40:09 GMT, Philippe Marschall wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo >> fix review comments > >

Re: RFR: 8257497: Key identifier compliance issue [v5]

2021-02-16 Thread Sean Mullan
On Fri, 12 Feb 2021 20:42:03 GMT, Hai-May Chao wrote: >> This change is made for compliance with RFC 5280 section 4.2.1.1 for >> Authority Key Identifier extension. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Reduced

Integrated: 8248223: KeyAgreement spec update on multi-party key exchange support

2021-02-16 Thread Jamil Nimeh
On Wed, 10 Feb 2021 16:33:54 GMT, Jamil Nimeh wrote: > This is a spec-only change that clarifies the requirement on KeyAgreement > implementations for multi-party support where there are 3 or more parties > involved. This change states that 3+ party support is > implementation-specific

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy

2021-02-16 Thread Julia Boes
On Sun, 20 Dec 2020 17:05:21 GMT, Andrey Turbanov wrote: > 8080272 Refactor I/O stream copying to use > InputStream.transferTo/readAllBytes and Files.copy Hi @turbanoff, I'm happy to sponsor but I see two comments by @marschall - have they been addressed?

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v17]

2021-02-16 Thread Jim Laskey
On Tue, 16 Feb 2021 15:54:08 GMT, Rémi Forax wrote: >> The interface method is a default method, so not technically an override. > > It's not an override but @Override has a broader semantics than just > overriding an existing method. > Given that it helps to understand that this method is

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v17]

2021-02-16 Thread Rémi Forax
On Tue, 16 Feb 2021 14:03:56 GMT, Jim Laskey wrote: >> src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java line >> 1548: >> >>> 1546: * @return a stream of (pseudo)randomly chosen {@code int} >>> values >>> 1547: */ >>> 1548: >> >> Is `@Override`

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v17]

2021-02-16 Thread Jim Laskey
On Sat, 13 Feb 2021 15:03:53 GMT, Andrey Turbanov wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added table of available algorithms. > > src/java.base/share/classes/java/util/Random.java line 29: > >> 27: >>

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-16 Thread Vladimir Kempik
On Thu, 4 Feb 2021 22:49:23 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with six additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos >> - Add comments to WX transitions >> >>

RFR: JDK-8261791: handleSendFailed in SctpChannelImpl.c potential leaks

2021-02-16 Thread Matthias Baesken
In another bug this question from m was answered by Alan Bateman : Btw. while adjusting Java_sun_nio_ch_sctp_SctpChannelImpl_receive0 , I started to wonder what happens to the allocated memory in the same file in handleSendFailed ( if ((addressP =

Re: RFR: JDK-8261601: free memory in early return in Java_sun_nio_ch_sctp_SctpChannelImpl_receive0

2021-02-16 Thread Matthias Baesken
On Tue, 16 Feb 2021 08:42:42 GMT, Alan Bateman wrote: > I see this has been integrated but the fix is incomplete. Are you planning to > create a follow-on issue for the issues that I pointed out above? Hi Alan, thanks about your comment to my question about handleSendFailed . I opened a

Re: RFR: JDK-8261601: free memory in early return in Java_sun_nio_ch_sctp_SctpChannelImpl_receive0

2021-02-16 Thread Alan Bateman
On Sat, 13 Feb 2021 17:27:47 GMT, Alan Bateman wrote: >> There seems to be an early return in >> Java_sun_nio_ch_sctp_SctpChannelImpl_receive0 that misses freeing memory. >> >> Sonar reports : >> https://sonarcloud.io/project/issues?id=shipilev_jdk=c=AXck8Cl0BBG2CXpcnjFu=false=BLOCKER=BUG >>

Integrated: JDK-8261601: free memory in early return in Java_sun_nio_ch_sctp_SctpChannelImpl_receive0

2021-02-16 Thread Matthias Baesken
On Fri, 12 Feb 2021 08:50:14 GMT, Matthias Baesken wrote: > There seems to be an early return in > Java_sun_nio_ch_sctp_SctpChannelImpl_receive0 that misses freeing memory. > > Sonar reports : > https://sonarcloud.io/project/issues?id=shipilev_jdk=c=AXck8Cl0BBG2CXpcnjFu=false=BLOCKER=BUG > >