Re: RFR: 8261462: GCM ByteBuffer decryption problems

2021-03-04 Thread Valerie Peng
On Tue, 2 Mar 2021 16:21:00 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review of these two simple fixes. One just sets the input >> bytebuffer position to the limit upon completion of decryption. The second >> calls the CipherCore method to clear the state from the previous operation

Re: [External] : Re: TLS 1.3 Post-handshake authentication

2021-03-04 Thread Xue-Lei Fan
Does it mean that when switch to HTTP/2, the concern is not valid any longer? Or there is an alternative solution? Sorry for the questions, I know little about servlet. I'm trying to understand the requirement of this feature. Xuelei From: arjan tijms Sent: T

Re: TLS 1.3 Post-handshake authentication

2021-03-04 Thread arjan tijms
Hi, On Thu, Mar 4, 2021 at 10:48 PM Xue-Lei Fan wrote: > Did you have a chance to read RFC 8740? Post-Handshake authentication in > HTTP/2 is not allowed for TLS 1.3. Is there a concern for the use case you > mentioned? > Servlet supports both HTTP/1.1 and HTTP/2. The concern here is for HTTP

Re: TLS 1.3 Post-handshake authentication

2021-03-04 Thread Xue-Lei Fan
Hi Arjan, Did you have a chance to read RFC 8740? Post-Handshake authentication in HTTP/2 is not allowed for TLS 1.3. Is there a concern for the use case you mentioned? Xuelei From: jdk-dev on behalf of arjan tijms Sent: Thursday, March 4, 2021 12:57 PM

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-04 Thread Vladimir Kempik
On Thu, 4 Mar 2021 17:36:22 GMT, Alan Hayward wrote: > I was building this PR on a new machine, and I now get the following error: > > > /Users/alahay01/java/gerrit_jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_MidiUtils.c:258:31: > > error: cast to smaller integer type 'MID

Re: Bug with TLSv1.3 session resumption (most likely caused by concurrency bug)

2021-03-04 Thread Jamil Nimeh
I already replied to Norman directly (because apparently I cannot seem to find my Reply-all button before my morning caffeine!).  It does look quite a bit like 8241248 and that issue is in my bug queue.  I haven't started work on it yet, but now that Norman has provided me some links to a repro

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-04 Thread Alan Hayward
On Thu, 4 Mar 2021 15:27:25 GMT, Gerard Ziemski wrote: >>> A list of the bugs that our internal testing revealed so far: >> >> Are any of these blockers for integration? Some of them are to do with >> things like features that aren't yet supported, and we can't fix what we >> can't see. > >> >

Integrated: 8259709: Disable SHA-1 XML Signatures

2021-03-04 Thread Sean Mullan
On Mon, 8 Feb 2021 20:46:41 GMT, Sean Mullan wrote: > Please review this change to disable XML signatures that use SHA-1 based > digest or signature algorithms. SHA-1 is weak and is not a recommended > algorithm for digital signatures. This will improve out of the box security > by restricting

Re: Bug with TLSv1.3 session resumption (most likely caused by concurrency bug)

2021-03-04 Thread Xue-Lei Fan
Forward to security-dev. Xuelei On Mar 4, 2021, at 6:11 AM, Norman Maurer mailto:norman.mau...@googlemail.com>> wrote: Hi there, I think I found a bug in the TLSv1.3 session cache implementation which sometimes can cause failures during session resumption. The cause of this sometimes show up

Re: RFR: 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java [v2]

2021-03-04 Thread Fernando Guallini
> Certain JVM tools may access and initialise InetAddress class and its static > fields during start up resulting in a NameService implementation being > already set to the default **PlatformNameService**, causing intermittent > failures in some tests that expect the use of **HostsFileNameServic

Re: RFR: 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java [v2]

2021-03-04 Thread Fernando Guallini
On Thu, 4 Mar 2021 13:42:57 GMT, Aleksei Efimov wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> move set env properties to header > > test/jdk/sun/security/krb5/canonicalize/Test.java line 37: > >> 35: pu

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-03-04 Thread Gerard Ziemski
On Wed, 3 Mar 2021 17:46:41 GMT, Andrew Haley wrote: > > A list of the bugs that our internal testing revealed so far: > > Are any of these blockers for integration? Some of them are to do with things > like features that aren't yet supported, and we can't fix what we can't see. I don't person

Integrated: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards

2021-03-04 Thread Ziyi Luo
On Tue, 23 Feb 2021 01:47:48 GMT, Ziyi Luo wrote: > All of the "isAssignableFrom" checks in "engineGetKeySpec" appear to be > backwards in Java's KeyFactorySpi.engineGetKeySpec implementations. In most > cases, the requested KeySpec is equal to the concrete implementation so the > inversion do

Bug with TLSv1.3 session resumption (most likely caused by concurrency bug)

2021-03-04 Thread Norman Maurer
Hi there, I think I found a bug in the TLSv1.3 session cache implementation which sometimes can cause failures during session resumption. The cause of this sometimes show up as NPE: javax.net.ssl.SSLException: Session has no PSK at java.base/sun.security.ssl.Alert.createSSLException(Ale

Re: RFR: 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java

2021-03-04 Thread Aleksei Efimov
On Wed, 3 Mar 2021 12:23:00 GMT, Fernando Guallini wrote: > Certain JVM tools may access and initialise InetAddress class and its static > fields during start up resulting in a NameService implementation being > already set to the default **PlatformNameService**, causing intermittent > failur

Re: RFR: 8259709: Disable SHA-1 XML Signatures [v2]

2021-03-04 Thread Sean Mullan
> Please review this change to disable XML signatures that use SHA-1 based > digest or signature algorithms. SHA-1 is weak and is not a recommended > algorithm for digital signatures. This will improve out of the box security > by restricting XML signatures that use SHA-1 algorithms. > > CSR: h

Re: RFR: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed" [v3]

2021-03-04 Thread Daniel Fuchs
On Thu, 4 Mar 2021 09:47:03 GMT, Evan Whelan wrote: >> Hi all, >> >> Please review my test fix relating to JDK-8262438 >> >> This patch introduces as Thread.sleep at the start of each iteration which >> creates a new test jvm. >> This allows the server socket sufficient time to release the pr

Re: RFR: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed"

2021-03-04 Thread Evan Whelan
On Tue, 2 Mar 2021 15:04:23 GMT, Evan Whelan wrote: >> Hi Evan - I am a bit skeptical that the proposed fix will solve the issue. >> AFAICS the exception is raised by the server side - and if I read it >> correctly it happens when the server finds that the socket is already closed >> when it t

Re: RFR: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed" [v2]

2021-03-04 Thread Evan Whelan
On Tue, 2 Mar 2021 15:13:56 GMT, Daniel Fuchs wrote: >> Evan Whelan has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8262438: Stream operations on new lines >> - 8262438: Ensure all streams are emptied in socket connection > > test/jdk

Re: RFR: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed" [v3]

2021-03-04 Thread Evan Whelan
> Hi all, > > Please review my test fix relating to JDK-8262438 > > This patch introduces as Thread.sleep at the start of each iteration which > creates a new test jvm. > This allows the server socket sufficient time to release the previous > connection and allows the port to be used again. >