Re: RFR: 8262316: Reducing locks in RSA Blinding [v3]

2021-04-05 Thread Anthony Scarpino
> Hi, > > I need a review of the locking change to the RSA blinding code. The problem > was reported that multithreaded performance suffered because there was one > global lock on the many blindings operation. The change reduces locking by > using a ConcurrentLinkedQueue to store the

Re: RFR: 8264554: X509KeyManagerImpl calls getProtectionParameter with incorrect alias

2021-04-05 Thread Xue-Lei Andrew Fan
On Fri, 2 Apr 2021 16:38:14 GMT, Xue-Lei Andrew Fan wrote: > In X509KeyManagerImpl.java, a composited entry alias consists three parts: > an UID counter, a builder index and the real entry alias (See the makeAlias() > method). While calling the KeyStore.Builder.getProtectionParameter(String

Re: RFR: 8263779: SSLEngine reports NEED_WRAP continuously without producing any further output

2021-04-05 Thread Xue-Lei Andrew Fan
On Wed, 31 Mar 2021 20:52:57 GMT, Xue-Lei Andrew Fan wrote: > As described in the bug, by connecting the SSLEngine with a misbehaving peer > SSL implementation, it can get into a state where it calling `wrap` reports > getStatus == OK, getHandshakeStatus === NEED_WRAP but still doesn't produce

Re: RFR: 8262316: Reducing locks in RSA Blinding [v2]

2021-04-05 Thread Anthony Scarpino
On Sat, 3 Apr 2021 05:40:11 GMT, djelinski wrote: >> If you synchronize `putIfAbsent` but not `get` you'll still get the possible >> infinite loop described in the SO post. > > Expunging entries is synchronized over an internal data structure, so if you > synchronize puts only, nothing

Re: RFR: 8264190: Harden TLS interop tests [v4]

2021-04-05 Thread Rajan Halade
On Wed, 31 Mar 2021 10:53:34 GMT, Fernando Guallini wrote: >> Occasional interop tests failures may occur when making use of the >> test/jdk/javax/net/ssl/TLSCommon/interop framework since there is no >> assurance the selected available port it is still free at the time a server >> using the

Integrated: 8248862: Implement Enhanced Pseudo-Random Number Generators

2021-04-05 Thread Jim Laskey
On Wed, 18 Nov 2020 13:45:12 GMT, Jim Laskey wrote: > This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v42]

2021-04-05 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at >