On Sat, 3 Apr 2021 22:09:55 GMT, Alex Blewitt
wrote:
> 8264681: Use the blessed modifier order in java.security
This pull request has now been integrated.
Changeset: ebbce91e
Author:Alex Blewitt
Committer: Aleksey Shipilev
URL: https://git.openjdk.java.net/jdk/commit/ebbce91e
Stats
> Could someone (perhaps Jamil?) please help review this change? This enhances
> SunPKCS11 provider with ChaCha20-Poly1305 cipher and ChaCha20 key generation
> support. Majority of the regression tests are adapted from the existing ones
> for SunJCE provider's ChaCha20-Poly1305 cipher impl. When
On Tue, 13 Apr 2021 19:59:30 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been draft
On Tue, 13 Apr 2021 19:30:53 GMT, Joe Wang wrote:
>> Although the code path is different, the logic to determine the encoding is
>> not changed, as `sun.stdout/err.encoding` are only set if the VM is invoked
>> from a terminal (in fact, there's a bug where they aren't set even in a
>> terminal
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
> [[2](https://bugs.openjdk.
On Tue, 13 Apr 2021 18:24:55 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/lang/System.java line 2020:
>>
>>> 2018: setIn0(new BufferedInputStream(fdIn));
>>> 2019: setOut0(newPrintStream(fdOut, cs));
>>> 2020: setErr0(newPrintStream(fdErr, cs));
>>
>> It wa
On Tue, 13 Apr 2021 13:04:17 GMT, Alan Bateman wrote:
> 1. I think method name "charset()" is too short. It's not called frequently.
> This method name should explain functionality.
As for this one, I am open for suggestions. I thought `consoel()` was concise,
and analogous to `Charset.default
On Tue, 13 Apr 2021 02:34:15 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reverted PrintStream changes
>
> src/java.base/share/classes/java/lang/System.java line 2020:
>
>> 2018: setIn0(new
> This enhancement contains the following code changes:
>
> 1. Create a new public API `javax/xml/crypto/dsig/spec/RSAPSSParameterSpec`
> and remove the internal one.
> 2. Update marshaling and unmarshaling code inside `DOMRSAPSSSignatureMethod`
> so it understands extra fields in `PSSParameterS
On Tue, 13 Apr 2021 17:07:19 GMT, Sean Mullan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> spec clarification
>
> src/java.xml.crypto/share/classes/javax/xml/crypto/dsig/SignatureMethod.java
> line 247:
>
>> 24
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
> [[2](https://bugs.openjdk.
Hi Sean,
Updated with your comments. Thanks for the review.
Tia-May
> On Apr 13, 2021, at 6:39 AM, Sean Mullan wrote:
>
> Looks good, a couple of suggested rewordings in the second sentence:
>
>
> The `-signer` and `-signerkeypass` options have been added to the
> `-genkeypair` command of
On Mon, 12 Apr 2021 06:30:43 GMT, djelinski
wrote:
>> As described in the bug, by connecting the SSLEngine with a misbehaving peer
>> SSL implementation, it can get into a state where it calling `wrap` reports
>> getStatus == OK, getHandshakeStatus === NEED_WRAP but still doesn't produce
>> a
On Tue, 13 Apr 2021 15:31:35 GMT, Weijun Wang wrote:
>> This enhancement contains the following code changes:
>>
>> 1. Create a new public API `javax/xml/crypto/dsig/spec/RSAPSSParameterSpec`
>> and remove the internal one.
>> 2. Update marshaling and unmarshaling code inside `DOMRSAPSSSignatur
On Tue, 13 Apr 2021 14:36:46 GMT, Weijun Wang wrote:
> This fix makes `DerUtils::checkAlg` simple and clear, no more raw `Object`
> and ambiguous string arguments.
This pull request has now been integrated.
Changeset: 9cd5400d
Author:Weijun Wang
URL: https://git.openjdk.java.net/jdk
On Tue, 13 Apr 2021 14:36:46 GMT, Weijun Wang wrote:
> This fix makes `DerUtils::checkAlg` simple and clear, no more raw `Object`
> and ambiguous string arguments.
Marked as reviewed by xuelei (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3467
On Tue, 13 Apr 2021 13:19:17 GMT, Fernando Guallini
wrote:
> test/jdk/javax/net/ssl/DTLS/RespondToRetransmit.java has been seen to fail
> intermittently.
> The server side is binding to the wildcard/localhost address which has been a
> source of instability in many tests. Binding to loopback
> This enhancement contains the following code changes:
>
> 1. Create a new public API `javax/xml/crypto/dsig/spec/RSAPSSParameterSpec`
> and remove the internal one.
> 2. Update marshaling and unmarshaling code inside `DOMRSAPSSSignatureMethod`
> so it understands extra fields in `PSSParameterS
On Mon, 12 Apr 2021 15:25:09 GMT, Weijun Wang wrote:
>> This enhancement contains the following code changes:
>>
>> 1. Create a new public API `javax/xml/crypto/dsig/spec/RSAPSSParameterSpec`
>> and remove the internal one.
>> 2. Update marshaling and unmarshaling code inside `DOMRSAPSSSignatur
On Tue, 13 Apr 2021 14:22:47 GMT, Sean Mullan wrote:
>> You are right that the overridable methods are elsewhere
>> (`XMLSignatureFactory::newSignatureMethod` and
>> `SignatureMethod::getParameterSpec`), but I still feel it a little strange
>> to move the default parameter of one particular al
This fix makes `DerUtils::checkAlg` simple and clear, no more raw `Object` and
ambiguous string arguments.
-
Commit messages:
- 8265138: Simplify DerUtils::checkAlg
Changes: https://git.openjdk.java.net/jdk/pull/3467/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3467
On Mon, 12 Apr 2021 09:32:13 GMT, Alex Blewitt
wrote:
>> 8264681: Use the blessed modifier order in java.security
>
> Alex Blewitt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed upstream licensed code from commit
I think all conv
On Mon, 12 Apr 2021 20:53:21 GMT, Weijun Wang wrote:
>> Ok, I understand now. I think `@implSpec` (and probably the `@implNote`) are
>> in the wrong class. `@implSpec` means the implementation of this class. But
>> this class is final and does not contain that logic. The logic of
>> specifyin
On Mon, 12 Apr 2021 09:32:13 GMT, Alex Blewitt
wrote:
>> 8264681: Use the blessed modifier order in java.security
>
> Alex Blewitt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed upstream licensed code from commit
What happens to
Looks good, a couple of suggested rewordings in the second sentence:
The `-signer` and `-signerkeypass` options have been added to the
`-genkeypair` command of the `keytool` utility. The `-signer` option
specifies the keystore alias of a signer and the `-signerkeypass` option
specifies the pa
test/jdk/javax/net/ssl/DTLS/RespondToRetransmit.java has been seen to fail
intermittently.
The server side is binding to the wildcard/localhost address which has been a
source of instability in many tests. Binding to loopback address fixes the
intermittent failures.
In addition, other changes
On Tue, 13 Apr 2021 12:54:51 GMT, Ichiroh Takiguchi
wrote:
> 1. I think method name "charset()" is too short. It's not called frequently.
> This method name should explain functionality.
> 2. Sometimes stderr may be redirected to stdout by shell. Why do we need to
> set different encodings for
On Mon, 12 Apr 2021 23:01:24 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been draft
On Tue, 13 Apr 2021 10:04:19 GMT, Conor Cleary wrote:
>> ### Description
>> This fix is part of a previous effort to both cleanup/modernise JNDI code,
>> the details of which can be seen in
>> [JDK-8048091](https://bugs.openjdk.java.net/browse/JDK-8048091). A number
>> JNDI methods under `java
On Tue, 13 Apr 2021 10:04:19 GMT, Conor Cleary wrote:
>> ### Description
>> This fix is part of a previous effort to both cleanup/modernise JNDI code,
>> the details of which can be seen in
>> [JDK-8048091](https://bugs.openjdk.java.net/browse/JDK-8048091). A number
>> JNDI methods under `java
On Tue, 13 Apr 2021 10:00:51 GMT, Conor Cleary wrote:
>> Good idea, also would fit in with the style of the method just after,
>> `priviligedHasNext()` as that also uses a functional interface.
>
> Changes included as described in commit
> [5d6ecd3](https://github.com/openjdk/jdk/pull/3416/comm
On Tue, 13 Apr 2021 09:34:15 GMT, Conor Cleary wrote:
>> src/java.naming/share/classes/javax/naming/ldap/StartTlsRequest.java line
>> 223:
>>
>>> 221: */
>>> 222: private final ClassLoader getContextClassLoader() {
>>> 223: PrivilegedAction pa = () ->
>>> Thread.currentThread(
> ### Description
> This fix is part of a previous effort to both cleanup/modernise JNDI code,
> the details of which can be seen in
> [JDK-8048091](https://bugs.openjdk.java.net/browse/JDK-8048091). A number
> JNDI methods under `java.naming` use Anonymous Inner Classes in cases where
> only a
On Mon, 12 Apr 2021 16:44:16 GMT, Aleksei Efimov wrote:
>> Conor Cleary has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update copyright headers
>> - Tidied up lambdas
>
> src/java.naming/share/classes/javax/naming/ldap/StartTlsReques
34 matches
Mail list logo
