On Wed, 14 Apr 2021 22:57:55 GMT, Weijun Wang wrote:
>> I'd like to move this tool to test/lib inside a proper named package.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do not call internal method
Marked as reviewed
> I'd like to move this tool to test/lib inside a proper named package.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
do not call internal method
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3496/files
-
On Wed, 14 Apr 2021 20:48:07 GMT, Weijun Wang wrote:
>> I'd like to move this tool to test/lib inside a proper named package.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> move to process and a test for itself
New commit
On Wed, 14 Apr 2021 19:54:26 GMT, Florent Guillaume
wrote:
>> While JDK-8148937 improved StringJoiner class by replacing internal use of
>> getChars that copies out characters from String elements into a char[] array
>> with StringBuilder which is somehow more optimal, the improvement was
>>
> I'd like to move this tool to test/lib inside a proper named package.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
move to process and a test for itself
-
Changes:
- all:
On Wed, 14 Apr 2021 18:12:57 GMT, Weijun Wang wrote:
> I'd like to move this tool to test/lib inside a proper named package.
Looks good to me.
-
Marked as reviewed by xuelei (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3496
On Wed, 14 Apr 2021 18:58:57 GMT, Peter Levart wrote:
> While JDK-8148937 improved StringJoiner class by replacing internal use of
> getChars that copies out characters from String elements into a char[] array
> with StringBuilder which is somehow more optimal, the improvement was
> marginal
On Wed, 14 Apr 2021 18:58:57 GMT, Peter Levart wrote:
> While JDK-8148937 improved StringJoiner class by replacing internal use of
> getChars that copies out characters from String elements into a char[] array
> with StringBuilder which is somehow more optimal, the improvement was
> marginal
On Wed, 14 Apr 2021 18:58:57 GMT, Peter Levart wrote:
> While JDK-8148937 improved StringJoiner class by replacing internal use of
> getChars that copies out characters from String elements into a char[] array
> with StringBuilder which is somehow more optimal, the improvement was
> marginal
While JDK-8148937 improved StringJoiner class by replacing internal use of
getChars that copies out characters from String elements into a char[] array
with StringBuilder which is somehow more optimal, the improvement was marginal
in speed (0% ... 10%) and mainly for smaller strings, while GC
On Wed, 14 Apr 2021 18:12:57 GMT, Weijun Wang wrote:
> I'd like to move this tool to test/lib inside a proper named package.
I think is fine to move it first and refactor it separately; that's a bigger
job.
If its fit for the purpose, the overlap is fine between tools.
-
PR:
On Wed, 14 Apr 2021 18:12:57 GMT, Weijun Wang wrote:
> I'd like to move this tool to test/lib inside a proper named package.
Well, we can certainly rename it. It's only used by several tests. Maybe
`ChildProcess`?
And we can certainly move it to a different package. I know it has some
On Wed, 14 Apr 2021 18:12:57 GMT, Weijun Wang wrote:
> I'd like to move this tool to test/lib inside a proper named package.
Good idea. Is there a more evocative class name than Proc?
It looks similar to jdk.test.lib.process.ProcessTools.
Would it fit in the jdk.test.lib.process package? It
I'd like to move this tool to test/lib inside a proper named package.
-
Commit messages:
- 8265227: Move Proc.java from security/testlibrary to test/lib
Changes: https://git.openjdk.java.net/jdk/pull/3496/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3496=00
Issue:
> This is a simple Test to add few additional API coverage for all java
> supported key types. The objective of this Test is to cover equals() and
> hashcode() methods for each key types.
Sibabrata Sahoo has updated the pull request incrementally with one additional
commit since the last
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
>
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
>
On Wed, 14 Apr 2021 15:03:19 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added comment to System.out/err init.
>
> src/java.base/share/classes/java/lang/System.java line 166:
>
>> 164: *
On Tue, 13 Apr 2021 19:59:30 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been
This is a simple Test to add few additional API coverage for all java supported
key types. The objective of this Test is to cover equals() and hashcode()
methods for each key types.
-
Commit messages:
- 8185127: Add Tests to cover hashCode() method for java supported crypto key
On Sat, 3 Apr 2021 22:09:55 GMT, Alex Blewitt
wrote:
> 8264681: Use the blessed modifier order in java.security
This pull request has now been integrated.
Changeset: ebbce91e
Author:Alex Blewitt
Committer: Aleksey Shipilev
URL: https://git.openjdk.java.net/jdk/commit/ebbce91e
21 matches
Mail list logo
