Re: RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3]

2021-04-22 Thread Valerie Peng
On Thu, 15 Apr 2021 10:27:25 GMT, Sibabrata Sahoo wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed an tagLen issue, no key+iv reuse check for decryption, and add >> regression test for ChaCha20 SKF. > >

Re: RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v3]

2021-04-22 Thread Valerie Peng
On Thu, 15 Apr 2021 14:25:13 GMT, Jamil Nimeh wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed an tagLen issue, no key+iv reuse check for decryption, and add >> regression test for ChaCha20 SKF. > >

Re: RFR: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider [v4]

2021-04-22 Thread Valerie Peng
> Could someone (perhaps Jamil?) please help review this change? This enhances > SunPKCS11 provider with ChaCha20-Poly1305 cipher and ChaCha20 key generation > support. Majority of the regression tests are adapted from the existing ones > for SunJCE provider's ChaCha20-Poly1305 cipher impl.

Re: RFR: 8264208: Console charset API [v12]

2021-04-22 Thread Roger Riggs
On Thu, 22 Apr 2021 17:38:43 GMT, Naoto Sato wrote: >> Please review the changes for the subject issue. This has been suggested in >> a recent discussion thread for the JEP 400 >> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. >> A CSR has also been

Integrated: 8258915: Temporary buffer cleanup

2021-04-22 Thread Weijun Wang
On Wed, 13 Jan 2021 21:32:07 GMT, Weijun Wang wrote: > Clean up temporary byte array, char array, and keyspec around keys and > passwords. > > No new regression test. This pull request has now been integrated. Changeset: f834557a Author:Weijun Wang URL:

Re: RFR: 8258915: Temporary buffer cleanup [v10]

2021-04-22 Thread Weijun Wang
> Clean up temporary byte array, char array, and keyspec around keys and > passwords. > > No new regression test. Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: - Merge branch 'master' into 8258915 -

Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-04-22 Thread Ron Pressler
On 22 Apr 2021, at 18:27, Reinier Zwitserloot mailto:rein...@zwitserloot.com>> wrote: For example, I may want to restrict access to the 'logs' directory. I can't restrict it at the OS level (because the JVM does need to write the log files, of course), at best I can restrict it at the module

Re: RFR: 8264208: Console charset API [v12]

2021-04-22 Thread Naoto Sato
> Please review the changes for the subject issue. This has been suggested in > a recent discussion thread for the JEP 400 > [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. > A CSR has also been drafted, and comments are welcome >

Re: RFR: 8264208: Console charset API [v11]

2021-04-22 Thread Naoto Sato
On Thu, 22 Apr 2021 16:29:35 GMT, Roger Riggs wrote: >> Then `charset()` in the shared secret would return `null`. Would that >> suffice your case? > > I read lines 575-587 as initializing CHARSET regardless of whether the > Console was created. OK, revived the charset() method.

Re: JEP411: Missing use-case: Monitoring / restricting libraries

2021-04-22 Thread Reinier Zwitserloot
> Alan Bateman wrote: > security features for XML processing can be controlled programmatically, it doesn't require a security manager to do that. Yes, it would be nice, and it is feasible, for XML parser libraries to gain API calls to tell them to never hit the disk or the network to resolve

Re: RFR: 8264208: Console charset API [v11]

2021-04-22 Thread Roger Riggs
On Thu, 22 Apr 2021 16:11:16 GMT, Naoto Sato wrote: >> Not always, for example, if stderr was redirected to a terminal but not >> stdin and stdout. >> The istty check is only true if both stdin and stdout are ttys. > > Then `charset()` in the shared secret would return `null`. Would that

Re: RFR: 8264208: Console charset API [v11]

2021-04-22 Thread Naoto Sato
On Thu, 22 Apr 2021 16:03:12 GMT, Roger Riggs wrote: >> Would the singleton `Console.cons` be instantiated in your use case? It is >> created only when isatty() (or Windows' equivalent) in the native code >> returns true. > > Not always, for example, if stderr was redirected to a terminal but

Re: RFR: 8264208: Console charset API [v11]

2021-04-22 Thread Roger Riggs
On Thu, 22 Apr 2021 15:42:02 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/io/Console.java line 597: >> >>> 595: return null; >>> 596: } >>> 597: }); >> >> Please keep the charset() method and return CHARSET. >> >> I'm looking at a use case

Re: RFR: 8264208: Console charset API [v11]

2021-04-22 Thread Naoto Sato
On Thu, 22 Apr 2021 15:18:11 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >> commits

Re: RFR: 8228442: DHKeyExchange/LegacyDHEKeyExchange.java failed due to "SSLException: An established connection was aborted by the software in your host machine"

2021-04-22 Thread Xue-Lei Andrew Fan
On Thu, 22 Apr 2021 11:41:40 GMT, Fernando Guallini wrote: > Test DHKeyExchange/LegacyDHEKeyExchange.java has been seen to fail > intermittently. There is a thread synchronisation issue that is fixed by: > > - Using SSLSocketTemplate that handles client/server socket configuration and >

Re: RFR: 8264208: Console charset API [v11]

2021-04-22 Thread Roger Riggs
On Tue, 20 Apr 2021 22:35:00 GMT, Naoto Sato wrote: >> Please review the changes for the subject issue. This has been suggested in >> a recent discussion thread for the JEP 400 >> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. >> A CSR has also been

RFR: 8228442: DHKeyExchange/LegacyDHEKeyExchange.java failed due to "SSLException: An established connection was aborted by the software in your host machine"

2021-04-22 Thread Fernando Guallini
Test DHKeyExchange/LegacyDHEKeyExchange.java has been seen to fail intermittently. There is a thread synchronisation issue that is fixed by: - Using SSLSocketTemplate that handles client/server socket configuration and synchronisation before connection - Making use of a CountDownLatch and