Re: RFR: 8265426: Update java.security to use instanceof pattern variable

2021-04-26 Thread Punikekk
On Mon, 26 Apr 2021 08:50:36 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the > `java.security` package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-04-26 Thread Greg Rubin
On Tue, 27 Apr 2021 02:41:12 GMT, Valerie Peng wrote: > Anyone can help review this somewhat trivial fix? The main change is inside > src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c. This is to > help better troubleshooting by reporting the type of unavailable attributes > in

RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-04-26 Thread Valerie Peng
Anyone can help review this somewhat trivial fix? The main change is inside src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c. This is to help better troubleshooting by reporting the type of unavailable attributes in PKCS11 exception message when C_GetAttributeValue(...) call

Re: RFR: 8265426: Update java.security to use instanceof pattern variable

2021-04-26 Thread Weijun Wang
On Mon, 26 Apr 2021 08:50:36 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the > `java.security` package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Two comments: 1. Why not reuse the existing variable

Re: RFR: 8265426: Update java.security to use instanceof pattern variable

2021-04-26 Thread Weijun Wang
On Mon, 26 Apr 2021 08:50:36 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the > `java.security` package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Two comments: 1. Why not reuse the existing variable

Re: RFR: 8265426: Update java.security to use instanceof pattern variable

2021-04-26 Thread Roger Riggs
On Mon, 26 Apr 2021 08:50:36 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the > `java.security` package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Marked as reviewed by rriggs (Reviewer).

RFR: 8196415: Disable SHA-1 Signed JARs

2021-04-26 Thread Sean Mullan
This change will restrict JARs signed with SHA-1 algorithms and treat them as if they were unsigned. This applies to the algorithms used to digest, sign, and optionally timestamp the JAR. It also applies to the signature and digest algorithms of the certificates in the certificate chain of the

Re: RFR: 8265426: Update java.security to use instanceof pattern variable

2021-04-26 Thread Jesper Steen Møller
On Mon, 26 Apr 2021 08:50:36 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the > `java.security` package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Changes look good, except for the unneeded

Re: [External] : Re: Bug with TLSv1.3 session resumption (most likely caused by concurrency bug)

2021-04-26 Thread Jamil Nimeh
Hi Alexey, I'm in the process of reviewing it. --Jamil On 4/26/21 4:24 AM, Alexey Bakhtin wrote: Hi Jamil, Norman, I’ve missed this thread discussing JDK-8241248 issue. Recently I have suggested a fix for this issue : https://github.com/openjdk/jdk/pull/3664 Regards Alexey On 26 Apr 2021,

Re: RFR: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)

2021-04-26 Thread Norman Maurer
On Fri, 23 Apr 2021 20:51:19 GMT, Alexey Bakhtin wrote: > Hello All, > > Could you please review the fix for the JDK-8241248? > The issue happens during the TLSv1.3 handshake without server stateless > session resumption in case of server receives several parallel requests with > the same

Re: RFR: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI [v2]

2021-04-26 Thread Daniel Fuchs
On Sun, 25 Apr 2021 09:45:15 GMT, YassinHajaj wrote: >> src/java.naming/share/classes/com/sun/jndi/ldap/LdapPoolManager.java line >> 400: >> >>> 398: private static final String getProperty(final String propName, >>> final String defVal) { >>> 399: PrivilegedAction pa = () ->

Re: [External] : Re: Bug with TLSv1.3 session resumption (most likely caused by concurrency bug)

2021-04-26 Thread Alexey Bakhtin
Hi Jamil, Norman, I’ve missed this thread discussing JDK-8241248 issue. Recently I have suggested a fix for this issue : https://github.com/openjdk/jdk/pull/3664 Regards Alexey > On 26 Apr 2021, at 11:31, Norman Maurer wrote: > > Sorry for the noise but is there any update ? The bug makes it

RFR: 8265426: Update java.security to use instanceof pattern variable

2021-04-26 Thread Patrick Concannon
Hi, Could someone please review my code for updating the code in the `java.security` package to make use of the `instanceof` pattern variable? Kind regards, Patrick - Commit messages: - 8265426: Update java.security to use instanceof pattern variable Changes:

Re: [External] : Re: Bug with TLSv1.3 session resumption (most likely caused by concurrency bug)

2021-04-26 Thread Norman Maurer
Sorry for the noise but is there any update ? The bug makes it “impossible” for us to enable caching by default as it may cause issues on the remote peer which are hard to debug. Bye Norman > On 19. Mar 2021, at 16:34, Jamil Nimeh wrote: > > Hi Norman, I've been working a couple other bugs,