Re: RFR: 8185127: Add tests to cover hashCode() method for java supported crypto key types [v9]

2021-04-27 Thread Sibabrata Sahoo
> This is a simple Test to add few additional API coverage for all java > supported key types. The objective of this Test is to cover equals() and > hashcode() methods for each key types. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revisi

Re: RFR: 8185127: Add tests to cover hashCode() method for java supported crypto key types [v6]

2021-04-27 Thread Sibabrata Sahoo
On Wed, 21 Apr 2021 00:16:59 GMT, Valerie Peng wrote: >> Sibabrata Sahoo has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update CompareKeys.java >> - Update CompareKeys.java > > test/jdk/javax/crypto/KeyGenerator/CompareKeys.java line

Integrated: 8263779: SSLEngine reports NEED_WRAP continuously without producing any further output

2021-04-27 Thread Xue-Lei Andrew Fan
On Wed, 31 Mar 2021 20:52:57 GMT, Xue-Lei Andrew Fan wrote: > As described in the bug, by connecting the SSLEngine with a misbehaving peer > SSL implementation, it can get into a state where it calling `wrap` reports > getStatus == OK, getHandshakeStatus === NEED_WRAP but still doesn't produce

Re: RFR: 8263779: SSLEngine reports NEED_WRAP continuously without producing any further output [v3]

2021-04-27 Thread Xue-Lei Andrew Fan
> As described in the bug, by connecting the SSLEngine with a misbehaving peer > SSL implementation, it can get into a state where it calling `wrap` reports > getStatus == OK, getHandshakeStatus === NEED_WRAP but still doesn't produce > any further output. It happens when the output bound is n

Re: RFR: 8263779: SSLEngine reports NEED_WRAP continuously without producing any further output [v2]

2021-04-27 Thread Xue-Lei Andrew Fan
On Wed, 28 Apr 2021 00:03:31 GMT, Bradford Wetmore wrote: > SSLEngineOutputRecord.java: > Missing copyright date update. > Yes, I missed the copyright date. > SSLEngineOutputRecord:77 > Unnecessary extra line added. Please remove. Oops, I will correct it. - PR: https://git.openj

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator)

2021-04-27 Thread Paul Sandoz
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore wrote: > This PR contains the API and implementation changes for JEP-412 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.jav

Re: RFR: 8263779: SSLEngine reports NEED_WRAP continuously without producing any further output [v2]

2021-04-27 Thread Xue-Lei Andrew Fan
On Tue, 27 Apr 2021 23:48:23 GMT, Bradford Wetmore wrote: >> Xue-Lei Andrew Fan has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains three >> additio

Re: RFR: 8263779: SSLEngine reports NEED_WRAP continuously without producing any further output [v2]

2021-04-27 Thread Bradford Wetmore
On Thu, 22 Apr 2021 04:13:54 GMT, Xue-Lei Andrew Fan wrote: >> As described in the bug, by connecting the SSLEngine with a misbehaving peer >> SSL implementation, it can get into a state where it calling `wrap` reports >> getStatus == OK, getHandshakeStatus === NEED_WRAP but still doesn't produ

Re: RFR: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)

2021-04-27 Thread Alexey Bakhtin
On Tue, 27 Apr 2021 16:13:31 GMT, Xue-Lei Andrew Fan wrote: >> Hello All, >> >> Could you please review the fix for the JDK-8241248? >> The issue happens during the TLSv1.3 handshake without server stateless >> session resumption in case of server receives several parallel requests with >> the

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator)

2021-04-27 Thread Maurizio Cimadamore
On Tue, 27 Apr 2021 18:46:02 GMT, Alan Bateman wrote: >> This PR contains the API and implementation changes for JEP-412 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjdk.java.n

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-04-27 Thread Greg Rubin
On Tue, 27 Apr 2021 02:41:12 GMT, Valerie Peng wrote: > Anyone can help review this somewhat trivial fix? The main change is inside > src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c. This is to > help better troubleshooting by reporting the type of unavailable attributes > in PK

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-04-27 Thread Valerie Peng
On Tue, 27 Apr 2021 18:49:30 GMT, Valerie Peng wrote: >> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_util.c line 189: >> >>> 187: * returnValue is CKR_OK. Otherwise, it returns the returnValue as a >>> jLong. >>> 188: * >>> 189: * @param env - used to call JNI funktions and to get t

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-04-27 Thread Valerie Peng
On Tue, 27 Apr 2021 15:13:10 GMT, Greg Rubin wrote: >> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c line 262: >> >>> 260: temp1 = msg; >>> 261: temp2 = msg + 80; >>> 262: for (i = 0; i < ckAttributesLength && temp1 < temp2; i++) { >> >> I t

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-04-27 Thread Greg Rubin
On Tue, 27 Apr 2021 18:36:28 GMT, Valerie Peng wrote: >> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c line 252: >> >>> 250: >>> 251: if (rv != CKR_OK) { >>> 252: if (rv == CKR_ATTRIBUTE_SENSITIVE || rv == >>> CKR_ATTRIBUTE_TYPE_INVALID) { >> >> According to the P

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-04-27 Thread Valerie Peng
On Tue, 27 Apr 2021 04:27:10 GMT, Greg Rubin wrote: >> Anyone can help review this somewhat trivial fix? The main change is inside >> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c. This is to >> help better troubleshooting by reporting the type of unavailable attributes >> in

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator)

2021-04-27 Thread Alan Bateman
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore wrote: > This PR contains the API and implementation changes for JEP-412 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.jav

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-04-27 Thread Valerie Peng
On Tue, 27 Apr 2021 04:31:42 GMT, Greg Rubin wrote: >> Anyone can help review this somewhat trivial fix? The main change is inside >> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c. This is to >> help better troubleshooting by reporting the type of unavailable attributes >> in

RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator)

2021-04-27 Thread Maurizio Cimadamore
This PR contains the API and implementation changes for JEP-412 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment. [1] - https://openjdk.java.net/jeps/412 - Commit messages: - Add linker test exclude

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator)

2021-04-27 Thread Maurizio Cimadamore
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore wrote: > This PR contains the API and implementation changes for JEP-412 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.jav

Re: RFR: 8185127: Add tests to cover hashCode() method for java supported crypto key types [v8]

2021-04-27 Thread Valerie Peng
On Tue, 27 Apr 2021 08:13:03 GMT, Sibabrata Sahoo wrote: >> This is a simple Test to add few additional API coverage for all java >> supported key types. The objective of this Test is to cover equals() and >> hashcode() methods for each key types. > > Sibabrata Sahoo has updated the pull reques

Re: RFR: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)

2021-04-27 Thread Xue-Lei Andrew Fan
On Fri, 23 Apr 2021 20:51:19 GMT, Alexey Bakhtin wrote: > Hello All, > > Could you please review the fix for the JDK-8241248? > The issue happens during the TLSv1.3 handshake without server stateless > session resumption in case of server receives several parallel requests with > the same pre_

Re: RFR: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)

2021-04-27 Thread Jamil Nimeh
On Fri, 23 Apr 2021 20:51:19 GMT, Alexey Bakhtin wrote: > Hello All, > > Could you please review the fix for the JDK-8241248? > The issue happens during the TLSv1.3 handshake without server stateless > session resumption in case of server receives several parallel requests with > the same pre_

Re: RFR: JDK-6676643: Improve current C_GetAttributeValue native implementation

2021-04-27 Thread Greg Rubin
On Tue, 27 Apr 2021 04:28:26 GMT, Greg Rubin wrote: >> Anyone can help review this somewhat trivial fix? The main change is inside >> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_objmgmt.c. This is to >> help better troubleshooting by reporting the type of unavailable attributes >> in

Re: RFR: 8196415: Disable SHA-1 Signed JARs

2021-04-27 Thread Sean Coffey
On Mon, 26 Apr 2021 17:29:26 GMT, Sean Mullan wrote: > This change will restrict JARs signed with SHA-1 algorithms and treat them as > if they were unsigned. This applies to the algorithms used to digest, sign, > and optionally timestamp the JAR. It also applies to the signature and digest > a

Re: RFR: 8185127: Add tests to cover hashCode() method for java supported crypto key types [v8]

2021-04-27 Thread Sibabrata Sahoo
> This is a simple Test to add few additional API coverage for all java > supported key types. The objective of this Test is to cover equals() and > hashcode() methods for each key types. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revisi

Re: RFR: 8185127: Add tests to cover hashCode() method for java supported crypto key types [v7]

2021-04-27 Thread Sibabrata Sahoo
> This is a simple Test to add few additional API coverage for all java > supported key types. The objective of this Test is to cover equals() and > hashcode() methods for each key types. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revisi