On Thu, 20 May 2021 18:05:48 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
>
On Thu, 20 May 2021 01:17:14 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
>
On Thu, 20 May 2021 00:37:44 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
>
On Tue, 1 Jun 2021 19:28:44 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
>> line 874:
>>
>>> 872: } else if (!src.isDirect() && !dst.isDirect()) {
>>> 873: // if src is read only, then we need a copy
>>> 874:
On Wed, 19 May 2021 23:59:36 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
>
On Wed, 19 May 2021 23:10:07 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
>
On Wed, 19 May 2021 22:05:16 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
>
On Sun, 30 May 2021 07:25:54 GMT, Valerie Peng wrote:
>> This change updates SunJCE provider as below:
>> - updated existing AESWrap support with AES/KW/NoPadding cipher
>> transformation.
>> - added support for AES/KWP/NoPadding and AES/KW/PKCS5Padding.
>>
>> Existing AESWrap impl, i.e.
On Tue, 1 Jun 2021 18:54:19 GMT, Valerie Peng wrote:
>> Yeah, I changed this code long ago, i suspect I didn't realize
>> engineGetParameters() used it
>
> It seems that you still have not saved the specified 'random' into the
> instance 'random' field? Did I miss something?
yeah.. i think i
On Sun, 30 May 2021 07:25:54 GMT, Valerie Peng wrote:
>> This change updates SunJCE provider as below:
>> - updated existing AESWrap support with AES/KW/NoPadding cipher
>> transformation.
>> - added support for AES/KWP/NoPadding and AES/KW/PKCS5Padding.
>>
>> Existing AESWrap impl, i.e.
On Tue, 1 Jun 2021 16:34:44 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove GCTR reset() calls because GCTR is released after the operation
>> some variable name consistency
>>
On Mon, 24 May 2021 22:36:49 GMT, Anthony Scarpino
wrote:
>> test/jdk/com/sun/crypto/provider/Cipher/AEAD/GCMShortBuffer.java line 34:
>>
>>> 32: /*
>>> 33: * @test
>>> 34: * @summary Call decrypt doFinal() with different output values to see
>>> if the
>>
>> Missing bug id?
>
> Here is my
On Thu, 20 May 2021 00:57:42 GMT, Valerie Peng wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix perf problem by reorganizing doLastBlock()
>
>
On Fri, 21 May 2021 04:15:44 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
>> line 628:
>>
>>> 626: }
>>> 627:
>>> 628: int mergeBlock(byte[] buffer, int bufOfs, byte[] in, int inOfs,
>>
>> Can be made 'static'? No
On Fri, 21 May 2021 03:07:15 GMT, Anthony Scarpino
wrote:
>> yeah these checks are a bit all over the place.. I'll rework them
>
> So I think I only need to add a check to the engineDoFinal() that did not
> have a check before.
for engineUpdate(...) impl, the ArrayUtil.nullAndBoundsCheck()
On Mon, 24 May 2021 16:37:05 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/GHASH.java line 189:
>>
>>> 187: ct.position(ct.position());
>>> 188: return processed;
>>> 189: } else if (!ct.isReadOnly()) {
>>
>> Maybe you
On Wed, 26 May 2021 21:13:56 GMT, Anthony Scarpino
wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and
On Tue, 18 May 2021 13:19:53 GMT, Fernando Guallini
wrote:
> Refactor the following shell tests to Java:
> - security/pkcs11/KeyStore/Basic.sh
> - security/pkcs11/KeyStore/ClientAuth.sh
> - security/pkcs11/KeyStore/SecretKeysBasic.sh
> - security/pkcs11/Provider/ConfigQuotedString.sh
> -
On 6/1/21 1:30 PM, Chapman Flack wrote:
On 06/01/21 12:32, Sean Mullan wrote:
On 6/1/21 2:11 AM, Peter Firmstone wrote:
Would have really liked to have known about that.
It was announced on jdk-dev at the time it was launched, with a follow-up
reminder one week later:
We have updated the JEP with a few changes to the "Issue Warnings"
section [1], summarized as follows:
If the Java runtime is started without setting the system property
'java.security.manager' then a custom Security Manager can be installed
dynamically by calling System::setSecurityManager, just
RE:no
A further point is that `-Djava.security.manager=allow` has been
special-cased since JDK 12:
- RFE:
https://bugs.openjdk.java.net/browse/JDK-8191053
- Compatibility review:
https://bugs.openjdk.java.net/browse/JDK-8203316
- Release note:
On 06/01/21 12:32, Sean Mullan wrote:
> On 6/1/21 2:11 AM, Peter Firmstone wrote:
>> Would have really liked to have known about that.
>
> It was announced on jdk-dev at the time it was launched, with a follow-up
> reminder one week later:
>
>
On Mon, 31 May 2021 16:21:29 GMT, Daniel Fuchs wrote:
> The Utils.remaining(List list) method assumes that it can and
> should synchronize on the given list to prevent concurrent modification. In
> 99% of the cases this assumption is wrong. There's only one such list (the
> SSLFlowDelegate
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull
The survey was also shared by @java to its many followers, fwiw:
https://twitter.com/java/status/961296752732135424?s=20
and through the OpenJDK Quality Outreach to the many projects
participating there:
https://mail.openjdk.java.net/pipermail/quality-discuss/2018-February/000749.html
If
On 6/1/21 2:11 AM, Peter Firmstone wrote:
Would have really liked to have known about that.
It was announced on jdk-dev at the time it was launched, with a
follow-up reminder one week later:
https://mail.openjdk.java.net/pipermail/jdk-dev/2018-February/000649.html
--Sean
Any chance
On Tue, 1 Jun 2021 15:21:33 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Tue, 1 Jun 2021 15:21:33 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Fri, 28 May 2021 15:50:23 GMT, Fernando Guallini
wrote:
>> Refactor the following shell tests to Java:
>> - security/pkcs11/KeyStore/Basic.sh
>> - security/pkcs11/KeyStore/ClientAuth.sh
>> - security/pkcs11/KeyStore/SecretKeysBasic.sh
>> - security/pkcs11/Provider/ConfigQuotedString.sh
>> -
On Fri, 28 May 2021 15:50:23 GMT, Fernando Guallini
wrote:
>> Refactor the following shell tests to Java:
>> - security/pkcs11/KeyStore/Basic.sh
>> - security/pkcs11/KeyStore/ClientAuth.sh
>> - security/pkcs11/KeyStore/SecretKeysBasic.sh
>> - security/pkcs11/Provider/ConfigQuotedString.sh
>> -
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP,
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP,
On 01.06.2021 08:11, Peter Firmstone wrote:
Any chance Java 17 LTS (hopefully with sorted security manager
property), can be supported as long as Java 8, 16 years?
According to the Oracle Java SE Support Roadmap at
https://www.oracle.com/java/technologies/java-se-support-roadmap.html
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
That depends what you mean by “acceptable.” You can maintain a version of the
Java SE spec that
contains the Security Manager forever. If you want to add the SecurityManager
to a version of
the spec that doesn’t contain it (or contains it but behaves in a degraded
manner) then that
will not
If a vendor were to continue supporting SecurityManager and was
backporting from OpenJDK, if it passes the JCK with SecurityManager
disabled, that's still acceptable right?
--
Regards,
Peter Firmstone
> On 31 May 2021, at 22:53, Chapman Flack wrote:
>
>
> I am not sure what you are getting at with goal 3. Will the warning
> phone home?
No, but it will make users aware, and that awareness can be measured or
estimated.
>
> I am also sort of wondering what's to become of some of the
On 31/05/2021 22:53, Chapman Flack wrote:
:
Thank you for that. One question I have been wondering about: do you have
any internally-tracked metrics that you can share about how many uses
of doPrivileged there are in the JDK codebase, and perhaps even a histogram
of the stack depth from the
Would have really liked to have known about that.
Any chance Java 17 LTS (hopefully with sorted security manager
property), can be supported as long as Java 8, 16 years?
The new security API's don't exist yet, I'd prefer to work with a
version that has a fully functional SecurityManager
40 matches
Mail list logo
