Re: RFR: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance

2021-06-10 Thread Dongbo He
On Wed, 9 Jun 2021 17:52:37 GMT, Xue-Lei Andrew Fan wrote: >> Now AlgorithmConstraints:checkAlgorithm uses List to check if an algorithm >> has been disabled. It is less efficient when there are more disabled >> elements in the list, we can use Set instead of List to speed up the search. >> >>

Re: Low level hooks in JDK for instrumentation of permission checks.

2021-06-10 Thread Alan Bateman
On 10/06/2021 07:40, Peter Firmstone wrote: Just a quick question, would it be possible that some JFR hooks might also be useable for an authorisation layer? JFR events can't be used to intercept/veto operations, assuming that is what you are asking. However, it might be that JFR events are

RFR: 8268525: Some new memory leak after JDK-8248268 and JDK-8255557

2021-06-10 Thread Weijun Wang
Remove newly leaked memory. - Commit messages: - 8268525: Some new memory leak after JDK-8248268 and JDK-827 Changes: https://git.openjdk.java.net/jdk/pull/4466/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4466&range=00 Issue: https://bugs.openjdk.java.net/brow

Withdrawn: 8268525: Some new memory leak after JDK-8248268 and JDK-8255557

2021-06-10 Thread Weijun Wang
On Thu, 10 Jun 2021 15:40:56 GMT, Weijun Wang wrote: > Remove newly leaked memory. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/4466

[jdk17] RFR: 8268525: Some new memory leak after JDK-8248268 and JDK-8255557

2021-06-10 Thread Weijun Wang
Remove newly leaked memory. - Commit messages: - 8268525: Some new memory leak after JDK-8248268 and JDK-827 Changes: https://git.openjdk.java.net/jdk17/pull/3/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=3&range=00 Issue: https://bugs.openjdk.java.net/browse

Re: RFR: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance

2021-06-10 Thread Sean Mullan
On Wed, 9 Jun 2021 07:53:43 GMT, Dongbo He wrote: > Now AlgorithmConstraints:checkAlgorithm uses List to check if an algorithm > has been disabled. It is less efficient when there are more disabled elements > in the list, we can use Set instead of List to speed up the search. > > Patch contain

Re: [jdk17] RFR: 8268525: Some new memory leak after JDK-8248268 and JDK-8255557

2021-06-10 Thread Valerie Peng
On Thu, 10 Jun 2021 17:10:22 GMT, Weijun Wang wrote: > Remove newly leaked memory. Marked as reviewed by valeriep (Reviewer). Changes look good to me. Thanks for catching these. Valerie - PR: https://git.openjdk.java.net/jdk17/pull/3

Re: [jdk17] RFR: 8268525: Some new memory leak after JDK-8248268 and JDK-8255557

2021-06-10 Thread Anthony Scarpino
On Thu, 10 Jun 2021 17:10:22 GMT, Weijun Wang wrote: > Remove newly leaked memory. They look fine - Marked as reviewed by ascarpino (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/3

Re: [jdk17] RFR: 8268525: Some new memory leak after JDK-8248268 and JDK-8255557 [v2]

2021-06-10 Thread Weijun Wang
> Remove newly leaked memory. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: clean up one class - Changes: - all: https://git.openjdk.java.net/jdk17/pull/3/files - new: https://git.openjdk.java.net/jdk17/pull/3/files

Re: [jdk17] RFR: 8268525: Some new memory leak after JDK-8248268 and JDK-8255557 [v2]

2021-06-10 Thread Valerie Peng
On Thu, 10 Jun 2021 20:04:13 GMT, Weijun Wang wrote: >> Remove newly leaked memory. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > clean up one class Update looks good. - Marked as reviewed by valeriep (Revie

[jdk17] Integrated: 8268525: Some new memory leak after JDK-8248268 and JDK-8255557

2021-06-10 Thread Weijun Wang
On Thu, 10 Jun 2021 17:10:22 GMT, Weijun Wang wrote: > Remove newly leaked memory. This pull request has now been integrated. Changeset: 7b2e7d8b Author:Weijun Wang URL: https://git.openjdk.java.net/jdk17/commit/7b2e7d8bab890bd655093976cc9c3b0b6d00c034 Stats: 158 lines in 5 file

Withdrawn: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE

2021-06-10 Thread Weijun Wang
On Mon, 7 Jun 2021 20:57:52 GMT, Weijun Wang wrote: > The test must run with sudo but I forgot to mention it. New comment and a > better error message is added. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/4401

[jdk17] RFR: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE

2021-06-10 Thread Weijun Wang
The test must run with sudo but I forgot to mention it. New comment and a better error message is added. - Commit messages: - 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE Changes: https://git.openjdk.java.net/jdk17/pull/12/files

Withdrawn: 8268349: Provide more detail in JEP 411 warning messages

2021-06-10 Thread Weijun Wang
On Mon, 7 Jun 2021 20:42:53 GMT, Weijun Wang wrote: > More loudly and precise warning messages when a security manager is either > enabled at startup or installed at runtime. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/44

[jdk17] RFR: 8268349: Provide more detail in JEP 411 warning messages

2021-06-10 Thread Weijun Wang
More loudly and precise warning messages when a security manager is either enabled at startup or installed at runtime. This is new PR for the `openjdk/jdk17` repo copied from https://github.com/openjdk/jdk/pull/4400. A new commit is added. - Commit messages: - no cache, new warnin

Re: RFR: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance

2021-06-10 Thread Dongbo He
On Thu, 10 Jun 2021 18:10:37 GMT, Sean Mullan wrote: > I think it would be worthwhile to see if we can take this a step further, and > leverage the `Constraint` objects that are already created and stored in the > `Constraints` object in a `HashMap>`. The key is the > algorithm `String`, and t

Re: RFR: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance

2021-06-10 Thread Xue-Lei Andrew Fan
On Thu, 10 Jun 2021 06:59:25 GMT, Dongbo He wrote: >> src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java >> line 130: >> >>> 128: AlgorithmDecomposer decomposer) { >>> 129: super(decomposer); >>> 130: List disabledAlgorithmsList = >>> ge