Re: RFR: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance [v4]

2021-06-21 Thread Dongbo He
On Tue, 22 Jun 2021 03:45:32 GMT, Xue-Lei Andrew Fan wrote: >> Dongbo He has updated the pull request incrementally with one additional >> commit since the last revision: >> >> refactor the code && fix some errors > > src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.

Re: RFR: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance [v5]

2021-06-21 Thread Dongbo He
> Now AlgorithmConstraints:checkAlgorithm uses List to check if an algorithm > has been disabled. It is less efficient when there are more disabled elements > in the list, we can use Set instead of List to speed up the search. > > Patch contains a benchmark that can be run with `make test > TES

Re: RFR: 8266182: Create a manual test for jdk/sun/security/pkcs12/ParamsTest.java [v3]

2021-06-21 Thread Sibabrata Sahoo
On Fri, 18 Jun 2021 13:24:17 GMT, Abdul Kolarkunnu wrote: >> ParamsTest is an interop test between keytool <-> openssl. There are some >> manual steps listed in jdk/sun/security/pkcs12/params/README to perform >> after the execution of jtreg execution. So this test is to perform that >> manua

Re: RFR: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance [v4]

2021-06-21 Thread Xue-Lei Andrew Fan
On Tue, 22 Jun 2021 02:46:02 GMT, Dongbo He wrote: >> Now AlgorithmConstraints:checkAlgorithm uses List to check if an algorithm >> has been disabled. It is less efficient when there are more disabled >> elements in the list, we can use Set instead of List to speed up the search. >> >> Patch c

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v7]

2021-06-21 Thread Yi Yang
On Tue, 22 Jun 2021 02:39:01 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has updated the pull request incrementally

Re: RFR: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance [v4]

2021-06-21 Thread Dongbo He
> Now AlgorithmConstraints:checkAlgorithm uses List to check if an algorithm > has been disabled. It is less efficient when there are more disabled elements > in the list, we can use Set instead of List to speed up the search. > > Patch contains a benchmark that can be run with `make test > TES

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v7]

2021-06-21 Thread Yi Yang
> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex > by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in > the whole JDK codebase. Yi Yang has updated the pull request incrementally with one additional commit since the last revision: corr

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v6]

2021-06-21 Thread Yi Yang
On Mon, 21 Jun 2021 20:49:56 GMT, Paul Sandoz wrote: >> Yi Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more replacement 2 > > src/java.base/share/classes/jdk/internal/util/Preconditions.java line 78: > >> 76: = Prec

[jdk17] Integrated: 8268349: Provide clear run-time warnings about Security Manager deprecation

2021-06-21 Thread Weijun Wang
On Fri, 11 Jun 2021 01:59:59 GMT, Weijun Wang wrote: > More loudly and precise warning messages when a security manager is either > enabled at startup or installed at runtime. > > This is new PR for the `openjdk/jdk17` repo copied from > https://github.com/openjdk/jdk/pull/4400. A new commit i

[jdk17] Integrated: 8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs

2021-06-21 Thread Weijun Wang
On Mon, 21 Jun 2021 22:43:58 GMT, Weijun Wang wrote: > This is a copy of https://github.com/openjdk/jdk17/pull/100 so that I can > integrate the fix for @seanjmullan. This pull request has now been integrated. Changeset: e2d7ec38 Author:Weijun Wang URL: https://git.openjdk.java.net

Re: [jdk17] RFR: 8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs

2021-06-21 Thread Xue-Lei Andrew Fan
On Mon, 21 Jun 2021 22:43:58 GMT, Weijun Wang wrote: > This is a copy of https://github.com/openjdk/jdk17/pull/100 so that I can > integrate the fix for @seanjmullan. Marked as reviewed by xuelei (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/113

Re: [jdk17] RFR: 8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs

2021-06-21 Thread Hai-May Chao
On Mon, 21 Jun 2021 22:43:58 GMT, Weijun Wang wrote: > This is a copy of https://github.com/openjdk/jdk17/pull/100 so that I can > integrate the fix for @seanjmullan. Marked as reviewed by hchao (Committer). - PR: https://git.openjdk.java.net/jdk17/pull/113

Re: RFR: 8266182: Create a manual test for jdk/sun/security/pkcs12/ParamsTest.java [v3]

2021-06-21 Thread Hai-May Chao
On Fri, 18 Jun 2021 13:24:17 GMT, Abdul Kolarkunnu wrote: >> ParamsTest is an interop test between keytool <-> openssl. There are some >> manual steps listed in jdk/sun/security/pkcs12/params/README to perform >> after the execution of jtreg execution. So this test is to perform that >> manua

[jdk17] RFR: 8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs

2021-06-21 Thread Weijun Wang
This is a copy of https://github.com/openjdk/jdk17/pull/100 so that I can integrate the fix for @seanjmullan. - Commit messages: - [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs. Changes: https://git.openjdk.java.net/jdk17/pull/113/files Webrev: https://webrevs.openjdk.java.net/?

Re: RFR: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance [v3]

2021-06-21 Thread Xue-Lei Andrew Fan
On Thu, 17 Jun 2021 08:16:42 GMT, Dongbo He wrote: >> Now AlgorithmConstraints:checkAlgorithm uses List to check if an algorithm >> has been disabled. It is less efficient when there are more disabled >> elements in the list, we can use Set instead of List to speed up the search. >> >> Patch c

Re: RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible [v6]

2021-06-21 Thread Paul Sandoz
On Mon, 21 Jun 2021 05:17:09 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. > > Yi Yang has updated the pull request incrementally

Re: RFR: JDK-8268464 : Remove dependancy of TestHttpsServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests [v4]

2021-06-21 Thread Michael McMahon
On Thu, 17 Jun 2021 16:23:08 GMT, Mahendra Chhipa wrote: >> …HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented review comments test/jdk/sun/ne