> Sufficient permissions missing if this code was ever to run with
> SecurityManager.
>
> Cleanest approach appears to be use of InnocuousThread to create the
> cleaner/poller threads.
> Test case coverage extended to cover the SecurityManager scenario.
>
> Reviewer request: @valeriepeng
Hi Valerie,
many thanks for the thorough review. I've taken all your feedback on
board with the latest push. Some of the test anomalies were a result of
previous iterations of test edits I had been making.
Regarding the extra edits in
"src/java.base/share/lib/security/default.policy", I had
On Mon, 28 Jun 2021 18:03:56 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
>
> Note: this is copied from
On 28/06/2021 18:16, Jaikiran Pai wrote:
On a slightly related note, I was wondering why we decided to go with
what appears to be a bit more aggressive approach to these warning
messages as compared to what was done with the illegal reflective
access warnings? I would have thought that the
On Mon, 28 Jun 2021 18:03:56 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
>
> Note: this is copied from
More refactoring to limit the scope of `@SuppressWarnings` annotations.
Sometimes I introduce new methods. Please feel free to suggest method names you
like to use.
Note: this is copied from https://github.com/openjdk/jdk17/pull/152.
-
Commit messages:
- copy all code change from
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
This pull request has been closed without being integrated.
(resending from the correct subscribed address)
Given the recent changes around the Java SecurityManager deprecation,
the Ant project has been asking for user feedback on how this change
impacts them with their Ant build files/tasks. So far we have received
two separate user reports around
On Mon, 28 Jun 2021 12:20:38 GMT, Daniel Fuchs wrote:
>> This cast is only to tell the compiler which overloaded method to call, and
>> I don't think there will be a real cast at runtime. It might look a little
>> ugly but extracting it into a variable declaration/definition plus a new
>>
On Fri, 25 Jun 2021 23:40:27 GMT, Weijun Wang wrote:
>> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>>
>> Sometimes I introduce new methods. Please feel free to suggest method names
>> you like to use.
>
> Weijun Wang has updated the pull request incrementally with
On Sat, 26 Jun 2021 23:55:46 GMT, Weijun Wang wrote:
>> src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java
>> line 53:
>>
>>> 51: private static final long CURRENT_PID =
>>> AccessController.doPrivileged(
>>> 52: (PrivilegedAction)
>>>
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
one more
12 matches
Mail list logo
