Re: [jdk17] RFR: 8269543: The warning for System::setSecurityManager should only appear once for each caller [v2]

2021-07-01 Thread Lance Andersen
On Wed, 30 Jun 2021 15:45:25 GMT, Weijun Wang wrote: >> Add a cache to record which sources have called `System::setSecurityManager` >> and only print out warning lines once for each. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8268764: Use Long.hashCode() instead of int-cast where applicable [v3]

2021-07-01 Thread Сергей Цыпанов
On Thu, 1 Jul 2021 10:38:24 GMT, Сергей Цыпанов wrote: >> In some JDK classes there's still the following hashCode() implementation: >> >> long objNum; >> >> public int hashCode() { >> return (int) objNum; >> } >> >> This outdated expression should be replaced with Long.hashCode(long) as

Re: RFR: 8268764: Use Long.hashCode() instead of int-cast where applicable [v4]

2021-07-01 Thread Сергей Цыпанов
> In some JDK classes there's still the following hashCode() implementation: > > long objNum; > > public int hashCode() { > return (int) objNum; > } > > This outdated expression should be replaced with Long.hashCode(long) as it > > - uses all bits of the original value, does not discard any

Re: RFR: 8268764: Use Long.hashCode() instead of int-cast where applicable [v3]

2021-07-01 Thread Kevin Walls
On Thu, 1 Jul 2021 10:38:24 GMT, Сергей Цыпанов wrote: >> In some JDK classes there's still the following hashCode() implementation: >> >> long objNum; >> >> public int hashCode() { >> return (int) objNum; >> } >> >> This outdated expression should be replaced with Long.hashCode(long) as

Re: RFR: 8268764: Use Long.hashCode() instead of int-cast where applicable [v3]

2021-07-01 Thread Сергей Цыпанов
> In some JDK classes there's still the following hashCode() implementation: > > long objNum; > > public int hashCode() { > return (int) objNum; > } > > This outdated expression should be replaced with Long.hashCode(long) as it > > - uses all bits of the original value, does not discard any

Re: RFR: 8268764: Use Long.hashCode() instead of int-cast where applicable [v2]

2021-07-01 Thread Сергей Цыпанов
On Wed, 30 Jun 2021 11:49:51 GMT, Сергей Цыпанов wrote: >> In some JDK classes there's still the following hashCode() implementation: >> >> long objNum; >> >> public int hashCode() { >> return (int) objNum; >> } >> >> This outdated expression should be replaced with Long.hashCode(long) as