Re: RFR: 8270317: Large Allocation in CipherSuite [v2]

2021-07-21 Thread Xue-Lei Andrew Fan
On Wed, 21 Jul 2021 23:58:15 GMT, Clive Verghese wrote: >> ### Benchmark results >> >> I have benchmarked 3 cases. >> >> 1. The current situation. >> >> Benchmark >> (cipherSuite) Mode CntScore Error Units >>

Re: JEP411: Missing use-case: Security Manager and Java Scripting (JSR 223)

2021-07-21 Thread Peter Firmstone
JEP 411 is quite a conundrum for downstream developers that depend on SM. SecurityManager has its problems, but it's the only authorization layer we have. If I had a complaint about SM, it's the implementation of: 1. SocketPermission doesn't allow netmask wild cards. 2. Thread inherited

Integrated: Merge jdk17

2021-07-21 Thread Jesper Wilhelmsson
On Wed, 21 Jul 2021 23:52:53 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: c36755de Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/c36755dedf1a0d7ce0aeadd401e0c70ff84185e7 Stats: 517

Re: RFR: Merge jdk17 [v2]

2021-07-21 Thread Jesper Wilhelmsson
> Forwardport JDK 17 -> JDK 18 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 282 commits: - Merge - 8271015: Split cds/SharedBaseAddress.java test into smaller parts Reviewed-by: ccheung, minqi -

Re: RFR: 8270317: Large Allocation in CipherSuite

2021-07-21 Thread Clive Verghese
On Thu, 22 Jul 2021 00:11:56 GMT, Xue-Lei Andrew Fan wrote: >> I am currently looking into the JFR profiles to identify why there is a >> difference in benchmarks with regards the different cipher suits in the >> current version vs the arraylist. > I guess the garbage collection plays a role

Re: RFR: 8270317: Large Allocation in CipherSuite

2021-07-21 Thread Xue-Lei Andrew Fan
On Wed, 21 Jul 2021 23:51:17 GMT, Clive Verghese wrote: > Updated Benchmarks in Throughput mode Thank you very much for the update. > I am currently looking into the JFR profiles to identify why there is a > difference in benchmarks with regards the different cipher suits in the > current

RFR: Merge jdk17

2021-07-21 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8266347: assert(Dependencies::is_concrete_root_method(fm, ctxk) == Dependencies::is_concrete_method(m, ctxk)) failed: mismatch - 8264066: Enhance compiler validation - 8265201: JarFile.getInputStream not validating

Re: RFR: 8270317: Large Allocation in CipherSuite [v2]

2021-07-21 Thread Clive Verghese
On Thu, 15 Jul 2021 17:51:58 GMT, Clive Verghese wrote: >> Right. But calling `containsKey` and then `get` results in two hash map >> lookups. If we cache the result of `get`, we only need one lookup, which >> should be a tiny bit faster. See https://stackoverflow.com/q/14601016 > > I feel

Re: RFR: 8270317: Large Allocation in CipherSuite [v2]

2021-07-21 Thread Clive Verghese
On Fri, 16 Jul 2021 04:29:51 GMT, Michael Bien wrote: >> src/java.base/share/classes/sun/security/ssl/CipherSuite.java line 865: >> >>> 863: maps_name.put(cs.name, cs); >>> 864: for (String alias : cs.aliases) { >>> 865: maps_name.put(alias, cs); >> >>

Re: RFR: 8270317: Large Allocation in CipherSuite

2021-07-21 Thread Clive Verghese
On Wed, 14 Jul 2021 17:06:02 GMT, Clive Verghese wrote: > ### Benchmark results > > I have benchmarked 3 cases. > > 1. The current situation. > > Benchmark > (cipherSuite) Mode CntScore Error Units >

Re: RFR: 8270317: Large Allocation in CipherSuite [v2]

2021-07-21 Thread Clive Verghese
> ### Benchmark results > > I have benchmarked 3 cases. > > 1. The current situation. > > Benchmark > (cipherSuite) Mode CntScore Error Units > CipherSuiteBench.benchmarkCipherSuite > TLS_AES_256_GCM_SHA384

Re: JEP411: Missing use-case: Security Manager and Java Scripting (JSR 223)

2021-07-21 Thread Sean Mullan
Hi, I am not an expert in JSR 223. However, some JSR 223 implementations include a mechanism for restricting access to Java classes, for example Nashorn [1] and Rhino [2], which might be sufficient for your needs. (Note, Nashorn was deprecated and removed from JDK 15 [3]). I think most of

JEP411: Missing use-case: Security Manager and Java Scripting (JSR 223)

2021-07-21 Thread Alexey Shponarsky
Hello, At Jelastic PaaS, we are using SecurityManager within Java Scripting (JSR 223). Specifically, Java Scripting allows us and our customers to easily extend the core platform functionality with custom logic. The developers can execute their custom scriptlets inside a Java Scripting runtime

Re: A few updates to JEP 411: Deprecate the Security Manager for Removal

2021-07-21 Thread Peter Firmstone
Thanks Sean, Be nice if it can be implemented in a way that allows it to be decorated. Regards, Peter. On 19/07/2021 10:29 pm, Sean Mullan wrote: On 7/17/21 9:13 PM, Peter Firmstone wrote: My mistake copied wrong bug: Has there been any progress with the new Subject API?