RFR: 8272674: Logging missing keytab file in Krb5LoginModule

2021-08-18 Thread Weijun Wang
The "Key for the principal foo...@acme.com not available in /home/foobar/foobar.keytab" debug output does not contain enough information. The keytab file might be missing, or not readable, or does not contain the required key(s). Please note that this debug info is only visible when

Re: Logging missing keytab file in Krb5LoginModule

2021-08-18 Thread Wei-Jun Wang
See https://github.com/openjdk/jdk/pull/5176. The krb5 debug warning is also quite verbose and I think it’s not worth printing out the whole stack trace. Also, no existing debug message starts with “WARNING". They are just plain flat text. Thanks, Weijun > On Aug 18, 2021, at 5:34 PM,

Re: Logging missing keytab file in Krb5LoginModule

2021-08-18 Thread Horváth Péter Gergely
OK, I think we can agree on that. Please add the changes of KeyTab.java: it should be helpful in future releases. Thanks, Peter On Wed, Aug 18, 2021, 23:06 Wei-Jun Wang, wrote: > I think the new message in KeyTab.java is enough. The added lines in > Krb5LoginModule is a little too long with

Re: Logging missing keytab file in Krb5LoginModule

2021-08-18 Thread Wei-Jun Wang
I think the new message in KeyTab.java is enough. The added lines in Krb5LoginModule is a little too long with the try-catch structure. —Weijun > On Aug 18, 2021, at 1:50 PM, Horváth Péter Gergely > wrote: > > Hi Weijun, > > Many thanks for your response. I think that indeed it would make

Re: RFR: 8270344: Session resumption errors

2021-08-18 Thread djelinski
On Fri, 13 Aug 2021 14:00:45 GMT, Sean Coffey wrote: > Corner case where a session resumption can fail if the TLS server changes > supported protocol versions in relation to a cached SSLSession. This is > primarily an issue where the legacy TLS version is used in place of the newer >

Re: Logging missing keytab file in Krb5LoginModule

2021-08-18 Thread Horváth Péter Gergely
Hi Weijun, Many thanks for your response. I think that indeed it would make sense to log in KeyTab, since the FileNotFoundException there should even have the platform-specific reason message coming from the native layer. At the same time, I think it would make sense to emit a log message around

Re: RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Joe Darcy
On 8/18/2021 6:20 AM, Roger Riggs wrote: On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: C-style array declarations generate noisy warnings in IDEs, et.c. This patch cleans up all java.* packages. (Copyrights intentionally not updated due the triviality of most changes) 34

Re: RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Roger Riggs
On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: > C-style array declarations generate noisy warnings in IDEs, et.c. This patch > cleans up all java.* packages. > > (Copyrights intentionally not updated due the triviality of most changes) 34 Minutes from proposed to integrated! Its

Re: RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Claes Redestad
On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: > C-style array declarations generate noisy warnings in IDEs, et.c. This patch > cleans up all java.* packages. > > (Copyrights intentionally not updated due the triviality of most changes) Thanks for reviewing, Daniel and Alan!

Integrated: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Claes Redestad
On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: > C-style array declarations generate noisy warnings in IDEs, et.c. This patch > cleans up all java.* packages. > > (Copyrights intentionally not updated due the triviality of most changes) This pull request has now been integrated.

Re: RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Alan Bateman
On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: > C-style array declarations generate noisy warnings in IDEs, et.c. This patch > cleans up all java.* packages. > > (Copyrights intentionally not updated due the triviality of most changes) Marked as reviewed by alanb (Reviewer).

Re: RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Daniel Fuchs
On Wed, 18 Aug 2021 10:07:35 GMT, Claes Redestad wrote: > C-style array declarations generate noisy warnings in IDEs, et.c. This patch > cleans up all java.* packages. > > (Copyrights intentionally not updated due the triviality of most changes) Marked as reviewed by dfuchs (Reviewer).

RFR: 8272626: Avoid C-style array declarations in java.*

2021-08-18 Thread Claes Redestad
C-style array declarations generate noisy warnings in IDEs, et.c. This patch cleans up all java.* packages. (Copyrights intentionally not updated due the triviality of most changes) - Commit messages: - Avoid C-style array declarations in java packages Changes: