Re: RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v12]

2021-08-20 Thread Vladimir Kozlov
On Fri, 20 Aug 2021 22:43:55 GMT, Smita Kamath wrote: >> I would like to submit AES-GCM optimization for x86_64 architectures >> supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES >> and GHASH operations. >> Performance gain of ~1.5x - 2x for message sizes 8k and above.

Re: RFR: 8270380: Change the default value of the java.security.manager system property to disallow

2021-08-20 Thread Lance Andersen
On Fri, 20 Aug 2021 22:44:34 GMT, Weijun Wang wrote: > This change modifies the default value of the `java.security.manager` system > property from "allow" to "disallow". This means unless it's explicitly set to > "allow", any call to `System.setSecurityManager()` would throw an UOE. > > The `

RFR: 8270380: Change the default value of the java.security.manager system property to disallow

2021-08-20 Thread Weijun Wang
This change modifies the default value of the `java.security.manager` system property from "allow" to "disallow". This means unless it's explicitly set to "allow", any call to `System.setSecurityManager()` would throw an UOE. The `AllowSecurityManager.java` and `SecurityManagerWarnings.java` tes

Re: RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v12]

2021-08-20 Thread Smita Kamath
> I would like to submit AES-GCM optimization for x86_64 architectures > supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES > and GHASH operations. > Performance gain of ~1.5x - 2x for message sizes 8k and above. Smita Kamath has updated the pull request incrementally wit

Integrated: 8270344: Session resumption errors

2021-08-20 Thread Sean Coffey
On Fri, 13 Aug 2021 14:00:45 GMT, Sean Coffey wrote: > Corner case where a session resumption can fail if the TLS server changes > supported protocol versions in relation to a cached SSLSession. This is > primarily an issue where the legacy TLS version is used in place of the newer > "supporte

Re: RFR: 8270344: Session resumption errors [v5]

2021-08-20 Thread Xue-Lei Andrew Fan
On Fri, 20 Aug 2021 16:31:11 GMT, Sean Coffey wrote: >> src/java.base/share/classes/sun/security/ssl/ClientHello.java line 547: >> >>> 545: // handshake output stream, so that the output >>> records >>> 546: // (at the record layer) have the correct versi

Re: RFR: 8270344: Session resumption errors [v5]

2021-08-20 Thread Xue-Lei Andrew Fan
On Fri, 20 Aug 2021 16:34:51 GMT, Sean Coffey wrote: >> Corner case where a session resumption can fail if the TLS server changes >> supported protocol versions in relation to a cached SSLSession. This is >> primarily an issue where the legacy TLS version is used in place of the >> newer "supp

Re: RFR: 8270344: Session resumption errors [v4]

2021-08-20 Thread Sean Coffey
On Thu, 19 Aug 2021 19:51:36 GMT, Xue-Lei Andrew Fan wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> maxProtocolVersion refactoring > > test/jdk/sun/security/ssl/SSLSessionImpl/InvalidateSession.java line 60: > >>

Re: RFR: 8270344: Session resumption errors [v5]

2021-08-20 Thread Sean Coffey
On Thu, 19 Aug 2021 19:48:15 GMT, Xue-Lei Andrew Fan wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove redundant method and testcase cleanup > > src/java.base/share/classes/sun/security/ssl/ClientHello.java lin

Re: RFR: 8270344: Session resumption errors [v5]

2021-08-20 Thread Sean Coffey
> Corner case where a session resumption can fail if the TLS server changes > supported protocol versions in relation to a cached SSLSession. This is > primarily an issue where the legacy TLS version is used in place of the newer > "supported_versions" TLS extension. Sean Coffey has updated the

Re: RFR: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key

2021-08-20 Thread Alexey Bakhtin
On Fri, 23 Jul 2021 10:33:14 GMT, Alexey Bakhtin wrote: > Hello, > > Could you please review the small patch for the issue described in > JDK-8271199: Mutual TLS handshake fails signing client certificate with > custom sensitive PKCS11 key > > I suggest updating the RSAPSSSignature.isValid()