Re: RFR: 8273401: Remove JarIndex support in URLClassPath [v2]

2021-09-07 Thread wxiang
On Wed, 8 Sep 2021 06:22:38 GMT, wxiang wrote: >> There is a bug for URLClassPath.findResources with JarIndex. >> With some discussions about the bug, the current priority is to remove the >> JAR index support in URLClassPath, >> and don’t need to do anything to the jar tool in the short term,

Re: RFR: 8273401: Remove JarIndex support in URLClassPath [v2]

2021-09-07 Thread wxiang
On Tue, 7 Sep 2021 17:39:20 GMT, Sean Mullan wrote: >> src/java.base/share/classes/java/util/jar/JarVerifier.java line 147: >> >>> 145: >>> 146: if (uname.equals(JarFile.MANIFEST_NAME) || >>> 147: uname.equals(JarFile.INDEX_NAME)) { >> >> It would be use

Re: RFR: 8273401: Remove JarIndex support in URLClassPath [v2]

2021-09-07 Thread wxiang
On Tue, 7 Sep 2021 10:39:01 GMT, Lance Andersen wrote: >> src/java.base/share/classes/java/util/jar/JarFile.java line 220: >> >>> 218: * The index file name. >>> 219: */ >>> 220: public static final String INDEX_NAME = "META-INF/INDEX.LIST"; >> >> Adding this as a public field mea

Re: RFR: 8273401: Remove JarIndex support in URLClassPath [v2]

2021-09-07 Thread wxiang
> There is a bug for URLClassPath.findResources with JarIndex. > With some discussions about the bug, the current priority is to remove the > JAR index support in URLClassPath, > and don’t need to do anything to the jar tool in the short term, except just > to move JarIndex to the jdk.jartool mo

RFR: 8273297: AES/GCM non-AVX512+VAES CPUs suffer after 8267125

2021-09-07 Thread Smita Kamath
Performance dropped up to 10% for 1k data after 8267125 for CPUs that do not support the new intrinsic. Tests run were crypto.full.AESGCMBench and crypto.full.AESGCMByteBuffer from the jmh micro benchmarks. The problem is each instance of GHASH allocates 96 extra longs for the AVX512+VAES intri

Re: RFR: 8246797: A convenient method to read OPTIONAL element [v3]

2021-09-07 Thread Valerie Peng
On Tue, 24 Aug 2021 22:15:52 GMT, Weijun Wang wrote: >> This code change adds new methods to `DerInputStream` to easily and safely >> read optional fields in a ASN.1 DER-encoded value. It also adds several >> wrapping methods to `DerValue` to avoid unnecessary memory copying when >> calling by

Re: RFR: 8273401: Remove JarIndex support in URLClassPath

2021-09-07 Thread Sean Mullan
On Tue, 7 Sep 2021 07:12:29 GMT, Alan Bateman wrote: >> There is a bug for URLClassPath.findResources with JarIndex. >> With some discussions about the bug, the current priority is to remove the >> JAR index support in URLClassPath, >> and don’t need to do anything to the jar tool in the short

Re: RFR: 8273401: Remove JarIndex support in URLClassPath

2021-09-07 Thread Lance Andersen
On Tue, 7 Sep 2021 07:03:20 GMT, Alan Bateman wrote: >> There is a bug for URLClassPath.findResources with JarIndex. >> With some discussions about the bug, the current priority is to remove the >> JAR index support in URLClassPath, >> and don’t need to do anything to the jar tool in the short

Integrated: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped

2021-09-07 Thread Fernando Guallini
On Thu, 2 Sep 2021 13:33:30 GMT, Fernando Guallini wrote: > This trivial change fixes the case 2 in test > sun/security/pkcs11/rsa/TestP11KeyFactoryGetRSAKeySpec, the method > testKeySpec is expecting a class object of type KeySpec as second argument in > order to be reusable for multiple tes

Re: RFR: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped

2021-09-07 Thread Rajan Halade
On Thu, 2 Sep 2021 13:33:30 GMT, Fernando Guallini wrote: > This trivial change fixes the case 2 in test > sun/security/pkcs11/rsa/TestP11KeyFactoryGetRSAKeySpec, the method > testKeySpec is expecting a class object of type KeySpec as second argument in > order to be reusable for multiple tes

Re: RFR: 8273401: Remove JarIndex support in URLClassPath

2021-09-07 Thread Alan Bateman
On Tue, 7 Sep 2021 03:34:27 GMT, wxiang wrote: > There is a bug for URLClassPath.findResources with JarIndex. > With some discussions about the bug, the current priority is to remove the > JAR index support in URLClassPath, > and don’t need to do anything to the jar tool in the short term, exc