Re: RFR: 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher

2021-09-20 Thread Thejasvi Voniadka
On Mon, 20 Sep 2021 12:04:50 GMT, Weijun Wang wrote: >> The test "sun/security/pkcs12/KeytoolOpensslInteropTest.java" performs >> interoperability checks between JDK and openssl with respect to certain >> keystore operations. The test requires a suitable version of openssl to be >> available o

Re: RFR: 8269039: Disable SHA-1 Signed JARs [v2]

2021-09-20 Thread Weijun Wang
On Mon, 20 Sep 2021 17:27:42 GMT, Sean Mullan wrote: >> src/java.base/share/classes/sun/security/provider/certpath/PKIX.java line >> 228: >> >>> 226: } >>> 227: return timestampDate; >>> 228: } >> >> Can we also add some words to the `date()` method? Something w

Re: RFR: 8273297: AES/GCM non-AVX512+VAES CPUs suffer after 8267125

2021-09-20 Thread Smita Kamath
On Tue, 14 Sep 2021 13:31:19 GMT, Andrew Haley wrote: >> Performance dropped up to 10% for 1k data after 8267125 for CPUs that do not >> support the new intrinsic. Tests run were crypto.full.AESGCMBench and >> crypto.full.AESGCMByteBuffer from the jmh micro benchmarks. >> >> The problem is eac

Re: RFR: 8269039: Disable SHA-1 Signed JARs [v2]

2021-09-20 Thread Sean Mullan
On Mon, 20 Sep 2021 14:32:01 GMT, Weijun Wang wrote: >> Sean Mullan has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Add some more comments in the PKIX date() and timestamp() methods. >>Remove extra newline from debugging output. >

Re: RFR: 8269039: Disable SHA-1 Signed JARs [v5]

2021-09-20 Thread Sean Mullan
> This change will disable JARs signed with algorithms using SHA-1 by default, > and treat them as unsigned. This applies to the algorithms used to digest, > sign, and optionally timestamp the JAR. It also applies to the signature and > digest algorithms of the certificates in the certificate ch

Re: RFR: 8269039: Disable SHA-1 Signed JARs [v2]

2021-09-20 Thread Sean Mullan
On Mon, 20 Sep 2021 14:28:11 GMT, Weijun Wang wrote: >> Sean Mullan has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Add some more comments in the PKIX date() and timestamp() methods. >>Remove extra newline from debugging output. >

Re: RFR: 8273297: AES/GCM non-AVX512+VAES CPUs suffer after 8267125 [v2]

2021-09-20 Thread Anthony Scarpino
On Mon, 20 Sep 2021 05:16:16 GMT, Smita Kamath wrote: >> Performance dropped up to 10% for 1k data after 8267125 for CPUs that do not >> support the new intrinsic. Tests run were crypto.full.AESGCMBench and >> crypto.full.AESGCMByteBuffer from the jmh micro benchmarks. >> >> The problem is eac

Re: RFR: 8269039: Disable SHA-1 Signed JARs [v2]

2021-09-20 Thread Weijun Wang
On Fri, 17 Sep 2021 14:29:34 GMT, Sean Mullan wrote: >> This change will disable JARs signed with algorithms using SHA-1 by default, >> and treat them as unsigned. This applies to the algorithms used to digest, >> sign, and optionally timestamp the JAR. It also applies to the signature and >>

Re: RFR: 8269039: Disable SHA-1 Signed JARs [v4]

2021-09-20 Thread Sean Mullan
> This change will disable JARs signed with algorithms using SHA-1 by default, > and treat them as unsigned. This applies to the algorithms used to digest, > sign, and optionally timestamp the JAR. It also applies to the signature and > digest algorithms of the certificates in the certificate ch

Re: RFR: 8269039: Disable SHA-1 Signed JARs [v3]

2021-09-20 Thread Sean Mullan
> This change will disable JARs signed with algorithms using SHA-1 by default, > and treat them as unsigned. This applies to the algorithms used to digest, > sign, and optionally timestamp the JAR. It also applies to the signature and > digest algorithms of the certificates in the certificate ch

Re: RFR: 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher

2021-09-20 Thread Weijun Wang
On Wed, 15 Sep 2021 08:01:30 GMT, Thejasvi Voniadka wrote: > The test "sun/security/pkcs12/KeytoolOpensslInteropTest.java" performs > interoperability checks between JDK and openssl with respect to certain > keystore operations. The test requires a suitable version of openssl to be > availabl