On Wed, 22 Sep 2021 10:36:37 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8273894?
>
> Given the nature of the code in `ReferralsCache`, I haven't been able to add
> a new jtreg test cas
On Wed, 22 Sep 2021 10:36:37 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8273894?
>
> Given the nature of the code in `ReferralsCache`, I haven't been able to add
> a new jtreg test cas
> Performance dropped up to 10% for 1k data after 8267125 for CPUs that do not
> support the new intrinsic. Tests run were crypto.full.AESGCMBench and
> crypto.full.AESGCMByteBuffer from the jmh micro benchmarks.
>
> The problem is each instance of GHASH allocates 96 extra longs for the
> AVX51
On Wed, 22 Sep 2021 15:38:33 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing "the"
>
> (Spotted by Brian Burkhalter.)
Marked as revie
mustafaka...@gmail.com
On Wed, 22 Sep 2021 15:38:33 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing "the"
>
> (Spotted by Brian Burkhalter.)
Marked as revie
> 8274075: Fix miscellaneous typos in java.base
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
Add missing "the"
(Spotted by Brian Burkhalter.)
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5610/files
On Wed, 22 Sep 2021 15:35:54 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing "the"
>
> (Spotted by Brian Burkhalter.)
Marked as revie
On Wed, 22 Sep 2021 10:36:37 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8273894?
>
> Given the nature of the code in `ReferralsCache`, I haven't been able to add
> a new jtreg test cas
On Wed, 22 Sep 2021 13:01:34 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Fix "non-white space"
>
>JDK predominantly uses "non-whitespace"
> 8274075: Fix miscellaneous typos in java.base
Pavel Rappo has updated the pull request incrementally with two additional
commits since the last revision:
- Fix "non-white space"
JDK predominantly uses "non-whitespace". There's only one more use of
"non-white space", in com/sun/tools/j
On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote:
>> 8274075: Fix miscellaneous typos in java.base
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Tweak wording for Throwable constructor parameters
Please re-review this
On Wed, 22 Sep 2021 10:24:12 GMT, Pavel Rappo wrote:
>> Note that we don't throw the "wrapped exception" we throw the exception that
>> wraps it. The "wrapped exception" is the original cause. The wording as
>> presented now is correct in that regard. You could also say "Throwing a
>> wrapper
On Wed, 22 Sep 2021 10:36:37 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8273894?
>
> Given the nature of the code in `ReferralsCache`, I haven't been able to add
> a new jtreg test cas
Can I please get a review for this change which proposes to fix the issue noted
in https://bugs.openjdk.java.net/browse/JDK-8273894?
Given the nature of the code in `ReferralsCache`, I haven't been able to add a
new jtreg test case to reproduce the issue and verify this fix. Just to be sure
tha
On Tue, 21 Sep 2021 22:00:29 GMT, David Holmes wrote:
>> Instead of "common case where a wrapped exception is thrown from same
>> method" could one write "common case where an enclosing exception is thrown
>> from the same method"?
>
> Note that we don't throw the "wrapped exception" we throw t
16 matches
Mail list logo
