Re: RFR: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC

2021-09-23 Thread Alexey Bakhtin
On Thu, 23 Sep 2021 19:31:32 GMT, Weijun Wang wrote: >> The code change handles KDC_ERR_SVC_UNAVAILABLE error code (29) received >> from KDC and resends the initial request to the next KDC in the list. It >> aligns error code handling with the MIT Kerberos implementation. >> sun/security/krb5 t

Re: RFR: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC [v2]

2021-09-23 Thread Alexey Bakhtin
> The code change handles KDC_ERR_SVC_UNAVAILABLE error code (29) received from > KDC and resends the initial request to the next KDC in the list. It aligns > error code handling with the MIT Kerberos implementation. > sun/security/krb5 tests passed Alexey Bakhtin has updated the pull request in

Re: RFR: 8273670: Remove weak etypes from default krb5 etype list

2021-09-23 Thread Valerie Peng
On Thu, 23 Sep 2021 14:32:01 GMT, Weijun Wang wrote: > This code change removes weak etypes from the default list so it's safer to > enable one of them. See the corresponding CSR at > https://bugs.openjdk.java.net/browse/JDK-8274207 for more explanation. BTW, > please review the CSR as well.

Re: RFR: 8273297: AES/GCM non-AVX512+VAES CPUs suffer after 8267125 [v5]

2021-09-23 Thread Sandhya Viswanathan
On Wed, 22 Sep 2021 22:48:32 GMT, Smita Kamath wrote: >> Performance dropped up to 10% for 1k data after 8267125 for CPUs that do not >> support the new intrinsic. Tests run were crypto.full.AESGCMBench and >> crypto.full.AESGCMByteBuffer from the jmh micro benchmarks. >> >> The problem is eac

Re: RFR: 8273297: AES/GCM non-AVX512+VAES CPUs suffer after 8267125 [v2]

2021-09-23 Thread Smita Kamath
On Mon, 20 Sep 2021 16:44:58 GMT, Anthony Scarpino wrote: >> Smita Kamath has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added a wrapper around aes-gcm intrinsic, changed data size in TestAESMain >> and added a new constant for htbl e

RFR: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base

2021-09-23 Thread Andrey Turbanov
There are few places in code where manual `for` loop is used with Iterator to iterate over Collection. Instead of manual `for` cycles it's preferred to use enhanced-for cycle instead: it's less verbose, makes code easier to read and it's less error-prone. Sometimes we even don't need cycle at all

Re: RFR: 8273299: Unnecessary Vector usage in java.security.jgss [v2]

2021-09-23 Thread Andrey Turbanov
> Usage of thread-safe collection Vector is unnecessary. It's recommended to > use ArrayList if a thread-safe implementation is not needed. Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8273299: Unnecessary Vector usage in java.

Re: RFR: 8273299: Unnecessary Vector usage in java.security.jgss [v2]

2021-09-23 Thread Andrey Turbanov
On Thu, 26 Aug 2021 20:37:59 GMT, Andrey Turbanov wrote: >> src/java.security.jgss/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java >> line 574: >> >>> 572: v.add(st.nextToken()); >>> 573: } >>> 574: final String[] command = new String[v.siz

Integrated: 8273261: Replace 'while' cycles with iterator with enhanced-for in java.base

2021-09-23 Thread Andrey Turbanov
On Wed, 1 Sep 2021 07:37:53 GMT, Andrey Turbanov wrote: > There are few places in code where manual while loop is used with Iterator to > iterate over Collection. > Instead of manual while cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read a

Re: RFR: 8273261: Replace 'while' cycles with iterator with enhanced-for in java.base

2021-09-23 Thread Andrey Turbanov
On Wed, 1 Sep 2021 07:37:53 GMT, Andrey Turbanov wrote: > There are few places in code where manual while loop is used with Iterator to > iterate over Collection. > Instead of manual while cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read a

Re: RFR: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC

2021-09-23 Thread Weijun Wang
On Thu, 23 Sep 2021 16:52:07 GMT, Alexey Bakhtin wrote: > The code change handles KDC_ERR_SVC_UNAVAILABLE error code (29) received from > KDC and resends the initial request to the next KDC in the list. It aligns > error code handling with the MIT Kerberos implementation. > sun/security/krb5 te

Re: RFR: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC

2021-09-23 Thread Weijun Wang
On Thu, 23 Sep 2021 16:52:07 GMT, Alexey Bakhtin wrote: > The code change handles KDC_ERR_SVC_UNAVAILABLE error code (29) received from > KDC and resends the initial request to the next KDC in the list. It aligns > error code handling with the MIT Kerberos implementation. > sun/security/krb5 te

RFR: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC

2021-09-23 Thread Alexey Bakhtin
The code change handles KDC_ERR_SVC_UNAVAILABLE error code (29) received from KDC and resends the initial request to the next KDC in the list. It aligns error code handling with the MIT Kerberos implementation. sun/security/krb5 tests passed - Commit messages: - 8274205: Handle KDC

RFR: 8273670: Remove weak etypes from default krb5 etype list

2021-09-23 Thread Weijun Wang
This code change removes weak etypes from the default list so it's safer to enable one of them. See the corresponding CSR at https://bugs.openjdk.java.net/browse/JDK-8274207 for more explanation. BTW, please review the CSR as well. - Commit messages: - 8273670: Remove weak etypes

Integrated: 8274075: Fix miscellaneous typos in java.base

2021-09-23 Thread Pavel Rappo
On Tue, 21 Sep 2021 12:26:25 GMT, Pavel Rappo wrote: > 8274075: Fix miscellaneous typos in java.base This pull request has now been integrated. Changeset: 87998565 Author:Pavel Rappo URL: https://git.openjdk.java.net/jdk/commit/8799856528f5804b616b734caed3fc4ba9811bfa Stats: 26