Re: RFR: 8273670: Remove weak etypes from default krb5 etype list [v2]

2021-09-24 Thread Weijun Wang
> This code change removes weak etypes from the default list so it's safer to > enable one of them. See the corresponding CSR at > https://bugs.openjdk.java.net/browse/JDK-8274207 for more explanation. BTW, > please review the CSR as well. Weijun Wang has updated the pull request incrementally

Re: RFR: 8273670: Remove weak etypes from default krb5 etype list

2021-09-24 Thread Weijun Wang
On Fri, 24 Sep 2021 22:06:27 GMT, Valerie Peng wrote: >> This is because MIT krb5 treats DES as weak and RC4 as deprecated. In Java, >> we treat both as weak after JDK-8139348 (the title is "Deprecate 3DES and >> RC4 in Kerberos" but this "deprecate" is not the same as the one in MIT >> krb5).

Re: RFR: 8273670: Remove weak etypes from default krb5 etype list

2021-09-24 Thread Weijun Wang
On Fri, 24 Sep 2021 22:01:26 GMT, Valerie Peng wrote: >> This code change removes weak etypes from the default list so it's safer to >> enable one of them. See the corresponding CSR at >> https://bugs.openjdk.java.net/browse/JDK-8274207 for more explanation. BTW, >> please review the CSR as we

Re: RFR: 8273670: Remove weak etypes from default krb5 etype list

2021-09-24 Thread Weijun Wang
On Fri, 24 Sep 2021 21:59:04 GMT, Valerie Peng wrote: >> This code change removes weak etypes from the default list so it's safer to >> enable one of them. See the corresponding CSR at >> https://bugs.openjdk.java.net/browse/JDK-8274207 for more explanation. BTW, >> please review the CSR as we

Re: RFR: 8273670: Remove weak etypes from default krb5 etype list

2021-09-24 Thread Weijun Wang
On Fri, 24 Sep 2021 21:55:44 GMT, Valerie Peng wrote: >> This code change removes weak etypes from the default list so it's safer to >> enable one of them. See the corresponding CSR at >> https://bugs.openjdk.java.net/browse/JDK-8274207 for more explanation. BTW, >> please review the CSR as we

Re: RFR: 8273670: Remove weak etypes from default krb5 etype list

2021-09-24 Thread Valerie Peng
On Thu, 23 Sep 2021 14:32:01 GMT, Weijun Wang wrote: > This code change removes weak etypes from the default list so it's safer to > enable one of them. See the corresponding CSR at > https://bugs.openjdk.java.net/browse/JDK-8274207 for more explanation. BTW, > please review the CSR as well.

Re: RFR: 8273670: Remove weak etypes from default krb5 etype list

2021-09-24 Thread Valerie Peng
On Thu, 23 Sep 2021 14:32:01 GMT, Weijun Wang wrote: > This code change removes weak etypes from the default list so it's safer to > enable one of them. See the corresponding CSR at > https://bugs.openjdk.java.net/browse/JDK-8274207 for more explanation. BTW, > please review the CSR as well.

Re: RFR: 8273670: Remove weak etypes from default krb5 etype list

2021-09-24 Thread Valerie Peng
On Fri, 24 Sep 2021 21:38:39 GMT, Weijun Wang wrote: >> src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/EType.java >> line 101: >> >>> 99: if (allowWeakCrypto) { >>> 100: result[num++] = EncryptedData.ETYPE_DES3_CBC_HMAC_SHA1_KD; >>> 101: r

Re: RFR: 8273670: Remove weak etypes from default krb5 etype list

2021-09-24 Thread Valerie Peng
On Thu, 23 Sep 2021 14:32:01 GMT, Weijun Wang wrote: > This code change removes weak etypes from the default list so it's safer to > enable one of them. See the corresponding CSR at > https://bugs.openjdk.java.net/browse/JDK-8274207 for more explanation. BTW, > please review the CSR as well.

Re: RFR: 8273670: Remove weak etypes from default krb5 etype list

2021-09-24 Thread Weijun Wang
On Fri, 24 Sep 2021 19:33:12 GMT, Sean Mullan wrote: >> This code change removes weak etypes from the default list so it's safer to >> enable one of them. See the corresponding CSR at >> https://bugs.openjdk.java.net/browse/JDK-8274207 for more explanation. BTW, >> please review the CSR as wel

Re: RFR: 8273670: Remove weak etypes from default krb5 etype list

2021-09-24 Thread Weijun Wang
On Fri, 24 Sep 2021 19:49:14 GMT, Sean Mullan wrote: >> This code change removes weak etypes from the default list so it's safer to >> enable one of them. See the corresponding CSR at >> https://bugs.openjdk.java.net/browse/JDK-8274207 for more explanation. BTW, >> please review the CSR as wel

Re: RFR: 8273670: Remove weak etypes from default krb5 etype list

2021-09-24 Thread Sean Mullan
On Thu, 23 Sep 2021 14:32:01 GMT, Weijun Wang wrote: > This code change removes weak etypes from the default list so it's safer to > enable one of them. See the corresponding CSR at > https://bugs.openjdk.java.net/browse/JDK-8274207 for more explanation. BTW, > please review the CSR as well.

Integrated: 8273297: AES/GCM non-AVX512+VAES CPUs suffer after 8267125

2021-09-24 Thread Smita Kamath
On Tue, 7 Sep 2021 22:31:30 GMT, Smita Kamath wrote: > Performance dropped up to 10% for 1k data after 8267125 for CPUs that do not > support the new intrinsic. Tests run were crypto.full.AESGCMBench and > crypto.full.AESGCMByteBuffer from the jmh micro benchmarks. > > The problem is each inst

Re: RFR: 8273297: AES/GCM non-AVX512+VAES CPUs suffer after 8267125 [v5]

2021-09-24 Thread Andrew Haley
On Wed, 22 Sep 2021 22:48:32 GMT, Smita Kamath wrote: >> Performance dropped up to 10% for 1k data after 8267125 for CPUs that do not >> support the new intrinsic. Tests run were crypto.full.AESGCMBench and >> crypto.full.AESGCMByteBuffer from the jmh micro benchmarks. >> >> The problem is eac

Integrated: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base

2021-09-24 Thread Andrey Turbanov
On Thu, 23 Sep 2021 20:42:48 GMT, Andrey Turbanov wrote: > There are few places in code where manual `for` loop is used with Iterator to > iterate over Collection. > Instead of manual `for` cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read

Re: RFR: 8273299: Unnecessary Vector usage in java.security.jgss [v2]

2021-09-24 Thread Weijun Wang
On Thu, 23 Sep 2021 20:31:16 GMT, Andrey Turbanov wrote: >> Usage of thread-safe collection Vector is unnecessary. It's recommended to >> use ArrayList if a thread-safe implementation is not needed. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit sin

Re: RFR: 8273297: AES/GCM non-AVX512+VAES CPUs suffer after 8267125 [v5]

2021-09-24 Thread Anthony Scarpino
On Wed, 22 Sep 2021 22:48:32 GMT, Smita Kamath wrote: >> Performance dropped up to 10% for 1k data after 8267125 for CPUs that do not >> support the new intrinsic. Tests run were crypto.full.AESGCMBench and >> crypto.full.AESGCMByteBuffer from the jmh micro benchmarks. >> >> The problem is eac

Re: RFR: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base

2021-09-24 Thread Daniel Fuchs
On Thu, 23 Sep 2021 20:42:48 GMT, Andrey Turbanov wrote: > There are few places in code where manual `for` loop is used with Iterator to > iterate over Collection. > Instead of manual `for` cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read

Re: RFR: 8273299: Unnecessary Vector usage in java.security.jgss [v2]

2021-09-24 Thread Weijun Wang
On Thu, 23 Sep 2021 20:31:16 GMT, Andrey Turbanov wrote: >> Usage of thread-safe collection Vector is unnecessary. It's recommended to >> use ArrayList if a thread-safe implementation is not needed. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit sin

Re: RFR: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base

2021-09-24 Thread Weijun Wang
On Thu, 23 Sep 2021 20:42:48 GMT, Andrey Turbanov wrote: > There are few places in code where manual `for` loop is used with Iterator to > iterate over Collection. > Instead of manual `for` cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read

Re: RFR: 8274143 Disable "invalid entry for security.provider.X" error message in log file when security.provider.X is empty

2021-09-24 Thread Weijun Wang
On Fri, 24 Sep 2021 08:01:07 GMT, Daniel JeliƄski wrote: > The default list of providers defined in java.security file can be overridden > with a custom file, declared with > `-Djava.security.properties=/path/to/custom.security` command line parameter. > If the new list of providers is shorter

Integrated: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC

2021-09-24 Thread Alexey Bakhtin
On Thu, 23 Sep 2021 16:52:07 GMT, Alexey Bakhtin wrote: > The code change handles KDC_ERR_SVC_UNAVAILABLE error code (29) received from > KDC and resends the initial request to the next KDC in the list. It aligns > error code handling with the MIT Kerberos implementation. > sun/security/krb5 te

Re: RFR: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC [v2]

2021-09-24 Thread Weijun Wang
On Fri, 24 Sep 2021 05:33:46 GMT, Alexey Bakhtin wrote: >> The code change handles KDC_ERR_SVC_UNAVAILABLE error code (29) received >> from KDC and resends the initial request to the next KDC in the list. It >> aligns error code handling with the MIT Kerberos implementation. >> sun/security/krb

Re: RFR: 8274237: Replace 'for' cycles with iterator with enhanced-for in java.base

2021-09-24 Thread Daniel Fuchs
On Thu, 23 Sep 2021 20:42:48 GMT, Andrey Turbanov wrote: > There are few places in code where manual `for` loop is used with Iterator to > iterate over Collection. > Instead of manual `for` cycles it's preferred to use enhanced-for cycle > instead: it's less verbose, makes code easier to read

RFR: 8274143 Disable "invalid entry for security.provider.X" error message in log file when security.provider.X is empty

2021-09-24 Thread djelinski
The default list of providers defined in java.security file can be overridden with a custom file, declared with `-Djava.security.properties=/path/to/custom.security` command line parameter. If the new list of providers is shorter than the original one, it is necessary to add an empty entry to te