Re: Understanding elliptic curve spec limitations

2021-09-27 Thread Anthony Scarpino
On 9/27/21 2:22 PM, David Blevins wrote: I've been putting a significant amount of work into compiling a large set of elliptic curve parameters/names/oids for an open source library and a related closed source security product we have. We need to be able to support any of the curves that

Understanding elliptic curve spec limitations

2021-09-27 Thread David Blevins
I've been putting a significant amount of work into compiling a large set of elliptic curve parameters/names/oids for an open source library and a related closed source security product we have. We need to be able to support any of the curves that OpenSSL/LibreSSL support. The trick is this

RFR: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs

2021-09-27 Thread Joe Darcy
Follow-up change to JDK-8231262, augmentations to javac's Xlint:serial checking are out for review (#5709) and various security libraries would need some changes to pass under the expanded checks. The changes are to suppress warnings where non-transient fields in serializable types are not

Re: RFR: 8273670: Remove weak etypes from default krb5 etype list [v3]

2021-09-27 Thread Valerie Peng
On Mon, 27 Sep 2021 01:28:29 GMT, Weijun Wang wrote: >> This code change removes weak etypes from the default list so it's safer to >> enable one of them. See the corresponding CSR at >> https://bugs.openjdk.java.net/browse/JDK-8274207 for more explanation. BTW, >> please review the CSR as

Re: RFR: 8274333: Redundant null comparison after Pattern.split

2021-09-27 Thread Sean Mullan
On Sun, 26 Sep 2021 15:10:52 GMT, Andrey Turbanov wrote: > In couple of classes, result part of arrays of Pattern.split is compared with > `null`. Pattern.split (and hence String.split) never returns `null` in array > elements. Such comparisons are redundant. The AlgorithmDecomposer change

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

2021-09-27 Thread Erik Joelsson
On Mon, 27 Sep 2021 01:00:18 GMT, Joe Darcy wrote: > This is an initial PR for expanded lint warnings done under two bugs: > > 8202056: Expand serial warning to check for bad overloads of serial-related > methods and ineffectual fields > 8160675: Issue lint warning for non-serializable

RFR: 8274330: Incorrect encoding of the DistributionPointName object in IssuingDistributionPointExtension

2021-09-27 Thread Weijun Wang
`DistributionPointName` in `IssuingDistributionPointExtension` is a CHOICE and should not be encoded as IMPLICIT. Please note that the parsing side (at

RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

2021-09-27 Thread Joe Darcy
This is an initial PR for expanded lint warnings done under two bugs: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields 8160675: Issue lint warning for non-serializable non-transient instance fields in serializable type to get feedback

RFR: 8274333: Redundant null comparison after Pattern.split

2021-09-27 Thread Andrey Turbanov
In couple of classes, result part of arrays of Pattern.split is compared with `null`. Pattern.split (and hence String.split) never returns `null` in array elements. Such comparisons are redundant. - Commit messages: - [PATCH] Remove redundant 'null' comparison after Pattern.split