Re: RFR: 8274528: Add comment to explain an HKDF optimization in SSLSecretDerivation

2021-09-29 Thread Jamil Nimeh
On Thu, 30 Sep 2021 01:22:56 GMT, Bradford Wetmore wrote: > See comment, + a couple minor cleanups. src/java.base/share/classes/sun/security/ssl/SSLSecretDerivation.java line 153: > 151: private final byte[] label; > 152: > 153: SecretSchedule(String label) { Why are we

RFR: 8274528: Add comment to explain an HKDF optimization in SSLSecretDerivation

2021-09-29 Thread Bradford Wetmore
See comment, + a couple minor cleanups. - Commit messages: - Minor cleanup. Changes: https://git.openjdk.java.net/jdk/pull/5765/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5765=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274528 Stats: 13 lines in 1 file

Re: RFR: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging

2021-09-29 Thread Sergey Bylokhov
On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote: > At the time Java supported applets and webstart, a special mechanism for > launching various applications in one JVM was used to reduce memory usage and > each application was isolated from each other. > > This isolation was

Re: Verification of OCSP Responses signed with RSASSA-PSS fails with Java 11 LTS

2021-09-29 Thread Sean Mullan
Thank you for reporting this issue. As far as I can tell, it looks like the JDK OCSP implementation has not yet been enhanced to support RSASSA-PSS signatures. We will keep an eye out for the bug report you filed but I think it is still making its way through our system as I have not seen it

RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake

2021-09-29 Thread Alexey Bakhtin
Please review the patch for JDK-8274524 The fix just adds locks around InputStream read and skip operations to prevent concurrent read from socket. sun/security/ssl jtreg tests passed api/javax_net/ssl/SSLSocket/setUseClientMode jck test passed - Commit messages: - 8274524:

Re: RFR: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs [v2]

2021-09-29 Thread Joe Darcy
> Follow-up change to JDK-8231262, augmentations to javac's Xlint:serial > checking are out for review (#5709) and various security libraries would need > some changes to pass under the expanded checks. > > The changes are to suppress warnings where non-transient fields in > serializable types

Re: RFR: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs [v2]

2021-09-29 Thread Joe Darcy
On Wed, 29 Sep 2021 18:13:14 GMT, Joe Darcy wrote: >> Follow-up change to JDK-8231262, augmentations to javac's Xlint:serial >> checking are out for review (#5709) and various security libraries would >> need some changes to pass under the expanded checks. >> >> The changes are to suppress

Integrated: 8274050: Unnecessary Vector usage in javax.crypto

2021-09-29 Thread Andrey Turbanov
On Thu, 26 Aug 2021 06:19:49 GMT, Andrey Turbanov wrote: > In [JDK-8268873](https://bugs.openjdk.java.net/browse/JDK-8268873) I missed a > few places, where Vector could be replaced with ArrayList. > Usage of thread-safe collection `Vector` is unnecessary. It's recommended to > use

Re: RFR: 8274330: Incorrect encoding of the DistributionPointName object in IssuingDistributionPointExtension

2021-09-29 Thread Anthony Scarpino
On Sun, 26 Sep 2021 13:27:47 GMT, Weijun Wang wrote: > `DistributionPointName` in `IssuingDistributionPointExtension` is a CHOICE > and should not be encoded as IMPLICIT. > > Please note that the parsing side (at >

Integrated: 8274330: Incorrect encoding of the DistributionPointName object in IssuingDistributionPointExtension

2021-09-29 Thread Weijun Wang
On Sun, 26 Sep 2021 13:27:47 GMT, Weijun Wang wrote: > `DistributionPointName` in `IssuingDistributionPointExtension` is a CHOICE > and should not be encoded as IMPLICIT. > > Please note that the parsing side (at >

RFR: 8273026: Slow LoginContext.login() on multi threading application

2021-09-29 Thread Larry-N
This fix adds a cache of service provider classes to LoginContext (in particular, it's a cache of LoginModules classes). The approach helps to increase the performance of the LoginContext.login() method significantly, especially in a multi-threading environment. Service Loader is used for