On Wed, 2 Jun 2021 20:13:34 GMT, Maurizio Cimadamore
wrote:
>> This patch overhauls the library loading mechanism used by the Foreign
>> Linker API. We realized that, while handy, the *default* lookup abstraction
>> (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
>>
On Thu, Oct 7, 2021 at 12:15 AM Joe Darcy wrote:
> Curious. The JDK build is done with javac -Xlint:cast warning enabled
> (JDK-8032734) which is intended to catch issues like this. Perhaps IntelliJ
> is using a different (or sharper) analysis.
Yes, our analysis is written independently of Jav
On Thu, 9 Sep 2021 06:50:21 GMT, Andrey Turbanov
wrote:
> StringBuffer is a legacy synchronized class. There are more modern
> alternatives which perform better:
> 1. Plain String concatenation should be preferred
> 2. StringBuilder is a direct replacement to StringBuffer which generally have
On Thu, 7 Oct 2021 15:09:22 GMT, Sean Coffey wrote:
>> test/jdk/sun/security/tools/jarsigner/warnings/LowerCaseManifest.java line
>> 38:
>>
>>> 36: * @library /test/lib ../
>>> 37: * @build jdk.test.lib.util.JarUtils
>>> 38: * @run main LowerCaseManifest
>>
>> You don't need this line as th
On Wed, 6 Oct 2021 16:58:51 GMT, Sean Coffey wrote:
> Use correct manifest file name in the Manifest verifier checks.
> Also - extra null check
>
> The test doesn't reproduce the exact issue reported but should prevent future
> regressions in this area.
This pull request has now been integrat
On Thu, 7 Oct 2021 15:12:33 GMT, Sean Mullan wrote:
>> Looks like it's required if there's a @build directive
>
> Ok.
It might be necessary because there is already a `@build` there.
-
PR: https://git.openjdk.java.net/jdk/pull/5841
On Thu, 7 Oct 2021 14:57:53 GMT, Sean Mullan wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make variables final
>
> test/jdk/sun/security/tools/jarsigner/warnings/LowerCaseManifest.java line 38:
>
>> 36: * @libr
On Thu, 7 Oct 2021 14:21:27 GMT, Sean Coffey wrote:
>> src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java
>> line 66:
>>
>>> 64:
>>> 65: private String name = null;
>>> 66: private String manifestFileName;
>>
>> Make this final and add a comment that it will neve
On Thu, 7 Oct 2021 10:44:39 GMT, Sean Coffey wrote:
>> Use correct manifest file name in the Manifest verifier checks.
>> Also - extra null check
>>
>> The test doesn't reproduce the exact issue reported but should prevent
>> future regressions in this area.
>
> Sean Coffey has updated the pul
On Wed, 6 Oct 2021 17:54:15 GMT, Weijun Wang wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make variables final
>
> src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java line
> 66:
>
>> 64:
>
> This change implements a new service provider interface for host name and
> address resolution, so that java.net.InetAddress API can make use of
> resolvers other than the platform's built-in resolver.
>
> The following API classes are added to `java.net.spi` package to facilitate
> this:
> -
> Use correct manifest file name in the Manifest verifier checks.
> Also - extra null check
>
> The test doesn't reproduce the exact issue reported but should prevent future
> regressions in this area.
Sean Coffey has updated the pull request incrementally with one additional
commit since the
StringBuffer is a legacy synchronized class. There are more modern alternatives
which perform better:
1. Plain String concatenation should be preferred
2. StringBuilder is a direct replacement to StringBuffer which generally have
better performance
In [JDK-8264029](https://bugs.openjdk.java.net/
13 matches
Mail list logo
