Re: RFR: 8264849: Add KW and KWP support to PKCS11 provider [v2]

2021-10-11 Thread Anthony Scarpino
On Mon, 11 Oct 2021 23:32:26 GMT, Valerie Peng wrote: >> Anyone has time to review this RFE for adding AES cipher with KW, KWP modes >> support to SunPKCS11 provider? >> >> The main changes are in only one new class, i.e. P11KeyWrapCipher.java, >> which is the CipherSpi impl for the native PKC

Re: RFR: 8264849: Add KW and KWP support to PKCS11 provider [v2]

2021-10-11 Thread Valerie Peng
> Anyone has time to review this RFE for adding AES cipher with KW, KWP modes > support to SunPKCS11 provider? > > The main changes are in only one new class, i.e. P11KeyWrapCipher.java, which > is the CipherSpi impl for the native PKCS11 key wrap mechanisms. When testing > against NSS library,

Re: RFR: 8274879: Replace uses of StringBuffer with StringBuilder within java.base classes

2021-10-11 Thread Andrey Turbanov
On Thu, 7 Oct 2021 16:48:06 GMT, Naoto Sato wrote: >> StringBuffer is a legacy synchronized class. There are more modern >> alternatives which perform better: >> 1. Plain String concatenation should be preferred >> 2. StringBuilder is a direct replacement to StringBuffer which generally >> have

Re: RFR: 8275079: Remove unnecessary conversion to String in java.net.http

2021-10-11 Thread Andrey Turbanov
On Mon, 4 Oct 2021 13:39:00 GMT, Weijun Wang wrote: >> Cleanup unnecessary String.valueOf calls (and similar) when conversion will >> happen implicitly anyway > > src/java.net.http/share/classes/jdk/internal/net/http/Http1AsyncReceiver.java > line 738: > >> 736: if (flowTag != null

Re: RFR: 8275079: Remove unnecessary conversion to String in java.net.http

2021-10-11 Thread Weijun Wang
On Sat, 2 Oct 2021 20:05:37 GMT, Andrey Turbanov wrote: > Cleanup unnecessary String.valueOf calls (and similar) when conversion will > happen implicitly anyway Some small comments. src/java.net.http/share/classes/jdk/internal/net/http/Http1AsyncReceiver.java line 738: > 736: if

RFR: 8275079: Remove unnecessary conversion to String in java.net.http

2021-10-11 Thread Andrey Turbanov
Cleanup unnecessary String.valueOf calls (and similar) when conversion will happen implicitly anyway - Commit messages: - 8275079: Remove unnecessary conversion to String in java.net.http - [PATCH] Remove unnecessary conversion to String Changes: https://git.openjdk.java.net/jdk/p

Re: Integrated: 8274471: Verification of OCSP Response signed with RSASSA-PSS fails

2021-10-11 Thread can comert
Thank you very much! Regards, Can Wei-Jun Wang , 5 Eki 2021 Sal, 22:05 tarihinde şunu yazdı: > I think it's worth backporting to older LTS releases. Will ask sustaining > on it. > > Thanks, > Weijun > > > On Oct 5, 2021, at 2:36 PM, can comert wrote: > > > > > > Is there any backporting for a L

Re: JDK-8274471/Incident Report 9166550 : Verification of OCSP Response signed with RSASSA-PSS fails

2021-10-11 Thread can comert
Hello Andrew, Yes I tested it and I can verify that it works with Java 18 JDK as expected. Thank you very much for your effort. Here is the output of my example program with debug flags enabled: C:\work\java\jdk-18\bin\java.exe -Djava.security.auth.debug=certpath,ocsp start program ... certpath: