Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v10]

2021-11-01 Thread Michael McMahon
On Fri, 29 Oct 2021 16:17:46 GMT, Aleksei Efimov wrote: >> This change implements a new service provider interface for host name and >> address resolution, so that java.net.InetAddress API can make use of >> resolvers other than the platform's built-in resolver. >> >> The following API classes

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v10]

2021-11-01 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull request

Re: RFR: 8275811 Incorrect instance to dispose [v4]

2021-11-01 Thread Daniel Jeliński
> The current code that changes cipher suites disposes the new suite instead of > the old one, which usually silently fails. This patch fixes the code to > dispose the old instance instead. > > DTLS appears to be unaffected: DTLSOutputRecord keeps 2 ciphers and correctly > [disposes the old >

Re: RFR: 8275811 Incorrect instance to dispose

2021-11-01 Thread Daniel Jeliński
On Sun, 24 Oct 2021 04:58:45 GMT, Xue-Lei Andrew Fan wrote: >> Did you want to cover the update for line 222 at OutputRecord.java as well? > >> After reviewing the scope of changes to fix writeCipher disposal I decided >> to remove it entirely. It would probably be a nice follow-up enhancement,

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v11]

2021-11-01 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull request

Re: RFR: 8271566: DSA signature length value is not accurate in P11Signature [v2]

2021-11-01 Thread Valerie Peng
On Fri, 13 Aug 2021 17:11:45 GMT, Martin Balao wrote: >> As described in JDK-8271566 [1], this patch proposal is intended to fix a >> problem that arises when using DSA keys that have a 256-bits (or larger) G >> parameter for signatures (either signing or verifying). There were some >> incorre

RFR: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily

2021-11-01 Thread Jamil Nimeh
This fix handles cases where two or more threads may be acting on a single SSLSocket instance. In cases where one thread closes the socket while the other is in the middle of a read, a SocketException is appropriately thrown, but it results in SSLSession invalidation even though the session was

Re: RFR: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily

2021-11-01 Thread Xue-Lei Andrew Fan
On Mon, 1 Nov 2021 18:28:54 GMT, Jamil Nimeh wrote: > This fix handles cases where two or more threads may be acting on a single > SSLSocket instance. In cases where one thread closes the socket while the > other is in the middle of a read, a SocketException is appropriately thrown, > but it

Re: RFR: 8275811 Incorrect instance to dispose [v4]

2021-11-01 Thread Xue-Lei Andrew Fan
On Mon, 1 Nov 2021 14:13:43 GMT, Daniel Jeliński wrote: >> The current code that changes cipher suites disposes the new suite instead >> of the old one, which usually silently fails. This patch fixes the code to >> dispose the old instance instead. >> >> DTLS appears to be unaffected: DTLSOutp

Re: RFR: 8275811 Incorrect instance to dispose [v5]

2021-11-01 Thread Daniel Jeliński
> The current code that changes cipher suites disposes the new suite instead of > the old one, which usually silently fails. This patch fixes the code to > dispose the old instance instead. > > DTLS appears to be unaffected: DTLSOutputRecord keeps 2 ciphers and correctly > [disposes the old >

Re: RFR: 8275811 Incorrect instance to dispose [v4]

2021-11-01 Thread Daniel Jeliński
On Mon, 1 Nov 2021 19:49:32 GMT, Xue-Lei Andrew Fan wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Dispose write cipher after changing ciphers > > src/java.base/share/classes/sun/security/ssl/OutputRecord.java

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v12]

2021-11-01 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull request

Re: RFR: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily [v2]

2021-11-01 Thread Jamil Nimeh
> This fix handles cases where two or more threads may be acting on a single > SSLSocket instance. In cases where one thread closes the socket while the > other is in the middle of a read, a SocketException is appropriately thrown, > but it results in SSLSession invalidation even though the ses

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v10]

2021-11-01 Thread Paul Sandoz
On Mon, 1 Nov 2021 12:05:32 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-419 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjdk

Re: RFR: 8275811 Incorrect instance to dispose

2021-11-01 Thread Daniel Jeliński
On Sun, 24 Oct 2021 04:58:45 GMT, Xue-Lei Andrew Fan wrote: >> Did you want to cover the update for line 222 at OutputRecord.java as well? > >> After reviewing the scope of changes to fix writeCipher disposal I decided >> to remove it entirely. It would probably be a nice follow-up enhancement,