Re: RFR: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError

2021-12-01 Thread Weijun Wang
On Thu, 2 Dec 2021 01:20:30 GMT, Valerie Peng wrote: > Can someone help reviewing this trivial one-line fix? The assert check in > CK_MECHANISM.java is too strict and fail unexpectedly when digest-specific > PSS signature mechanisms are supported by the underlying PKCS#11 library. The > fix is

RFR: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError

2021-12-01 Thread Valerie Peng
Can someone help reviewing this trivial one-line fix? The assert check in CK_MECHANISM.java is too strict and fail unexpectedly when digest-specific PSS signature mechanisms are supported by the underlying PKCS#11 library. The fix is to remove this assert check. No new regression test added with

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v3]

2021-12-01 Thread Stuart Marks
On Wed, 1 Dec 2021 19:23:59 GMT, Brent Christian wrote: >> Here are the code changes for the "Deprecate finalizers in the standard Java >> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code >> review. >> >> This change makes the indicated deprecations, and updates the API

Re: RFR: 8277353: java/security/MessageDigest/ThreadSafetyTest.java test times out

2021-12-01 Thread Weijun Wang
On Wed, 1 Dec 2021 19:29:36 GMT, Sibabrata Sahoo wrote: > > Can you lower the `threadsFactor` or `duration`? Or set an upper limit for > > `nTasks`? > > I can reduce the threadFactor and duration to close to half(threadsFactor=2 > and duration=2 Or hardcode nTasks=20) and i think there still w

Re: RFR: 8225181: KeyStore should have a getAttributes method [v5]

2021-12-01 Thread Michael StJohns
On 11/30/2021 10:07 PM, Wei-Jun Wang wrote: My understanding is that Java's PKCS12KeyStore will fabricate an alias string if there is no friendlyName, since every entry inside a KeyStore object must have an alias. I'll take some look tomorrow. Ah - I see it now in PKCS12KeyStore - it assigns

Re: RFR: 8255266: 2021-11-27 public suffix list update v 3c213aa

2021-12-01 Thread Kevin Rushforth
On Wed, 1 Dec 2021 17:03:24 GMT, Weijun Wang wrote: > Update Public Suffix List data to the latest version at > https://github.com/publicsuffix/list. This is not a formal review, but it looks good to me. I verified that the new file matches the one from the referenced upstream commit. I also d

RFR: 8255409: Support the new APIs in PKCS#11 v3.0

2021-12-01 Thread Valerie Peng
PKCS#11 v3.0 adds the support for several new APIs. For this particular RFE, it enhances SunPKCS11 provider to load PKCS#11 provider by first trying the C_GetInterface (new in 3.0) before the C_GetFunctionList assuming not explicitly specified in config. In addition, PKCS#11 v3.0 defines a new A

Re: RFR: 8277353: java/security/MessageDigest/ThreadSafetyTest.java test times out

2021-12-01 Thread Sibabrata Sahoo
On Wed, 1 Dec 2021 15:12:16 GMT, Weijun Wang wrote: > Can you lower the `threadsFactor` or `duration`? Or set an upper limit for > `nTasks`? I can reduce the threadFactor and duration to close to half(threadsFactor=2 and duration=2 Or hardcode nTasks=20) and i think there still will be enough

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v3]

2021-12-01 Thread Brent Christian
> Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec for > JEP 421. It also updates the relevant @SuppressWarn

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v2]

2021-12-01 Thread Brent Christian
> Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec for > JEP 421. It also updates the relevant @SuppressWarn

Re: RFR: 8276660: Scalability bottleneck in java.security.Provider.getService() [v3]

2021-12-01 Thread Valerie Peng
> It is observed that when running crypto benchmark with large number of > threads, a lot of time is spent on the synchronized block inside the > Provider.getService() method. The cause for this is that > Provider.getService() method first uses the 'serviceMap' field to find the > requested ser

RFR: 8275082: Update XML Security for Java to 2.3.0

2021-12-01 Thread Weijun Wang
Import Apache Santuario 2.3.0 without the secure validation changes since in OpenJDK we are using the `jdk.xml.dsig.secureValidationPolicy` security property for XML Signature secure validation protection. Two commits are pushed: - 2.3.0: Import 2.3.0 code changes - revert: revert the Santuario

RFR: 8255266: 2021-11-27 public suffix list update v 3c213aa

2021-12-01 Thread Weijun Wang
Update Public Suffix List data to the latest version at https://github.com/publicsuffix/list. - Commit messages: - 8255266: 2021-11-27 public suffix list update v 3c213aa Changes: https://git.openjdk.java.net/jdk/pull/6643/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&p

Re: RFR: 8277353: java/security/MessageDigest/ThreadSafetyTest.java test times out

2021-12-01 Thread Weijun Wang
On Wed, 1 Dec 2021 06:26:58 GMT, Sibabrata Sahoo wrote: > This Test gets timeout during low cpu availability. It is modified to support > extended timeout period during JTREG execution. Can you lower the `threadsFactor` or `duration`? Or set an upper limit for `nTasks`? - PR: htt