On Fri, 3 Dec 2021 06:14:49 GMT, Sibabrata Sahoo wrote:
>> This Test gets timeout during low cpu availability. It is modified to
>> support extended timeout period during JTREG execution.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last
> This Test gets timeout during low cpu availability. It is modified to support
> extended timeout period during JTREG execution.
Sibabrata Sahoo has updated the pull request incrementally with one additional
commit since the last revision:
8277353: java/security/MessageDigest/ThreadSafetyTes
On Tue, 30 Nov 2021 19:48:19 GMT, Valerie Peng wrote:
>> Hmm, thinking more about "internal"/"opaque", given this is naming for the
>> parent, maybe "internal" is more correct. The non-sensitive keys are
>> encapsulated by the children classes and is still an instance of the parent.
>> If you
> JDK-8276681: Additional malformed Javadoc inline tags in JDK source
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains three additional comm
On Sat, 20 Nov 2021 04:09:51 GMT, Tim Prinzing wrote:
> JDK-8276681: Malformed Javadoc inline tags in JDK source
> jdk/internal/net/http/ResponseSubscribers.java
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6486
On Wed, 1 Dec 2021 17:31:37 GMT, Weijun Wang wrote:
> Import Apache Santuario 2.3.0 without the secure validation changes since in
> OpenJDK we are using the `jdk.xml.dsig.secureValidationPolicy` security
> property for XML Signature secure validation protection.
>
> Two commits are pushed:
>
On Wed, 1 Dec 2021 17:31:37 GMT, Weijun Wang wrote:
> Import Apache Santuario 2.3.0 without the secure validation changes since in
> OpenJDK we are using the `jdk.xml.dsig.secureValidationPolicy` security
> property for XML Signature secure validation protection.
>
> Two commits are pushed:
>
On Thu, 2 Dec 2021 19:12:37 GMT, Andrew Leonard wrote:
>> Oh, I didn't expand the diff far enough to actually see the context
>> correctly when I reviewed this as I would never have imagined the
>> conditional to be placed after the rule. While this will work as so far as
>> using the correct
On Thu, 2 Dec 2021 01:20:30 GMT, Valerie Peng wrote:
> Can someone help reviewing this trivial one-line fix? The assert check in
> CK_MECHANISM.java is too strict and fail unexpectedly when digest-specific
> PSS signature mechanisms are supported by the underlying PKCS#11 library. The
> fix is
On Thu, 2 Dec 2021 01:42:58 GMT, Weijun Wang wrote:
> Not a PKCS11 expert, but does a "digest-specific PSS signature mechanism"
> needs `setParameter` anymore? Or, must it be the same as the existing
> parameters dictated by the specified digest?
Previously when PSS support is added, the NSS l
On Thu, 2 Dec 2021 18:46:09 GMT, Erik Joelsson wrote:
>> this was my understanding:
>> https://www.gnu.org/software/make/manual/html_node/Variables-in-Recipes.html
>>
>> This occurs after make has finished reading all the makefiles and the target
>> is determined to be out of date; so, the rec
On Thu, 2 Dec 2021 18:03:50 GMT, Andrew Leonard wrote:
>> my assumption was the recipe gets resolved later
>
> this was my understanding:
> https://www.gnu.org/software/make/manual/html_node/Variables-in-Recipes.html
>
> This occurs after make has finished reading all the makefiles and the targ
On Thu, 2 Dec 2021 17:48:04 GMT, Andrew Leonard wrote:
>> you make a valid point, but i've tested this numerous times, but let me
>> check again
>
> my assumption was the recipe gets resolved later
this was my understanding:
https://www.gnu.org/software/make/manual/html_node/Variables-in-Recip
On Thu, 2 Dec 2021 17:46:35 GMT, Andrew Leonard wrote:
>> I would have expected to see something like:
>>
>> ifneq ($(CACERTS_SRC), )
>> GENDATA_CACERTS_SRC := $(CACERTS_SRC)
>> else
>> GENDATA_CACERTS_SRC := $(TOPDIR)/make/data/cacerts/
>> endif
>>
>> at line 63.
>
> you make a valid point
On Thu, 2 Dec 2021 17:35:36 GMT, Magnus Ihse Bursie wrote:
>> make/modules/java.base/Gendata.gmk line 76:
>>
>>> 74: ifneq ($(CACERTS_SRC), )
>>> 75: GENDATA_CACERTS_SRC := $(CACERTS_SRC)
>>> 76: endif
>>
>> Does this even work?! You are reassigning the variable after it has been
>> used. Th
On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard wrote:
>> Addition of a configure option --with-cacerts-src='user cacerts folder' to
>> allow developers to specify their own cacerts PEM folder for generation of
>> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>>
>> Si
On Thu, 2 Dec 2021 17:33:49 GMT, Magnus Ihse Bursie wrote:
>> Andrew Leonard has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
On Wed, 1 Dec 2021 18:30:06 GMT, Andrew Leonard wrote:
> Addition of a configure option --with-cacerts-src='user cacerts folder' to
> allow developers to specify their own cacerts PEM folder for generation of
> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>
> Signed-
On Thu, 2 Dec 2021 01:20:30 GMT, Valerie Peng wrote:
> Can someone help reviewing this trivial one-line fix? The assert check in
> CK_MECHANISM.java is too strict and fail unexpectedly when digest-specific
> PSS signature mechanisms are supported by the underlying PKCS#11 library. The
> fix is
On Thu, 2 Dec 2021 14:29:00 GMT, Sean Mullan wrote:
> I don’t have any major concerns with this change, as long as the default
> cacerts are still the ones that are in the JDK. As an aside, using Mozilla's
> root certificates might be fine for TLS certificates, but if you need to
> support cod
On Thu, 2 Dec 2021 01:20:30 GMT, Valerie Peng wrote:
> Can someone help reviewing this trivial one-line fix? The assert check in
> CK_MECHANISM.java is too strict and fail unexpectedly when digest-specific
> PSS signature mechanisms are supported by the underlying PKCS#11 library. The
> fix is
On Wed, 1 Dec 2021 17:03:24 GMT, Weijun Wang wrote:
> Update Public Suffix List data to the latest version at
> https://github.com/publicsuffix/list.
Marked as reviewed by mullan (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6643
On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard wrote:
>> Addition of a configure option --with-cacerts-src='user cacerts folder' to
>> allow developers to specify their own cacerts PEM folder for generation of
>> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>>
>> Si
On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard wrote:
>> Addition of a configure option --with-cacerts-src='user cacerts folder' to
>> allow developers to specify their own cacerts PEM folder for generation of
>> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>>
>> Si
On Wed, 1 Dec 2021 19:29:36 GMT, Sibabrata Sahoo wrote:
>> Can you lower the `threadsFactor` or `duration`? Or set an upper limit for
>> `nTasks`?
>
>> Can you lower the `threadsFactor` or `duration`? Or set an upper limit for
>> `nTasks`?
>
> I can reduce the threadFactor and duration to clos
On Wed, 1 Dec 2021 18:47:41 GMT, Erik Joelsson wrote:
>> Andrew Leonard has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commi
> Addition of a configure option --with-cacerts-src='user cacerts folder' to
> allow developers to specify their own cacerts PEM folder for generation of
> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the p
On Thu, 2 Dec 2021 00:09:31 GMT, Sergey Bylokhov wrote:
> I have a question related to the custom cacerts which can be added to the
> OpenJDK bundle. How do you pass the tests like
> test/jdk/sun/security/lib/cacerts/VerifyCACerts.java using that custom jdk
> bundle? Probably we can add an add
28 matches
Mail list logo
