Re: RFR: 8271566: DSA signature length value is not accurate in P11Signature [v3]

2021-12-03 Thread Valerie Peng
On Thu, 2 Dec 2021 21:31:52 GMT, Martin Balao wrote: >> As described in JDK-8271566 [1], this patch proposal is intended to fix a >> problem that arises when using DSA keys that have a 256-bits (or larger) G >> parameter for signatures (either signing or verifying). There were some >> incorrec

Integrated: 8278247: KeyStoreSpi::engineGetAttributes does not throws KeyStoreException

2021-12-03 Thread Weijun Wang
On Fri, 3 Dec 2021 19:36:51 GMT, Weijun Wang wrote: > The specification wrongly claims there could be an exception thrown, but it's > not true. This pull request has now been integrated. Changeset: e1cde19d Author:Weijun Wang URL: https://git.openjdk.java.net/jdk/commit/e1cde19dbdb

Re: RFR: 8271566: DSA signature length value is not accurate in P11Signature [v3]

2021-12-03 Thread Valerie Peng
On Thu, 2 Dec 2021 21:31:52 GMT, Martin Balao wrote: >> As described in JDK-8271566 [1], this patch proposal is intended to fix a >> problem that arises when using DSA keys that have a 256-bits (or larger) G >> parameter for signatures (either signing or verifying). There were some >> incorrec

Re: RFR: 8278247: KeyStoreSpi::engineGetAttributes does not throws KeyStoreException

2021-12-03 Thread Sean Mullan
On Fri, 3 Dec 2021 19:36:51 GMT, Weijun Wang wrote: > The specification wrongly claims there could be an exception thrown, but it's > not true. Looks good. Add a noreg-doc or something similar to the bug. - Marked as reviewed by mullan (Reviewer). PR: https://git.openjdk.java.net

RFR: 8278247: KeyStoreSpi::engineGetAttributes does not throws KeyStoreException

2021-12-03 Thread Weijun Wang
The specification wrongly claims there could be an exception thrown, but it's not true. - Commit messages: - 8278247: KeyStoreSpi::engineGetAttributes does not throws KeyStoreException Changes: https://git.openjdk.java.net/jdk/pull/6706/files Webrev: https://webrevs.openjdk.java.n

Re: RFR: 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation [v2]

2021-12-03 Thread Rajan Halade
On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard wrote: >> Addition of a configure option --with-cacerts-src='user cacerts folder' to >> allow developers to specify their own cacerts PEM folder for generation of >> the cacerts store using the deterministic openjdk GenerateCacerts tool. >> >> Si

Re: RFR: 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation

2021-12-03 Thread Sergey Bylokhov
On Thu, 2 Dec 2021 10:55:57 GMT, Andrew Leonard wrote: > This is the case at Adoptium for example, which uses the Mozilla trusted CA > certs. But they didn't think skipping this test was too strong a step? For example validation of the certs expiration is quite useful. I tried to update the te

Integrated: 8225181: KeyStore should have a getAttributes method

2021-12-03 Thread Weijun Wang
On Wed, 20 Oct 2021 02:08:24 GMT, Weijun Wang wrote: > Add `KeyStore::getAttributes` so that one can get the attributes of an entry > without retrieving the entry first. This is especially useful for a private > key entry which can only be retrieved with a password. This pull request has now b

Re: RFR: 8225181: KeyStore should have a getAttributes method [v5]

2021-12-03 Thread Sean Mullan
On Wed, 1 Dec 2021 01:15:27 GMT, Weijun Wang wrote: >> Add `KeyStore::getAttributes` so that one can get the attributes of an entry >> without retrieving the entry first. This is especially useful for a private >> key entry which can only be retrieved with a password. > > Weijun Wang has update

Re: RFR: 8275082: Update XML Security for Java to 2.3.0 [v2]

2021-12-03 Thread Weijun Wang
> Import Apache Santuario 2.3.0 without the secure validation changes since in > OpenJDK we are using the `jdk.xml.dsig.secureValidationPolicy` security > property for XML Signature secure validation protection. > > Two commits are pushed: > > - 2.3.0: Import 2.3.0 code changes > - revert: reve