Re: RFR: 8274809: Update java.base classes to use try-with-resources [v4]

2021-12-07 Thread Daniel Fuchs
On Tue, 7 Dec 2021 14:24:41 GMT, Andrey Turbanov wrote: >> src/java.base/share/classes/sun/net/www/MimeTable.java line 385: >> >>> 383: >>> 384: protected boolean saveAsProperties(File file) { >>> 385: try (FileOutputStream os = new FileOutputStream(file)) { >> >> This is not stric

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v4]

2021-12-07 Thread Daniel Fuchs
On Wed, 6 Oct 2021 20:37:29 GMT, Andrey Turbanov wrote: >> 8274809: Update java.base classes to use try-with-resources > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8274809: Update java.base classes to use try-with-res

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v4]

2021-12-07 Thread Andrey Turbanov
On Tue, 7 Dec 2021 11:41:12 GMT, Daniel Fuchs wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274809: Update java.base classes to use try-with-resources >> fix review comments > > src/java.base/share/classes/

Re: RFR: 8277932: Subject:callAs() not throwing NPE when action is null

2021-12-07 Thread Weijun Wang
On Tue, 7 Dec 2021 07:14:53 GMT, Alan Bateman wrote: > Is there a test for this? (I see noreg-trivial is added but a test should be > easy to add). I can add one, just thought it's not necessary. I didn't say noreg-hard. :-) - PR: https://git.openjdk.java.net/jdk/pull/6728

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v4]

2021-12-07 Thread Daniel Fuchs
On Wed, 6 Oct 2021 20:37:29 GMT, Andrey Turbanov wrote: >> 8274809: Update java.base classes to use try-with-resources > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8274809: Update java.base classes to use try-with-res

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v4]

2021-12-07 Thread Alan Bateman
On Wed, 6 Oct 2021 20:37:29 GMT, Andrey Turbanov wrote: >> 8274809: Update java.base classes to use try-with-resources > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8274809: Update java.base classes to use try-with-res