On Thu, 13 Jan 2022 21:40:16 GMT, Weijun Wang wrote:
>> Please review this enhancement and its
>> [CSR](https://bugs.openjdk.java.net/browse/JDK-8279632). Two new options `-s
>> salt` and `-f` can be specified on the `ktab` command when adding entries.
>>
>> I'm a little concerned about the co
On Thu, 13 Jan 2022 11:40:20 GMT, Lance Andersen wrote:
>> OK, so lines 264, 295, 329, 364, 431 are arguably wrong as well?
>> Separating the [] completely looks quite rare.
>> I'll leave it up to you. 8-)
>
> I think that can be a follow on clean up.
The strange formatting of `long []updateC
On Thu, 13 Jan 2022 21:57:57 GMT, Sean Mullan wrote:
>> If a JAR is signed with multiple digest algorithms and one of the digest
>> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
>> returning null indicating that the jar entry has no signers.
>>
>> This fixes the iss
On Thu, 13 Jan 2022 21:54:17 GMT, Weijun Wang wrote:
>> The algorithm constraints check will be skipped (because `permittedAlgs`
>> will be `null`) but the hash check will not be skipped.
>>
>> I don't think `null` would be returned in a normal case. The only case I can
>> think of is if there
On Thu, 13 Jan 2022 19:54:44 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java
>> line 211:
>>
>>> 209: }
>>> 210:
>>> 211: CodeSigner[] entrySigners = sigFileSigners.get(name);
>>
>> What if we return here if `entrySigners ==
On Wed, 12 Jan 2022 02:15:45 GMT, Hai-May Chao wrote:
> `keytool` currently uses a simpler scheme in `DisabledAlgorithmConstraints`
> class when performing algorithm constraints checks. This change is to enhance
> `keytool` to make use of the new methods
> `DisabledAlgorithmConstraints.permits
> If a JAR is signed with multiple digest algorithms and one of the digest
> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
> returning null indicating that the jar entry has no signers.
>
> This fixes the issue such that an entry is considered signed if at least one
On Thu, 13 Jan 2022 20:26:05 GMT, Valerie Peng wrote:
>> Same goes for test/jdk/sun/security/krb5/auto/Context.java.
>
> And test/jdk/sun/security/krb5/tools/KtabCheck.java.
Yes.
-
PR: https://git.openjdk.java.net/jdk/pull/6991
On Thu, 13 Jan 2022 19:45:37 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> duplicate words, and another year
>
> src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Ktab.java
On Thu, 13 Jan 2022 19:52:55 GMT, Valerie Peng wrote:
>> src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Ktab.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> 2022
>
> Same goes for sun/securi
> Please review this enhancement and its
> [CSR](https://bugs.openjdk.java.net/browse/JDK-8279632). Two new options `-s
> salt` and `-f` can be specified on the `ktab` command when adding entries.
>
> I'm a little concerned about the compatibility risk described in the CSR,
> i.e. the `-f` opti
On Thu, 13 Jan 2022 20:07:30 GMT, Valerie Peng wrote:
>> test/jdk/sun/security/krb5/auto/tools/KtabSalt.java line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>>
>> 2022
>
> Same goes for test/jdk/sun/security/krb5/auto/Context.java.
And test
On Fri, 7 Jan 2022 19:35:56 GMT, Weijun Wang wrote:
> Please review this enhancement and its
> [CSR](https://bugs.openjdk.java.net/browse/JDK-8279632). Two new options `-s
> salt` and `-f` can be specified on the `ktab` command when adding entries.
>
> I'm a little concerned about the compatib
On Thu, 13 Jan 2022 20:06:34 GMT, Valerie Peng wrote:
>> Please review this enhancement and its
>> [CSR](https://bugs.openjdk.java.net/browse/JDK-8279632). Two new options `-s
>> salt` and `-f` can be specified on the `ktab` command when adding entries.
>>
>> I'm a little concerned about the c
On Thu, 13 Jan 2022 16:55:08 GMT, Weijun Wang wrote:
>> If a JAR is signed with multiple digest algorithms and one of the digest
>> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
>> returning null indicating that the jar entry has no signers.
>>
>> This fixes the iss
On Fri, 7 Jan 2022 19:35:56 GMT, Weijun Wang wrote:
> Please review this enhancement and its
> [CSR](https://bugs.openjdk.java.net/browse/JDK-8279632). Two new options `-s
> salt` and `-f` can be specified on the `ktab` command when adding entries.
>
> I'm a little concerned about the compatib
On Thu, 13 Jan 2022 19:51:21 GMT, Valerie Peng wrote:
>> Please review this enhancement and its
>> [CSR](https://bugs.openjdk.java.net/browse/JDK-8279632). Two new options `-s
>> salt` and `-f` can be specified on the `ktab` command when adding entries.
>>
>> I'm a little concerned about the c
On Fri, 7 Jan 2022 19:35:56 GMT, Weijun Wang wrote:
> Please review this enhancement and its
> [CSR](https://bugs.openjdk.java.net/browse/JDK-8279632). Two new options `-s
> salt` and `-f` can be specified on the `ktab` command when adding entries.
>
> I'm a little concerned about the compatib
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Thu, 13 Jan 2022 13:48:02 GMT, Pavel Rappo wrote:
> > Yes an "or" is probably worthwhile to add.
>
> I would prefer to leave it for the follow-up cleanup if only because adding
> "or" here would make it inconsistent with other `@throws SQLException`
> descriptions in that file and perhaps e
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Thu, 13 Jan 2022 10:59:13 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/sun/text/RuleBasedBreakIterator.java line 73:
>>
>>> 71: * will be transparent to the BreakIterator. A sequence of
>>> characters will break the
>>> 72: * same way it would if any ignore characters it contain
On Thu, 13 Jan 2022 12:37:46 GMT, Pavel Rappo wrote:
> > The above is a bit confusing as it reads(same in ImageInputStream.java). I
> > think that that can be looked at later.
>
> Just to clarify: you are okay with removing the ` ` entity, right? As for
> ImageInputStream, some doc comments sh
On Wed, 12 Jan 2022 21:57:22 GMT, Sean Mullan wrote:
> If a JAR is signed with multiple digest algorithms and one of the digest
> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
> returning null indicating that the jar entry has no signers.
>
> This fixes the issue su
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Thu, 13 Jan 2022 13:56:14 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java
>> line 212:
>>
>>> 210:
>>> 211: CodeSigner[] entrySigners = sigFileSigners.get(name);
>>> 212: Map permittedAlgs =
>>
>> maybe permittedAlgsChecke
On Wed, 12 Jan 2022 21:57:22 GMT, Sean Mullan wrote:
> If a JAR is signed with multiple digest algorithms and one of the digest
> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
> returning null indicating that the jar entry has no signers.
>
> This fixes the issue su
On Tue, 11 Jan 2022 20:34:59 GMT, Weijun Wang wrote:
> Add OID aliases for the 2 service. This makes sure KeyFactory can be created
> and read an encoded key without knowing what the OID in the encoding is for.
This pull request has now been integrated.
Changeset: 0a839b43
Author:Weijun Wa
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream and DataInput is an irrelevant
> formatting artefact
On Thu, 13 Jan 2022 12:33:53 GMT, Sean Coffey wrote:
>> If a JAR is signed with multiple digest algorithms and one of the digest
>> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
>> returning null indicating that the jar entry has no signers.
>>
>> This fixes the iss
On Thu, 13 Jan 2022 11:38:13 GMT, Lance Andersen wrote:
> Yes an "or" is probably worthwhile to add.
I would prefer to leave it for the follow-up cleanup if only because adding
"or" here would make it inconsistent with other `@throws SQLException`
descriptions in that file and perhaps elsewher
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream
On Wed, 12 Jan 2022 21:57:22 GMT, Sean Mullan wrote:
> If a JAR is signed with multiple digest algorithms and one of the digest
> algorithms is disabled, `ManifestEntryVerifier.verify()` was incorrectly
> returning null indicating that the jar entry has no signers.
>
> This fixes the issue su
On Thu, 13 Jan 2022 11:42:48 GMT, Lance Andersen wrote:
> The above is a bit confusing as it reads(same in ImageInputStream.java). I
> think that that can be looked at later.
Just to clarify: you are okay with removing the ` ` entity, right? As for
ImageInputStream, some doc comments should pr
On Thu, 13 Jan 2022 11:29:35 GMT, Pavel Rappo wrote:
>> src/java.sql/share/classes/java/sql/Statement.java line 784:
>>
>>> 782: * statement returns a {@code ResultSet} object, the second
>>> argument
>>> 783: * supplied to this method is not an
>>> 784: * {@code int} array whose
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream
On Thu, 13 Jan 2022 11:28:34 GMT, Kevin Walls wrote:
>> I thought about it too, but then noticed how the position of `[]` mimics
>> that of the respective method signatures in code.
>
> OK, so lines 264, 295, 329, 364, 431 are arguably wrong as well? Separating
> the [] completely looks quite
On Thu, 13 Jan 2022 11:18:42 GMT, Kevin Walls wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Thu, 13 Jan 2022 11:04:43 GMT, Pavel Rappo wrote:
>> src/java.sql/share/classes/java/sql/BatchUpdateException.java line 58:
>>
>>> 56: * A JDBC driver implementation should use
>>> 57: * the constructor {@code BatchUpdateException(String reason, String
>>> SQLState,
>>> 58: * int vendorCo
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in ImageInputStream
On Thu, 13 Jan 2022 11:00:55 GMT, Kevin Walls wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, in ImageInputStre
On Thu, 13 Jan 2022 10:46:11 GMT, Kevin Walls wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, in ImageInputStre
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, in ImageInputStream a
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, in ImageInputStream a
- Most of the typos are of a trivial kind: missing whitespace.
- If any of the typos should be fixed in the upstream projects instead, please
say so; I will drop those typos from the patch.
- As I understand it, in ImageInputStream and DataInput is an irrelevant
formatting artefact and thus can
46 matches
Mail list logo
