RFR: 8280363: Minor correction of ALPN specification in SSLParameters

2022-01-19 Thread Xue-Lei Andrew Fan
In the getApplicationProtocols() method in javax.net.ssl.SSLParameters, the return statement says that "The array is ordered based on protocol preference, with protocols[0] being the most preferred.". However, there is no "protocols" variable in this method. The update is a minor correction so

Integrated: Merge jdk18

2022-01-19 Thread Jesper Wilhelmsson
On Thu, 20 Jan 2022 00:28:55 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: 4616c13c Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/4616c13c2f1ced8a8bdeed81f0469523932e91b5 Stats: 1732

RFR: Merge jdk18

2022-01-19 Thread Jesper Wilhelmsson
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge - 8280233: Temporarily disable Unix domain sockets in Windows PipeImpl - 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling - 8272058: 25 Null pointer dereference defect groups in 4 files

Integrated: 8279796: Fix typo: Constucts -> Constructs

2022-01-19 Thread Weijun Wang
On Wed, 19 Jan 2022 22:18:32 GMT, Weijun Wang wrote: > Two edits. This pull request has now been integrated. Changeset: 98d96a77 Author:Weijun Wang URL: https://git.openjdk.java.net/jdk/commit/98d96a770756ffe3e7f5e4b82120e9fb484cad9a Stats: 2 lines in 1 file changed: 0 ins; 0 de

Re: RFR: 8279796: Fix typo: Constucts -> Constructs [v2]

2022-01-19 Thread Weijun Wang
> Two edits. Weijun Wang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision: - year - Update DigestM

Re: RFR: 8279796: Fix typo: Constucts -> Constructs

2022-01-19 Thread Weijun Wang
On Wed, 19 Jan 2022 22:57:06 GMT, Sergey Bylokhov wrote: >> Two edits. > > src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java > line 727: > >> 725: Handler handler; >> 726: /** >> 727: * Constructs a {@code DoubleClickListener}. > > This chan

Re: RFR: 8279796: Fix typo: Constucts -> Constructs

2022-01-19 Thread Sergey Bylokhov
On Wed, 19 Jan 2022 22:18:32 GMT, Weijun Wang wrote: > Two edits. src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java line 727: > 725: Handler handler; > 726: /** > 727: * Constructs a {@code DoubleClickListener}. This change is under review

Re: RFR: 8279796: Fix typo: Constucts -> Constructs

2022-01-19 Thread Iris Clark
On Wed, 19 Jan 2022 22:18:32 GMT, Weijun Wang wrote: > Two edits. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7147

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v2]

2022-01-19 Thread Weijun Wang
On Wed, 19 Jan 2022 22:20:47 GMT, Michael McMahon wrote: >> Hi, >> >> This change adds Channel Binding Token (CBT) support to HTTPS >> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, >> Kerberos) authentication scheme. When enabled, the implementation >> preemptively inclu

RFR: 8279796: Fix typo: Constucts -> Constructs

2022-01-19 Thread Weijun Wang
Two edits. - Commit messages: - Another year - year - Update DigestMD5Base.java - 8279796: Fix typo: Constucts -> Constructs Changes: https://git.openjdk.java.net/jdk/pull/7147/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7147&range=00 Issue: https://bugs.openjd

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v2]

2022-01-19 Thread Michael McMahon
> Hi, > > This change adds Channel Binding Token (CBT) support to HTTPS > (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos) > authentication scheme. When enabled, the implementation preemptively includes > a CBT with authentication requests over Kerberos. The feature

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-19 Thread Mandy Chung
On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to start because SecurityManager is disabled

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos

2022-01-19 Thread Michael McMahon
On Fri, 14 Jan 2022 15:06:12 GMT, Daniel Fuchs wrote: > Have you been able to test this on a specific setup? Would be good to hear > from @msheppar too. I have tested it with the server setup by Prajwal. Security SQE are looking into configuring a server with a similar setup which can be teste

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos

2022-01-19 Thread Michael McMahon
On Wed, 19 Jan 2022 15:36:16 GMT, Michael McMahon wrote: >>> It's actually a purely system property rather than a Net property at the >>> moment (same as the other spnego ones). Maybe, I should convert them all to >>> net properties, so they can be documented/set in that file? >> >> AFAICS thi

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos

2022-01-19 Thread Michael McMahon
On Sat, 15 Jan 2022 14:02:15 GMT, Michael Osipov wrote: >> I suggest moving the `TlsChannelBinding` class into >> `java.base/sun.security.util` since it's not only used by LDAP anymore. It's >> even not restricted to GSS-API. According to >> https://www.rfc-editor.org/rfc/rfc5056, "Although in

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos

2022-01-19 Thread Michael McMahon
On Mon, 17 Jan 2022 13:49:35 GMT, Daniel Fuchs wrote: >> I vote for "jdk.https.tls.cbt" > >> It's actually a purely system property rather than a Net property at the >> moment (same as the other spnego ones). Maybe, I should convert them all to >> net properties, so they can be documented/set i

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos

2022-01-19 Thread Michael McMahon
On Mon, 17 Jan 2022 13:44:06 GMT, Daniel Fuchs wrote: >> Shall we log a message if the value is not one of the 3 forms? > > Usually malformed values are just ignored - and the property takes its > default value. But yes - s.n.w.h.HttpClient has a logger so it wouldn't be > much effort to log it

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-19 Thread Kevin Walls
On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to start because SecurityManager is disabled

Integrated: 8274811: Remove superfluous use of boxing in java.base

2022-01-19 Thread Andrey Turbanov
On Sat, 11 Sep 2021 12:11:50 GMT, Andrey Turbanov wrote: > Usages of primitive types should be preferred and makes code easier to read. > Similar cleanups: > 1. [JDK-8273168](https://bugs.openjdk.java.net/browse/JDK-8273168) > java.desktop > 2. [JDK-8274234](https://bugs.openjdk.java.net/browse/