Re: RFR: 8275914: SHA3: changing java implementation to help C2 create high-performance code

2022-01-27 Thread Boris Ulasevich
On Wed, 15 Dec 2021 09:20:38 GMT, Boris Ulasevich wrote: > Background > > The goal is to improve SHA3 implementation performance as it runs up to two > times slower than native (OpenSSL, measured on AMD64 and AArch6464) > implementation. Some hardware provides SHA3 accelerators, but most (AMD

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-27 Thread Xue-Lei Andrew Fan
On Thu, 27 Jan 2022 23:43:51 GMT, Jie Fu wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright correction > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 3: > >> 1: /* >> 2: * Copy

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-27 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the pull request increment

Re: RFR: 8280494: (D)TLS signature schemes

2022-01-27 Thread Bernd
On Thu, 27 Jan 2022 22:06:21 GMT, Xue-Lei Andrew Fan wrote: > This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280

Re: RFR: 8280494: (D)TLS signature schemes

2022-01-27 Thread Jie Fu
On Thu, 27 Jan 2022 22:06:21 GMT, Xue-Lei Andrew Fan wrote: > This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280

RFR: 8280494: (D)TLS signature schemes

2022-01-27 Thread Xue-Lei Andrew Fan
This update is to support signature schemes customization for individual (D)TLS connection. Please review the CSR as well: CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 - Commit messages: - 8280494: https://bugs.openjdk.

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-27 Thread Kevin Walls
On Thu, 27 Jan 2022 17:44:39 GMT, Roger Riggs wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Wildcard in object filter to permit proxies, in case other activity in >> this JVM changes the nameing/numbering of prox

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-27 Thread Kevin Walls
On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to start because SecurityManager is disabled

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v3]

2022-01-27 Thread Kevin Walls
> Remove the use of Security Manager from jstatd. > Add use of an ObjectInputFilter to restrict RMI. > > Also we can undo the property-setting Launcher.gmk change from: 8279007: > jstatd fails to start because SecurityManager is disabled > ..as that is no longer needed. > > Docs/man page update

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v12]

2022-01-27 Thread Daniel Fuchs
On Thu, 27 Jan 2022 18:05:25 GMT, Michael McMahon wrote: >> Hi, >> >> This change adds Channel Binding Token (CBT) support to HTTPS >> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, >> Kerberos) authentication scheme. When enabled, the implementation >> preemptively inclu

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v10]

2022-01-27 Thread Michael McMahon
On Thu, 27 Jan 2022 16:47:52 GMT, Daniel Fuchs wrote: >> It's `java.net.SocketException: Unexpected end of file from server`. Does >> not include any CBT words so don't know if it's worth parsing. > > Thanks. Then it would be better to catch only `SocketException` here rather > than `Exception`

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v12]

2022-01-27 Thread Michael McMahon
> Hi, > > This change adds Channel Binding Token (CBT) support to HTTPS > (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos) > authentication scheme. When enabled, the implementation preemptively includes > a CBT with authentication requests over Kerberos. The feature

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-27 Thread Roger Riggs
On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to start because SecurityManager is disabled

Re: RFR: 8275914: SHA3: changing java implementation to help C2 create high-performance code

2022-01-27 Thread Anthony Scarpino
On Wed, 15 Dec 2021 09:20:38 GMT, Boris Ulasevich wrote: > Background > > The goal is to improve SHA3 implementation performance as it runs up to two > times slower than native (OpenSSL, measured on AMD64 and AArch6464) > implementation. Some hardware provides SHA3 accelerators, but most (AMD

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-27 Thread Chris Plummer
On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to start because SecurityManager is disabled

Re: RFR: JDK-8280703 CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption [v2]

2022-01-27 Thread Anthony Scarpino
On Wed, 26 Jan 2022 18:07:24 GMT, Sebastian Stenzel wrote: >> Related to #411, however it turns out that for unpadded ciphers, there is no >> need to allocate `internalOutput`, if `output` provides sufficient capacity. >> >> For padded ciphers, only the unpadded cleartext is expected to be cop

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v10]

2022-01-27 Thread Daniel Fuchs
On Wed, 26 Jan 2022 19:00:14 GMT, Weijun Wang wrote: >> test/jdk/sun/security/krb5/auto/HttpsCB.java line 201: >> >>> 199: return reader.readLine().equals(CONTENT); >>> 200: } catch (Exception e) { >>> 201: return false; >> >> Should we log that we have received

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v11]

2022-01-27 Thread Michael McMahon
> Hi, > > This change adds Channel Binding Token (CBT) support to HTTPS > (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos) > authentication scheme. When enabled, the implementation preemptively includes > a CBT with authentication requests over Kerberos. The feature

Re: RFR: 8275914: SHA3: changing java implementation to help C2 create high-performance code

2022-01-27 Thread Paul Hohensee
On Wed, 15 Dec 2021 09:20:38 GMT, Boris Ulasevich wrote: > Background > > The goal is to improve SHA3 implementation performance as it runs up to two > times slower than native (OpenSSL, measured on AMD64 and AArch6464) > implementation. Some hardware provides SHA3 accelerators, but most (AMD

Re: RFR: 8275914: SHA3: changing java implementation to help C2 create high-performance code

2022-01-27 Thread Paul Hohensee
On Wed, 15 Dec 2021 09:20:38 GMT, Boris Ulasevich wrote: > Background > > The goal is to improve SHA3 implementation performance as it runs up to two > times slower than native (OpenSSL, measured on AMD64 and AArch6464) > implementation. Some hardware provides SHA3 accelerators, but most (AMD

Re: RFR: 8255739: x509Certificate returns � for invalid subjectAlternativeNames [v2]

2022-01-27 Thread Masanori Yano
On Fri, 14 Jan 2022 11:18:23 GMT, Masanori Yano wrote: >> Could you please review the JDK-8255739 bug fix? >> >> I think sun.security.x509.SubjectAlternativeNameExtension() should throw an >> exception for incorrect SubjectAlternativeNames instead of returning the >> substituted characters, wh