On Thu, 10 Feb 2022 06:18:28 GMT, John Jiang wrote:
> In class sun.security.x509.X509CRLImpl, method getExtension(ObjectIdentifier)
> doesn't declare that IOException would be thrown, so the @throws IOException
> doc should be removed.
Looks good and trivial.
-
Marked as
On Thu, 10 Feb 2022 06:18:28 GMT, John Jiang wrote:
> In class sun.security.x509.X509CRLImpl, method getExtension(ObjectIdentifier)
> doesn't declare that IOException would be thrown, so the @throws IOException
> doc should be removed.
Marked as reviewed by xuelei (Reviewer).
-
In class sun.security.x509.X509CRLImpl, method getExtension(ObjectIdentifier)
doesn't declare that IOException would be thrown, so the @throws IOException
doc should be removed.
-
Commit messages:
- 8281567: Remove @throws IOException from X509CRLImpl::getExtension docs
Changes:
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
> Release-note:
On Wed, 9 Feb 2022 21:38:22 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Spec update
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 749:
>
>> 747: * @implNote
On Wed, 3 Nov 2021 17:02:40 GMT, Alexey Bakhtin wrote:
>> Please review the patch for JDK-8274524
>>
>> The fix just adds locks around InputStream read and skip operations to
>> prevent concurrent read from socket.
>> sun/security/ssl jtreg tests passed
>>
On Wed, 9 Feb 2022 18:24:56 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE:
On Tue, 8 Feb 2022 18:06:04 GMT, Lance Andersen wrote:
>>> ze can't be null here.
>>
>> Actually it can be: Consider the following:
>>
>>
>> try (JarFile jf = new JarFile(SIGNED_VALID_ENTRY_NAME_JAR.toFile(),
>> true)) {
>> var ze = new
On Wed, 9 Feb 2022 14:33:11 GMT, Sean Mullan wrote:
>> Basically, the suggestion captures the implementation behaviors correctly.
>> To make it more accuracy, if we want to use it, we may need to consider more
>> cases:
>> 1. _explicitly set by application_, with null, empty or 1+ schemes.
>>
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
> Release-note:
On Tue, 8 Feb 2022 17:13:53 GMT, Hai-May Chao wrote:
> This is to fix `DomainKeyStore::engineAliases` to take into account that
> there may be empty keystore(s) within the collection of keystores of a domain
> keystore.
This pull request has now been integrated.
Changeset: 178b962e
Author:
On Tue, 8 Feb 2022 23:36:05 GMT, Xue-Lei Andrew Fan wrote:
>> Ok, I get it now, the API wins if both are set. But I could not discern that
>> from the current text. I think it is ok to be more clear about this. I
>> suggest adding something like the following:
>>
>> "The set of signature
On Wed, 9 Feb 2022 06:34:40 GMT, Hai-May Chao wrote:
>> This is to fix `DomainKeyStore::engineAliases` to take into account that
>> there may be empty keystore(s) within the collection of keystores of a
>> domain keystore.
>
> Hai-May Chao has updated the pull request incrementally with one
13 matches
Mail list logo
