Re: RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake [v2]

2022-02-11 Thread Xue-Lei Andrew Fan
On Fri, 11 Feb 2022 20:07:43 GMT, Alexey Bakhtin wrote: >> Please review the patch for the JDK-8274524 >> >> SSLSocket.close() could cause an intermittent hang of the socket read >> operation. It happens in case of SO_TIMEOUT is set to 0 (infinite timeout). >> SSLSocket.close() reads from the

Re: RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake [v2]

2022-02-11 Thread Alexey Bakhtin
> Please review the patch for the JDK-8274524 > > SSLSocket.close() could cause an intermittent hang of the socket read > operation. It happens in case of SO_TIMEOUT is set to 0 (infinite timeout). > SSLSocket.close() reads from the socket as part of the skip() operation to > prevent TCP

Re: RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake

2022-02-11 Thread Alexey Bakhtin
On Fri, 11 Feb 2022 18:04:35 GMT, Xue-Lei Andrew Fan wrote: >> Hi @XueleiFan, >> Not quite sure What could be wrong with setting SO_TIMEOUT during the >> socketClose() operation. We still close the socket and SO_TIMEOUT will be >> restored just after skip() operation is completed. These

Re: RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake

2022-02-11 Thread Xue-Lei Andrew Fan
On Fri, 11 Feb 2022 09:27:11 GMT, Alexey Bakhtin wrote: >> src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java line 1792: >> >>> 1790: try { >>> 1791: if (soTimeout == 0) >>> 1792:

Re: RFR: 8280409: JarFile::verifiableEntry can fail with NPE accessing ze.getName() [v3]

2022-02-11 Thread Lance Andersen
On Fri, 11 Feb 2022 13:45:47 GMT, Alan Bateman wrote: >> Lance Andersen has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Return a null InputStream when the ZipEntry is not found in the Jar >> - Address formatting and message feedback

Re: RFR: 8277976: Break up SEQUENCE in X509Certiticate::getSubjectAlternativeNames and X509Certiticate::getIssuerAlternativeNames in otherName [v4]

2022-02-11 Thread Sean Mullan
On Fri, 11 Feb 2022 17:13:46 GMT, Weijun Wang wrote: >> The enhancement adds two extra items in the `getSubjectAlternativeNames()` >> output for an OtherName. >> >> It also fix several errors: >> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]` >> without the tag

Re: RFR: 8277976: Break up SEQUENCE in X509Certiticate::getSubjectAlternativeNames and X509Certiticate::getIssuerAlternativeNames in otherName [v3]

2022-02-11 Thread Weijun Wang
On Fri, 11 Feb 2022 14:58:30 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more precise spec > > src/java.base/share/classes/java/security/cert/X509Certificate.java line 594: > >> 592: * a

Re: RFR: 8277976: Break up SEQUENCE in X509Certiticate::getSubjectAlternativeNames and X509Certiticate::getIssuerAlternativeNames in otherName [v4]

2022-02-11 Thread Weijun Wang
> The enhancement adds two extra items in the `getSubjectAlternativeNames()` > output for an OtherName. > > It also fix several errors: > 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]` > without the tag and length bytes. > 2. The argument in constructor

Re: RFR: 8277976: Break up SEQUENCE in X509Certiticate::getSubjectAlternativeNames and X509Certiticate::getIssuerAlternativeNames in otherName [v3]

2022-02-11 Thread Sean Mullan
On Thu, 10 Feb 2022 21:14:17 GMT, Weijun Wang wrote: >> The enhancement adds two extra items in the `getSubjectAlternativeNames()` >> output for an OtherName. >> >> It also fix several errors: >> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]` >> without the tag

Re: RFR: 8280409: JarFile::verifiableEntry can fail with NPE accessing ze.getName() [v3]

2022-02-11 Thread Alan Bateman
On Thu, 10 Feb 2022 21:35:56 GMT, Lance Andersen wrote: >> Hi all, >> >> Please review the attached patch to address >> >> - That JarFile::getInputStream did not check for a null ZipEntry passed as a >> parameter >> - Have Zip/JarFile::getInputStream throw a ZipException in the event that an

Re: RFR: 8281585: Remove unused imports under test/lib and jtreg/gc [v2]

2022-02-11 Thread David Holmes
On Fri, 11 Feb 2022 08:54:51 GMT, Leo Korinth wrote: >> Remove unused imports under test/lib and jtreg/gc. They create lots of >> warnings if editing using an IDE. Tests in hotspot_gc passed. > > Leo Korinth has updated the pull request incrementally with one additional > commit since the last

Re: RFR: JDK-8061729 : Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs [v5]

2022-02-11 Thread Mahendra Chhipa
> There are some regression tests depending on sun.net.www.MessageHeader, the > internal API dependency should be removed. Some of other internal API > dependancies are removed in following issues : > JDK-8273142 > JDK-8268464 > JDK-8268133 Mahendra Chhipa has updated the pull request

Re: RFR: 8281585: Remove unused imports under test/lib and jtreg/gc [v2]

2022-02-11 Thread Serguei Spitsyn
On Fri, 11 Feb 2022 08:54:51 GMT, Leo Korinth wrote: >> Remove unused imports under test/lib and jtreg/gc. They create lots of >> warnings if editing using an IDE. Tests in hotspot_gc passed. > > Leo Korinth has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake

2022-02-11 Thread Alexey Bakhtin
On Thu, 10 Feb 2022 23:59:40 GMT, Xue-Lei Andrew Fan wrote: >> Please review the patch for the JDK-8274524 >> >> SSLSocket.close() could cause an intermittent hang of the socket read >> operation. It happens in case of SO_TIMEOUT is set to 0 (infinite timeout). >> SSLSocket.close() reads from

Re: RFR: 8281585: Remove unused imports under test/lib and jtreg/gc [v2]

2022-02-11 Thread Leo Korinth
On Fri, 11 Feb 2022 08:54:51 GMT, Leo Korinth wrote: >> Remove unused imports under test/lib and jtreg/gc. They create lots of >> warnings if editing using an IDE. Tests in hotspot_gc passed. > > Leo Korinth has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8281585: Remove unused imports under test/lib and jtreg/gc [v2]

2022-02-11 Thread Leo Korinth
> Remove unused imports under test/lib and jtreg/gc. They create lots of > warnings if editing using an IDE. Tests in hotspot_gc passed. Leo Korinth has updated the pull request incrementally with one additional commit since the last revision: updating copyright - Changes: -