On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
This PR changes a comment in javax/swing/RepaintManager.java. This commented
out code should be removed altogether in another P
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Nice, good work matteo
Should I change the JBS issue title to match the PR title, or is it preferred
for the PR title to chang
On Fri, 4 Mar 2022 15:39:56 GMT, Sean Mullan wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8282632: Cleanup unnecessary calls to Throwable.initCause() in
>> java.security.jgss
>> typo
>
> src/java.security.
> Pass cause exception as constructor parameter is shorter and easier to read.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8282632: Cleanup unnecessary calls to Throwable.initCause() in
java.security.jgss
typo
-
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
I eyeballed the diff file and all seems okay.
Thanks,
David
-
Marked as reviewed by dholmes (Reviewer).
PR: http
On 3/2/2022 11:46 PM, xueleifan(XueleiFan) wrote:
I think you are right that this design is actually for TLSv1.3 half-close mode.
For TLS 1.3, there is no duplex closure design. The close() implementation
in JDK is actually a workaround for compatibility. Application can use either
the
On Thu, 3 Mar 2022 12:36:33 GMT, zzambers wrote:
>> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was
>> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() /
>> Socket.shutdownOutput() and InputStream.close() / OutputStream.close()
>> performed hal
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7268
Please review this small API enhancement to add the usual constructors taking a
cause to SocketException and then update uses of initiCause on creating
SocketException to instead pass the cause via the constructor.
Please also review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282688
---
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
LGTM also.
Similar suggestion for updating copyrights.
-
Marked as reviewed by wetmore (Reviewer).
PR: https:/
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Nice tidy of the code.
Is there anything that can be done to prevent re-introduction of this trivial
problem? Perhaps a new S
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7268
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Marked as reviewed by prr (Reviewer).
Looks like there's only one client source code file touched
Most of the client changes a
On Fri, 4 Mar 2022 14:59:54 GMT, Sean Mullan wrote:
> Please review this change to fully support RFC 6125 in the TLS
> implementation. This change forbids wildcard domains in TLS certificates
> unless the wildcard is in the left-most component. Certificates of this
> nature should be rare and
On Fri, 4 Mar 2022 17:17:12 GMT, Roger Riggs wrote:
>> Hi
>>
>> I have reviewed the code for removing double semicolons at the end of lines
>>
>> all the best
>> matteo
>
> We usually request that these be be broken up by area to attract the
> appropriate reviewers and avoid eye-strain. The c
On Fri, 4 Mar 2022 16:48:47 GMT, Sean Mullan wrote:
> > About the CSR, did you have a plan to update the "Endpoint Identification
> > Algorithms" in the [Java Security Standard Algorithm
> > Names](https://docs.oracle.com/en/java/javase/17/docs/specs/security/standard-names.html#endpoint-identi
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
We usually request that these be be broken up by area to attract the
appropriate reviewers and avoid eye-strain. The client mo
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Hi Lance
I can make a second commit updating the copyright year
Tell me if this is necessary
ciao
matteo
-
PR:
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
The changes look OK. The copyright year probably should be updated as part of
this PR
-
Marked as reviewed by la
On Fri, 25 Feb 2022 15:40:09 GMT, Matteo Baccan wrote:
>> Hi
>>
>> I have reviewed the code for removing double semicolons at the end of lines
>>
>> all the best
>> matteo
>
> Hi
>
> I have pushed this PR about 1 month ago. Only 3 days ago OCA was accepted.
> Now: what is the next step?
>
> T
Hi
I have reviewed the code for removing double semicolons at the end of lines
all the best
matteo
-
Commit messages:
- Removed double semicolon at the end of lines
Changes: https://git.openjdk.java.net/jdk/pull/7268/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=726
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Hi
I have pushed this PR about 1 month ago. Only 3 days ago OCA was accepted.
Now: what is the next step?
This is a cleanup PR
On Fri, 4 Mar 2022 16:33:45 GMT, Xue-Lei Andrew Fan wrote:
> About the CSR, did you have a plan to update the "Endpoint Identification
> Algorithms" in the [Java Security Standard Algorithm
> Names](https://docs.oracle.com/en/java/javase/17/docs/specs/security/standard-names.html#endpoint-ident
On Fri, 4 Mar 2022 14:59:54 GMT, Sean Mullan wrote:
> Please review this change to fully support RFC 6125 in the TLS
> implementation. This change forbids wildcard domains in TLS certificates
> unless the wildcard is in the left-most component. Certificates of this
> nature should be rare and
On Thu, 17 Feb 2022 18:57:02 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-
On Thu, 3 Mar 2022 19:33:21 GMT, Andrey Turbanov wrote:
> Pass cause exception as constructor parameter is shorter and easier to read.
src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/ArcFourCrypto.java
line 161:
> 159:Ksign = getHmac(baseKey, new_ss);
> 16
Please review this change to fully support RFC 6125 in the TLS implementation.
This change forbids wildcard domains in TLS certificates unless the wildcard is
in the left-most component. Certificates of this nature should be rare and are
not allowed per the CABForum baseline requirements. Howeve
On Thu, 3 Mar 2022 19:33:21 GMT, Andrey Turbanov wrote:
> Pass cause exception as constructor parameter is shorter and easier to read.
LGTM
-
Marked as reviewed by stsypa...@github.com (no known OpenJDK username).
PR: https://git.openjdk.java.net/jdk/pull/7682
28 matches
Mail list logo
