On Thu, 7 Apr 2022 01:16:32 GMT, Naoto Sato wrote:
>> test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 63:
>>
>>> 61: Locale.of("it", "IT", "EURO"),
>>> 62: Locale.forLanguageTag("de-AT"),
>>> 63: Locale.forLanguageTag("fr-CH"),
>>
>> Use the
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Thu, 7 Apr 2022 01:16:27 GMT, Naoto Sato wrote:
>> test/jdk/java/text/Format/DateFormat/DateFormatRoundTripTest.java line 81:
>>
>>> 79:
>>> 80: /**
>>> 81: * Parse a name like "fr_FR" into Locale.of("fr", "FR", "");
>>
>> Locale.France?
>
> The test code parses the input string
Please review the update to remove finalizer method in the java.security.jgss
module. It is one of the efforts to clean up the use of finalizer method in JDK.
-
Commit messages:
- 8284490: Remove finalizer method in java.security.jgss
Changes:
On Thu, 7 Apr 2022 00:09:58 GMT, Joe Wang wrote:
>> This is a follow-on task after deprecating the Locale constructors
>> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
>> simple replacements to Locale constructors with `Locale.of()` or Locale
>> constants, such
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Fri, 1 Apr 2022 07:32:21 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try'
> statement`
Other that the 1
On Fri, 1 Apr 2022 07:32:21 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try'
> statement`
I think changing
On Wed, 6 Apr 2022 16:00:10 GMT, Xue-Lei Andrew Fan wrote:
>> Anyone can help review this javadoc update? The main change is the wording
>> for the method javadoc of
>> Cipher.getParameters()/CipherSpi.engineGetParameters(). The original wording
>> is somewhat restrictive and request is to
On Wed, 6 Apr 2022 19:17:38 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/javax/crypto/Cipher.java line 1051:
>>
>>> 1049: * Returns the parameters used with this cipher.
>>> 1050: *
>>> 1051: * If this cipher has been previously initialized with
>>> parameters,
>>
Thanks for responding Peter, I've commented inline below.
On Tue, Apr 5, 2022 at 8:19 PM Peter Firmstone
wrote:
>
> Thanks David,
>
> I'd certainly support such a proposal and encourage OpenJDK to consider
> exploring it.
>
> Perhaps also consider; no privileges should be granted unless a
>
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Wed, 6 Apr 2022 15:48:26 GMT, Xue-Lei Andrew Fan wrote:
>> Anyone can help review this javadoc update? The main change is the wording
>> for the method javadoc of
>> Cipher.getParameters()/CipherSpi.engineGetParameters(). The original wording
>> is somewhat restrictive and request is to
I think it is a good point, Mike. Some of the exception constructors do not
accept cause parameters, for example UnrecoverableKeyException. And some
others do, for example InvalidKeyException. I would like to keep original
cause. I read this patch as a format clean-up. It is fine to me to
This is a follow-on task after deprecating the Locale constructors
(https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
simple replacements to Locale constructors with `Locale.of()` or Locale
constants, such as `Locale.US`.
-
Commit messages:
- 8283698:
Before you approve this, why would you rethrow just the message rather than the
actual original cause? Seems like you’re losing debug info including the type
of the original exception for no good reason.
Mike
Sent from my iPad
> On Apr 6, 2022, at 11:26, Xue-Lei Andrew Fan wrote:
>
> On
On Tue, 5 Apr 2022 19:55:55 GMT, Xue-Lei Andrew Fan wrote:
> Please review the update to remove finalizer method in the
> jdk.crypto.cryptoki module. It is one of the efforts to clean up the use of
> finalizer method in JDK.
This pull request has now been integrated.
Changeset: 77388eaf
On Wed, 6 Apr 2022 00:14:04 GMT, Valerie Peng wrote:
> Anyone can help review this javadoc update? The main change is the wording
> for the method javadoc of
> Cipher.getParameters()/CipherSpi.engineGetParameters(). The original wording
> is somewhat restrictive and request is to broaden this
On Fri, 1 Apr 2022 07:32:21 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try'
> statement`
Looks good to me.
On Fri, 1 Apr 2022 07:32:21 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try'
> statement`
Looks fine!
On Tue, 5 Apr 2022 10:27:54 GMT, Mahendra Chhipa wrote:
> Updated java/net and sun/net/www tests to remove dependency on
> sun.net.www.MessageHeader.
Looks reasonable to me, but please make sure the tests are stable before
pushing. The proxy/tunnel classes have exhibited some instability in
Let's take advantage of Java 7 language feature - "Catching Multiple Exception
Types".
It simplifies code. Reduces duplication.
Found by IntelliJ IDEA inspection `Identical 'catch' branches in 'try'
statement`
-
Commit messages:
- [PATCH] Collapse identical catch branches in
24 matches
Mail list logo
