On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
On Thu, 7 Apr 2022 20:17:28 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
> All `IntegerPolynimial`s are singletons now. Also, hand-coded implementations
> for Ed25519 and Ed448 are removed. They were not used since `FieldGen` starts
> generating classes for them.
>
> No new regression test. This is a clean-up.
Weijun Wang has updated the pull request incrementally
All `IntegerPolynimial`s are singletons now. Also, hand-coded implementations
for Ed25519 and Ed448 are removed. They were not used since `FieldGen` starts
generating classes for them.
No new regression test. This is a clean-up.
-
Commit messages:
- the fix
Changes:
On Fri, 29 Apr 2022 20:47:08 GMT, Sean Mullan wrote:
>> The reason I added the last sentence is because this property has no value.
>> Someone might think they can set it to false to disable it, but that is
>> equivalent to set it to true.
>
> Ah I see. Maybe put in the previous sentence, ex:
> We added a new system property back in
> https://bugs.openjdk.java.net/browse/JDK-8153005 but it's better to describe
> it in the `java.security` file as well.
>
> Please review the text. I especially added the last sentence so that people
> won't set `-Dkeystore.pkcs12.legacy=false`.
On Fri, 29 Apr 2022 20:40:46 GMT, Weijun Wang wrote:
>> It's a little long, but I can see why it is useful, so I think it's good. I
>> would avoid the word "new" as this won't be new in a few years time. Here is
>> an edit where I removed words which I thought were not essential:
>>
>>> Some
On Fri, 29 Apr 2022 20:35:14 GMT, Sean Mullan wrote:
>> Can we say both? All these properties are only used when creating the file
>> (key-related ones when creating the key). If a compatibility issue already
>> happens, users need to downgrade their keystore.
>>
>> So, the full text will be
On Fri, 29 Apr 2022 13:28:11 GMT, Weijun Wang wrote:
>> I think the text above might still make some users concerned that they
>> should always set this property.
>> Maybe we can be less specific, and just say: "If you encounter compatibility
>> issues with software that doesn't support the
On Fri, 29 Apr 2022 19:18:06 GMT, Sean Mullan wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed RC2 changes
>
> src/java.base/share/conf/security/java.security line 644:
>
>> 642: #
>> 643: # In some
> Please review these changes to add DES/3DES/MD5 to
> `jdk.security.legacyAlgorithms` security property, and to add the legacy
> algorithm constraint checking to `keytool` commands that are associated with
> secret key entries stored in the keystore. These `keytool` commands are
> -genseckey,
Hi,
I need a review of this fix to allow a read-only 'src' buffer to be used with
SSLEngine.unwrap(). A temporary read-write buffer is created in the SSLCipher
operation when a read-only buffer is passed. If the 'src' is read-write, there
is no effect on the current operation
The PR also
On Fri, 29 Apr 2022 17:06:28 GMT, Hai-May Chao wrote:
>> Please review these changes to add DES/3DES/MD5 to
>> `jdk.security.legacyAlgorithms` security property, and to add the legacy
>> algorithm constraint checking to `keytool` commands that are associated with
>> secret key entries stored
On Fri, 29 Apr 2022 09:03:58 GMT, Pavel Rappo wrote:
> * Syntactically improves a few cases from 8285676
> (https://github.com/openjdk/jdk/pull/8410)
> * Fixes a few misspelled `@param` tags for elements that, although are not
> included in the API Documentation, are visible in and processed
Hello.
I found a suspicious code in CryptoPolicyParser method calls.
Method 'isConsistent' is called only from a method
'parsePermissionEntry'. It accepts the 'processedPermissions'
parameter from 'parsePermissionEntry'.
Method 'parsePermissionEntry' is called only from a method
> Please review these changes to add DES/3DES/MD5 to
> `jdk.security.legacyAlgorithms` security property, and to add the legacy
> algorithm constraint checking to `keytool` commands that are associated with
> secret key entries stored in the keystore. These `keytool` commands are
> -genseckey,
> Please review these changes to add DES/3DES/MD5 to
> `jdk.security.legacyAlgorithms` security property, and to add the legacy
> algorithm constraint checking to `keytool` commands that are associated with
> secret key entries stored in the keystore. These `keytool` commands are
> -genseckey,
On Fri, 29 Apr 2022 09:03:58 GMT, Pavel Rappo wrote:
> * Syntactically improves a few cases from 8285676
> (https://github.com/openjdk/jdk/pull/8410)
> * Fixes a few misspelled `@param` tags for elements that, although are not
> included in the API Documentation, are visible in and processed
On Fri, 29 Apr 2022 09:03:58 GMT, Pavel Rappo wrote:
> * Syntactically improves a few cases from 8285676
> (https://github.com/openjdk/jdk/pull/8410)
> * Fixes a few misspelled `@param` tags for elements that, although are not
> included in the API Documentation, are visible in and processed
On Thu, 28 Apr 2022 19:11:23 GMT, Valerie Peng wrote:
>> Anyone can help review this javadoc update? The main change is the wording
>> for the method javadoc of
>> Cipher.getParameters()/CipherSpi.engineGetParameters(). The original wording
>> is somewhat restrictive and request is to broaden
On Fri, 29 Apr 2022 13:17:55 GMT, Sean Mullan wrote:
>> How about this?
>>
>> To work with legacy PKCS #12 tools that does not support the new algorithms,
>> the system property "keystore.pkcs12.legacy" can be set
>> which will override the properties defined here with old settings.
>> This
On Thu, 28 Apr 2022 23:20:18 GMT, Weijun Wang wrote:
>> But isn't it mostly an issue when creating new keystores and not reading
>> existing ones? I would want to avoid users thinking that they had to set
>> this in more cases than needed.
>
> How about this?
>
> To work with legacy PKCS #12
On Fri, 29 Apr 2022 09:03:58 GMT, Pavel Rappo wrote:
> * Syntactically improves a few cases from 8285676
> (https://github.com/openjdk/jdk/pull/8410)
> * Fixes a few misspelled `@param` tags for elements that, although are not
> included in the API Documentation, are visible in and processed
On Mon, 18 Apr 2022 13:35:25 GMT, Sean Mullan wrote:
> This change improves the specification for the case when a
> `PKIXRevocationChecker` is supplied as one of the `CertPathChecker`
> parameters. Specifically, it makes it more clear that a
> `PKIXRevocationChecker` overrides the default
On Fri, 29 Apr 2022 09:03:58 GMT, Pavel Rappo wrote:
> * Syntactically improves a few cases from 8285676
> (https://github.com/openjdk/jdk/pull/8410)
> * Fixes a few misspelled `@param` tags for elements that, although are not
> included in the API Documentation, are visible in and processed
* Syntactically improves a few cases from 8285676
(https://github.com/openjdk/jdk/pull/8410)
* Fixes a few misspelled `@param` tags for elements that, although are not
included in the API Documentation, are visible in and processed by IDEs
-
Commit messages:
- Fix misspelled
On Fri, 29 Apr 2022 08:45:42 GMT, Pavel Rappo wrote:
> Good catch. Sorry I missed it. This occurs in all `java/lang/ref` files.
I've created a PR; feel free to review it at your convenience.
-
PR: https://git.openjdk.java.net/jdk/pull/8410
On Thu, 28 Apr 2022 19:06:04 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/ref/PhantomReference.java line 48:
>>
>>> 46: * The {@link #refersTo(Object) refersTo} method can be used to test
>>> 47: * whether some object is the referent of a phantom reference.
>>> 48: *
28 matches
Mail list logo
