Re: RFR: 8284926: Share the certificate NamedGroup in SignatureScheme::getSignerOfPreferableAlgorithm [v2]

2022-05-16 Thread Xue-Lei Andrew Fan
On Mon, 18 Apr 2022 12:37:15 GMT, John Jiang wrote: >> It would not to generate the certificate's ECParameterSpec and NamedGroup >> multiple times in method `SignatureScheme::getSignerOfPreferableAlgorithm`. > > John Jiang has updated the pull request incrementally with one additional > commit

Integrated: JDK-6782021: It is not possible to read local computer certificates with the SunMSCAPI provider

2022-05-16 Thread Mat Carter
On Tue, 12 Apr 2022 19:03:40 GMT, Mat Carter wrote: > On Windows you can now access the local machine keystores using the strings > "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the > application requires admin privileges. > > "Windows-MY" and "Windows-ROOT" remain unchanged,

Re: RFR: JDK-6782021: It is not possible to read local computer certificates with the SunMSCAPI provider [v6]

2022-05-16 Thread Weijun Wang
On Wed, 11 May 2022 16:01:39 GMT, Mat Carter wrote: >> On Windows you can now access the local machine keystores using the strings >> "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the >> application requires admin privileges. >> >> "Windows-MY" and "Windows-ROOT" remain uncha

Re: RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v7]

2022-05-16 Thread Valerie Peng
On Mon, 16 May 2022 13:28:13 GMT, Sean Mullan wrote: >> With this modification of 2nd sentence. The whole paragraph becomes: >> >> * The returned parameters may be the same that were used to >> initialize >> * this signature, or may contain additional default or random parameter >>

Re: RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v8]

2022-05-16 Thread Valerie Peng
> This is to update the method javadoc of > java.security.Signature.getParameters() with the missing `@throws > UnsupportedOperationException`. In addition, the wording on the returned > parameters are updated to match those in Cipher and CipherSpi classes. > > CSR will be filed later. > > Th

Re: RFR: 8283577: SSLEngine.unwrap on read-only input ByteBuffer [v2]

2022-05-16 Thread Xue-Lei Andrew Fan
On Mon, 16 May 2022 21:08:48 GMT, Anthony Scarpino wrote: > There is too much grey area. It says the src buffer maybe modified, which one > could interpret it cannot be a read-only, but that would still need > clarification to explicitly say "no read only buffers". And other than these > inte

Re: RFR: 8283577: SSLEngine.unwrap on read-only input ByteBuffer [v2]

2022-05-16 Thread Anthony Scarpino
On Sat, 14 May 2022 03:29:14 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review of this fix to allow a read-only 'src' buffer to be used >> with SSLEngine.unwrap(). A temporary read-write buffer is created in the >> SSLCipher operation when a read-only buffer is passed. If the 'src' is

Re: RFR: 8286715: Generalize MemorySegment::ofBuffer [v2]

2022-05-16 Thread Maurizio Cimadamore
> This patch makes MemorySegment::ofBuffer more general, by allowing clients to > pass *any* `Buffer` instance, not just `ByteBuffer`. > This allows us to match expressiveness of JNI API, where JNI clients can > obtain the address of any direct buffer instance, using the > `GetDirectBufferAddres

Re: RFR: JDK-6782021: It is not possible to read local computer certificates with the SunMSCAPI provider [v5]

2022-05-16 Thread Mat Carter
On Mon, 16 May 2022 16:59:02 GMT, Weijun Wang wrote: >> @christophbrejla - my goal is to backport to latest (18 or 19), 17 and 11 > > @macarte I think Sean's comment on your CSR about the scope is correct. The > "algorithm" name should be at the JDK level so user knows what to write in > their

Re: RFR: 8286090: Add RC2/RC4 to jdk.security.legacyAlgorithms

2022-05-16 Thread Sean Mullan
On Mon, 16 May 2022 12:59:09 GMT, Sean Mullan wrote: >> Please review the small change to add RC2 and ARCFOUR to >> jdk.security.legacyAlgorithms. So it enables keytool -genseckey, -list, and >> -importkeystore commands to warn users when RC2 or ARCFOUR algorithm is used. > > test/jdk/sun/secur

Re: RFR: 8286090: Add RC2/RC4 to jdk.security.legacyAlgorithms

2022-05-16 Thread Sean Mullan
On Sat, 14 May 2022 01:51:34 GMT, Hai-May Chao wrote: > Please review the small change to add RC2 and ARCFOUR to > jdk.security.legacyAlgorithms. So it enables keytool -genseckey, -list, and > -importkeystore commands to warn users when RC2 or ARCFOUR algorithm is used. Marked as reviewed by m

Re: RFR: JDK-6782021: It is not possible to read local computer certificates with the SunMSCAPI provider [v5]

2022-05-16 Thread Weijun Wang
On Wed, 11 May 2022 15:55:40 GMT, Mat Carter wrote: >> Mat Carter has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add test from wangweij > > @christophbrejla - my goal is to backport to latest (18 or 19), 17 and 11 @macarte I think Sean

Re: RFR: 8286715: Generalize MemorySegment::ofBuffer

2022-05-16 Thread Jorn Vernee
On Fri, 13 May 2022 12:33:10 GMT, Maurizio Cimadamore wrote: > This patch makes MemorySegment::ofBuffer more general, by allowing clients to > pass *any* `Buffer` instance, not just `ByteBuffer`. > This allows us to match expressiveness of JNI API, where JNI clients can > obtain the address of

Re: RFR: 8282662: Use List.of() factory method to reduce memory consumption [v3]

2022-05-16 Thread Сергей Цыпанов
On Fri, 13 May 2022 13:36:52 GMT, ExE Boss wrote: > So if anything, the List.of(…) call should be moved into the ProxyMethod > constructor. And maybe the call to Method.getExceptionTypes() should be > changed to Method.getSharedExceptionTypes() Makes sense. Do you want me to do this within thi

Re: RFR: 8253176: Signature.getParameters should specify that it can throw UnsupportedOperationException [v7]

2022-05-16 Thread Sean Mullan
On Fri, 13 May 2022 20:58:16 GMT, Valerie Peng wrote: >> src/java.base/share/classes/java/security/Signature.java line 1012: >> >>> 1010: * values used by the underlying signature scheme. If the required >>> 1011: * parameters were not supplied and can be generated by the >>> signatur

Re: RFR: 8286090: Add RC2/RC4 to jdk.security.legacyAlgorithms

2022-05-16 Thread Sean Mullan
On Sat, 14 May 2022 01:51:34 GMT, Hai-May Chao wrote: > Please review the small change to add RC2 and ARCFOUR to > jdk.security.legacyAlgorithms. So it enables keytool -genseckey, -list, and > -importkeystore commands to warn users when RC2 or ARCFOUR algorithm is used. test/jdk/sun/security/t