On Mon, 18 Apr 2022 12:37:15 GMT, John Jiang wrote:
>> It would not to generate the certificate's ECParameterSpec and NamedGroup
>> multiple times in method `SignatureScheme::getSignerOfPreferableAlgorithm`.
>
> John Jiang has updated the pull request incrementally with one additional
> commit
> It would not to generate the certificate's ECParameterSpec and NamedGroup
> multiple times in method `SignatureScheme::getSignerOfPreferableAlgorithm`.
John Jiang has updated the pull request incrementally with one additional
commit since the last revision:
add some comments
-
On Wed, 6 Apr 2022 00:14:04 GMT, Valerie Peng wrote:
> Anyone can help review this javadoc update? The main change is the wording
> for the method javadoc of
> Cipher.getParameters()/CipherSpi.engineGetParameters(). The original wording
> is somewhat restrictive and request is to broaden this
On Thu, 12 May 2022 22:52:59 GMT, Valerie Peng wrote:
>> This change refactors the PBES2Core and PKCS12PBECipherCore classes in
>> SunJCE provider as requested in the bug record. Functionality should remain
>> the same with a clearer and simplified code/control flow with less lines of
>> code.
Let ECDSA's `engineGetParameters()` always return null. At the same time,
remove the remembered `sigParams` field. One behavior change is that after
calling `setParameter()`, one can call `init()` again with a key using
different parameters. I think this should be allowed since we are reusing th
On Tue, 17 May 2022 19:56:22 GMT, Weijun Wang wrote:
> Let ECDSA's `engineGetParameters()` always return null. At the same time,
> remove the remembered `sigParams` field. One behavior change is that after
> calling `setParameter()`, one can call `init()` again with a key using
> different par
On Tue, 17 May 2022 20:27:41 GMT, Jamil Nimeh wrote:
> Do the behavioral changes you've cited in the PR description warrant a CSR,
> or do you feel this behavioral change is still consistent with the current
> Signature API documentation?
I think so. In fact, after this change, there's simply
On Tue, 3 May 2022 19:30:40 GMT, Valerie Peng wrote:
> This change refactors the PBES2Core and PKCS12PBECipherCore classes in SunJCE
> provider as requested in the bug record. Functionality should remain the same
> with a clearer and simplified code/control flow with less lines of code.
> Thi
On Tue, 17 May 2022 19:56:22 GMT, Weijun Wang wrote:
> Let ECDSA's `engineGetParameters()` always return null. At the same time,
> remove the remembered `sigParams` field. One behavior change is that after
> calling `setParameter()`, one can call `init()` again with a key using
> different par
On Sat, 14 May 2022 03:29:14 GMT, Anthony Scarpino
wrote:
>> Hi,
>>
>> I need a review of this fix to allow a read-only 'src' buffer to be used
>> with SSLEngine.unwrap(). A temporary read-write buffer is created in the
>> SSLCipher operation when a read-only buffer is passed. If the 'src' is
On Fri, 29 Apr 2022 03:58:57 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a review of this fix to allow a read-only 'src' buffer to be used with
> SSLEngine.unwrap(). A temporary read-write buffer is created in the SSLCipher
> operation when a read-only buffer is passed. If the 'src' is read
On Mon, 16 May 2022 17:17:24 GMT, Sean Mullan wrote:
>> Please review the small change to add RC2 and ARCFOUR to
>> jdk.security.legacyAlgorithms. So it enables keytool -genseckey, -list, and
>> -importkeystore commands to warn users when RC2 or ARCFOUR algorithm is used.
>
> Marked as reviewed
On Sat, 14 May 2022 01:51:34 GMT, Hai-May Chao wrote:
> Please review the small change to add RC2 and ARCFOUR to
> jdk.security.legacyAlgorithms. So it enables keytool -genseckey, -list, and
> -importkeystore commands to warn users when RC2 or ARCFOUR algorithm is used.
This pull request has n
> This is to update the method javadoc of
> java.security.Signature.getParameters() with the missing `@throws
> UnsupportedOperationException`. In addition, the wording on the returned
> parameters are updated to match those in Cipher and CipherSpi classes.
>
> CSR will be filed later.
>
> Th
On Tue, 17 May 2022 19:56:22 GMT, Weijun Wang wrote:
> Let ECDSA's `engineGetParameters()` always return null. At the same time,
> remove the remembered `sigParams` field. One behavior change is that after
> calling `setParameter()`, one can call `init()` again with a key using
> different par
On Tue, 17 May 2022 22:22:36 GMT, Valerie Peng wrote:
>> This is to update the method javadoc of
>> java.security.Signature.getParameters() with the missing `@throws
>> UnsupportedOperationException`. In addition, the wording on the returned
>> parameters are updated to match those in Cipher a
> https://bugs.openjdk.java.net/browse/JDK-8284688
>
> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the
> umbrella bug for this bug. The changes were too large for a single code
> review, so it was decided to split into smaller chunks. This is one such
> chunk:
>
> open/
17 matches
Mail list logo
