Re: RFR: JDK-8285263 Minor cleanup could be done in java.security [v4]

2022-05-25 Thread Mark Powers
> https://bugs.openjdk.java.net/browse/JDK-8285263 Minor cleanup could be done > in java.security > > JDK-8273046 is the umbrella bug for this bug. The changes were too large for > a single code review, so it was decided to split into smaller chunks. This is > one such chunk: > > open/src/jav

Re: RFR: 8286045: Use ForceGC for cleaner test cases

2022-05-25 Thread Xue-Lei Andrew Fan
On Wed, 25 May 2022 17:23:06 GMT, Roger Riggs wrote: > (But ForceGC is a heavyweight blunt instrument. It creates a new Cleaner for > every instance and an instance can only be used once. Also, its minimum > wait/sleep time is 1 second, that's a lng time.). I thought about something simila

Re: RFR: 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider [v2]

2022-05-25 Thread Sean Mullan
> Please review this fix to the XML Signature implementation to check for null > or missing DSA parameters and throw a MarshalException before trying to > create a DSA public key from its XML encoding. This will allow the code to > fail earlier and not depend on the underlying provider to detect

Re: RFR: 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider

2022-05-25 Thread Weijun Wang
On Tue, 24 May 2022 16:29:02 GMT, Sean Mullan wrote: > Please review this fix to the XML Signature implementation to check for null > or missing DSA parameters and throw a MarshalException before trying to > create a DSA public key from its XML encoding. This will allow the code to > fail earl

Re: RFR: 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider

2022-05-25 Thread Weijun Wang
On Tue, 24 May 2022 16:29:02 GMT, Sean Mullan wrote: > Please review this fix to the XML Signature implementation to check for null > or missing DSA parameters and throw a MarshalException before trying to > create a DSA public key from its XML encoding. This will allow the code to > fail earl

Re: RFR: 8286045: Use ForceGC for cleaner test cases

2022-05-25 Thread Roger Riggs
On Wed, 25 May 2022 15:20:45 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > May I have the test case update reviewed? > > This patch is trying to use ForceGC for cleaner test cases. As would make > the test more stable and easier to maintain. > > Thanks, > Xuelei The usage looks fine. (But Force

RFR: 8286045: Use ForceGC for cleaner test cases

2022-05-25 Thread Xue-Lei Andrew Fan
Hi, May I have the test case update reviewed? This patch is trying to use ForceGC for cleaner test cases. As would make the test more stable and easier to maintain. Thanks, Xuelei - Commit messages: - 8286045: Use ForceGC for cleaner test cases Changes: https://git.openjdk.java