> This PR resolves: https://bugs.openjdk.org/browse/JDK-8267860
Kevin Driver has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains three additional commits si
On Fri, 10 Jun 2022 17:12:30 GMT, Kevin Driver wrote:
> This PR resolves: https://bugs.openjdk.org/browse/JDK-8267860
LGTM.
test/jdk/sun/security/ssl/ALPN/AlpnGreaseTest.java line 86:
> 84:
> 85: private static void findGreaseInClientHello(byte[] bytes) throws
> Exception {
> 86:
This PR resolves: https://bugs.openjdk.org/browse/JDK-8267860
-
Commit messages:
- Update AlpnGreaseTest.java
- JDK-8267860: off-by-one error
Changes: https://git.openjdk.org/jdk/pull/9131/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9131&range=00
Issue: https://b
On Fri, 10 Jun 2022 17:12:30 GMT, Kevin Driver wrote:
> This PR resolves: https://bugs.openjdk.org/browse/JDK-8267860
Sorry for the noisy comment section... I was just trying to trigger jcheck. It
looks to have been triggered.
-
PR: https://git.openjdk.org/jdk/pull/9131
On Fri, 10 Jun 2022 21:27:58 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285263 Minor cleanup could be done
>> in java.security
>>
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
>> a single code review, so it was decided to split into s
On Fri, 10 Jun 2022 23:49:45 GMT, Hai-May Chao wrote:
> Please review the small fix in comment.
This pull request has now been integrated.
Changeset: f7a4be75
Author:Hai-May Chao
URL:
https://git.openjdk.org/jdk/commit/f7a4be75fbe9e703dea94459285c72094d4d8646
Stats: 1 line in 1
On Fri, 10 Jun 2022 23:53:37 GMT, Jie Fu wrote:
>> Please review the small fix in comment.
>
> Looks good and trivial.
> Thanks.
@DamonFool @wangweij Thanks for the review!
-
PR: https://git.openjdk.org/jdk/pull/9135
Please review the small fix in comment.
-
Commit messages:
- 8288270: Tier1 build failures after JDK-8287178
Changes: https://git.openjdk.org/jdk/pull/9135/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9135&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8288270
On Fri, 10 Jun 2022 23:49:45 GMT, Hai-May Chao wrote:
> Please review the small fix in comment.
Looks good and trivial.
Thanks.
-
Marked as reviewed by jiefu (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9135
On Fri, 10 Jun 2022 23:49:45 GMT, Hai-May Chao wrote:
> Please review the small fix in comment.
LGTM. Thanks.
-
Marked as reviewed by weijun (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9135
On Fri, 10 Jun 2022 21:27:58 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285263 Minor cleanup could be done
>> in java.security
>>
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
>> a single code review, so it was decided to split into s
On Fri, 10 Jun 2022 21:41:50 GMT, Hai-May Chao wrote:
>> Please review a small fix in CryptoPolicyParser class that it should not
>> pass “processedPermissions” parameter by value.
>> Ran MACH5 tier1 and tier2 without failures.
>
> Hai-May Chao has updated the pull request incrementally with one
On Fri, 10 Jun 2022 21:44:16 GMT, Weijun Wang wrote:
>> A privilegedGetProperty method? That would be the subject of a new bug I
>> think.
>
> Yes.
JDK-8288271 has been created
-
PR: https://git.openjdk.org/jdk/pull/8319
On Thu, 9 Jun 2022 21:34:56 GMT, Weijun Wang wrote:
> Add comment to the method.
This pull request has now been integrated.
Changeset: d4b473d8
Author:Weijun Wang
URL:
https://git.openjdk.org/jdk/commit/d4b473d89046874f25aa6f65f3ae96f7d8397d50
Stats: 8 lines in 1 file changed: 7
On Fri, 10 Jun 2022 00:35:16 GMT, Mark Powers wrote:
>> src/java.base/share/classes/java/security/SecureRandom.java line 905:
>>
>>> 903: private static final Pattern pattern =
>>> 904: Pattern.compile(
>>> 905: "\\s*([\\S&&[^:,]]*)(:([\\S&&[^,]]*))?\\s*(,(.*)
On Fri, 10 Jun 2022 21:27:58 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285263 Minor cleanup could be done
>> in java.security
>>
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
>> a single code review, so it was decided to split into s
On Fri, 10 Jun 2022 17:31:56 GMT, Rajan Halade wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed copyright
>
> test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java line 38:
>
>> 36: import java.sec
> Please review a small fix in CryptoPolicyParser class that it should not pass
> “processedPermissions” parameter by value.
> Ran MACH5 tier1 and tier2 without failures.
Hai-May Chao has updated the pull request incrementally with one additional
commit since the last revision:
Manual test in
> https://bugs.openjdk.java.net/browse/JDK-8285263 Minor cleanup could be done
> in java.security
>
> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
> a single code review, so it was decided to split into smaller chunks. This is
> one such chunk:
>
> open/src/jav
On Wed, 8 Jun 2022 16:01:48 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 11 commits:
>>
>> - Merge
>> - fourth iteration
>> - Merge
>> - Merge
>> - third iteration
>> - Merge
>> - M
On Wed, 8 Jun 2022 16:06:12 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 11 commits:
>>
>> - Merge
>> - fourth iteration
>> - Merge
>> - Merge
>> - third iteration
>> - Merge
>> - M
On Wed, 8 Jun 2022 15:53:06 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 11 commits:
>>
>> - Merge
>> - fourth iteration
>> - Merge
>> - Merge
>> - third iteration
>> - Merge
>> - M
On Fri, 10 Jun 2022 12:16:17 GMT, Matthias Baesken wrote:
> When trying to construct an LdapURL object with a bad input string (in this
> example the _ in ad_jbs is causing issues), and not using
> the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we run
> into the exceptio
On Fri, 10 Jun 2022 16:19:05 GMT, Hai-May Chao wrote:
>> Please review a small fix in CryptoPolicyParser class that it should not
>> pass “processedPermissions” parameter by value.
>> Ran MACH5 tier1 and tier2 without failures.
>
> Hai-May Chao has updated the pull request incrementally with one
On Thu, 9 Jun 2022 00:33:27 GMT, Rajan Halade wrote:
> Updated with new test artifacts from CA.
This pull request has now been integrated.
Changeset: c6dd2ab9
Author:Rajan Halade
URL:
https://git.openjdk.org/jdk/commit/c6dd2ab9d72298b1e25ee811b1e200f6a0fdc933
Stats: 198 lines in
On Fri, 10 Jun 2022 15:09:58 GMT, Rajan Halade wrote:
>> Updated with new test artifacts from CA.
>
> Rajan Halade has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adjust hard wrap to 90 chars
Marked as reviewed by mullan (Reviewer).
-
> Please review a small fix in CryptoPolicyParser class that it should not pass
> “processedPermissions” parameter by value.
> Ran MACH5 tier1 and tier2 without failures.
Hai-May Chao has updated the pull request incrementally with one additional
commit since the last revision:
Fixed copyrigh
On Thu, 9 Jun 2022 22:54:20 GMT, Hai-May Chao wrote:
>> src/java.base/share/classes/javax/crypto/CryptoPolicyParser.java line 202:
>>
>>> 200: if (!processedPermissions.isEmpty()) {
>>> 201: throw new ParsingException(st.lineno(), "Inconsistent
>>> policy");
>>> 202:
On Tue, 7 Jun 2022 20:52:33 GMT, Hai-May Chao wrote:
>> Please review a small fix in CryptoPolicyParser class that it should not
>> pass “processedPermissions” parameter by value.
>> Ran MACH5 tier1 and tier2 without failures.
>
> Hai-May Chao has updated the pull request incrementally with two
> Updated with new test artifacts from CA.
Rajan Halade has updated the pull request incrementally with one additional
commit since the last revision:
Adjust hard wrap to 90 chars
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9097/files
- new: https://git.openjdk.org/jdk
On Thu, 9 Jun 2022 17:31:29 GMT, Rajan Halade wrote:
> Updated test artifacts. Test will continue to fail intermittently with what
> appears to be issue in CA infra. JDK-8277855 will track it.
This pull request has now been integrated.
Changeset: 3ee1e605
Author:Rajan Halade
URL:
h
> Updated test artifacts. Test will continue to fail intermittently with what
> appears to be issue in CA infra. JDK-8277855 will track it.
Rajan Halade has updated the pull request incrementally with one additional
commit since the last revision:
Adjust hard wrap to 90 chars
-
On Thu, 9 Jun 2022 18:59:36 GMT, Rajan Halade wrote:
> Updated test certificates to new from CA. I did a loop run of this test and
> don't see the intermittent failure anymore.
This pull request has now been integrated.
Changeset: 512db0ff
Author:Rajan Halade
URL:
https://git.openj
> Updated test certificates to new from CA. I did a loop run of this test and
> don't see the intermittent failure anymore.
Rajan Halade has updated the pull request incrementally with one additional
commit since the last revision:
adjust hard wrap to 90 chars
-
Changes:
- all
On Thu, 9 Jun 2022 17:31:29 GMT, Rajan Halade wrote:
> Updated test artifacts. Test will continue to fail intermittently with what
> appears to be issue in CA infra. JDK-8277855 will track it.
Marked as reviewed by mullan (Reviewer).
test/jdk/security/infra/java/security/cert/CertPathValidator
On Fri, 10 Jun 2022 12:16:17 GMT, Matthias Baesken wrote:
> When trying to construct an LdapURL object with a bad input string (in this
> example the _ in ad_jbs is causing issues), and not using
> the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we run
> into the exceptio
On Fri, 10 Jun 2022 13:41:48 GMT, Matthias Baesken wrote:
> Hi Alan , sure we could use something like the already existing hostInfo of
> property jdk.includeInException private static final boolean
> enhancedExceptionText = SecurityProperties.includedInExceptions("hostInfo");
> and make the e
On Fri, 10 Jun 2022 13:15:11 GMT, Alan Bateman wrote:
> We have to be cautious about leaking security sensitive configuration in
> exception messages. Can you look at the security property
> jdk.includeInException (conf/security/java.security) and usages in the JDK
> for ideas on how this migh
On Thu, 9 Jun 2022 18:59:36 GMT, Rajan Halade wrote:
> Updated test certificates to new from CA. I did a loop run of this test and
> don't see the intermittent failure anymore.
Marked as reviewed by mullan (Reviewer).
test/jdk/security/infra/java/security/cert/CertPathValidator/certification/A
On Fri, 10 Jun 2022 12:16:17 GMT, Matthias Baesken wrote:
> When trying to construct an LdapURL object with a bad input string (in this
> example the _ in ad_jbs is causing issues), and not using
> the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we run
> into the exceptio
On Sat, 28 May 2022 12:00:00 GMT, Andrey Turbanov wrote:
> Hashtable doesn't allow `null` values. So, instead of pair
> `containsKey`/`remove` calls, we can directly call `remove` and then compare
> result with `null`.
> https://github.com/openjdk/jdk/blob/2c461acfebd28fe5ef62805cbb004f91a3b18f
In NativeCreds.c there seems to be a redefined macro for EXIT_FAILURE (line
51)
#undef LSA_SUCCESS
#define LSA_SUCCESS(Status) ((Status) >= 0)
#define EXIT_FAILURE -1 // mdu <-
As far as I can see, it's a redundant definition not used anywhere other
than in a call to ExitProcess that's been c
42 matches
Mail list logo
