On Sat, 3 Apr 2021 22:09:55 GMT, Alex Blewitt
wrote:
> 8264681: Use the blessed modifier order in java.security
This pull request has now been integrated.
Changeset: ebbce91e
Author: Alex Blewitt
Committer: Aleksey Shipilev
URL: https://git.openjdk.java.net/jdk/commit/ebbce
On Mon, 12 Apr 2021 09:32:13 GMT, Alex Blewitt
wrote:
>> 8264681: Use the blessed modifier order in java.security
>
> Alex Blewitt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed upstream licensed code from co
On Mon, 12 Apr 2021 09:32:13 GMT, Alex Blewitt
wrote:
>> 8264681: Use the blessed modifier order in java.security
>
> Alex Blewitt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed upstream licensed code from co
> 8264681: Use the blessed modifier order in java.security
Alex Blewitt has updated the pull request incrementally with one additional
commit since the last revision:
Removed upstream licensed code from commit
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3338/fi
On Sat, 3 Apr 2021 22:09:55 GMT, Alex Blewitt
wrote:
> 8264681: Use the blessed modifier order in java.security
Sorry, thought those changes had been removed. Let me fix.
-
PR: https://git.openjdk.java.net/jdk/pull/3338
8264681: Use the blessed modifier order in java.security
-
Commit messages:
- 8264681: Use the blessed modifier order in java.security
Changes: https://git.openjdk.java.net/jdk/pull/3338/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3338&range=00
Issue: https://bugs
On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt
wrote:
> As with #2993 changing the order of `final static` to `static final` for the
> `java.management`, `java.management.rmi` and `java.naming` modules.
This pull request has now been integrated.
Changeset: 5262d95b
Author: Alex B
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt
wrote:
> Additional changes found in `java.base` of `final private` -> `private
> final`. Filed with existing bug because it's the same module; can change to a
> different bug number if required.
This pull request has no
On Thu, 18 Mar 2021 16:57:59 GMT, Alex Blewitt
wrote:
> Removed commented out value from `NTLMException`
This pull request has now been integrated.
Changeset: 6fa6557d
Author: Alex Blewitt
Committer: Claes Redestad
URL: https://git.openjdk.java.net/jdk/commit/6fa6557d
Stats:
Additional changes found in `java.base` of `final private` -> `private final`.
Filed with existing bug because it's the same module; can change to a different
bug number if required.
-
Commit messages:
- 8263658: Use the blessed modifier order in java.base
Changes: https://git.ope
> As with #2993 changing the order of `final static` to `static final` for the
> `java.management`, `java.management.rmi` and `java.naming` modules.
Alex Blewitt has updated the pull request incrementally with one additional
commit since the last revision:
Added more replacements of
On Fri, 19 Mar 2021 13:28:12 GMT, Claes Redestad wrote:
>> Thanks @cl4es -- do I need to update the git commit message as well, or is
>> updating the title of the PR sufficient? I recall you suggesting not to do
>> amend/rebases previously.
>
> No, the git commit messages here doesn't matter, t
On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt
wrote:
> As with #2993 changing the order of `final static` to `static final` for the
> `java.management`, `java.management.rmi` and `java.naming` modules.
Would someone mind creating a bug for me? In addition, if it would help, we
could
On Fri, 19 Mar 2021 11:01:45 GMT, Claes Redestad wrote:
>> @cl4es would you mind creating a parent task of something like "Source code
>> cleanups" and then another sub task for this change please?
>
> Created the subtask https://bugs.openjdk.java.net/browse/JDK-8263855 for this
> along with an
On Thu, 18 Mar 2021 19:33:59 GMT, Alex Blewitt
wrote:
>> As with #2993 changing the order of `final static` to `static final` for the
>> `java.management`, `java.management.rmi` and `java.naming` modules.
>
> Would someone mind creating a bug for me? In addition, if it would
As with #2993 changing the order of `final static` to `static final` for the
`java.management`, `java.management.rmi` and `java.naming` modules.
-
Commit messages:
- Use the blessed modifier order in java.management/naming
Changes: https://git.openjdk.java.net/jdk/pull/3078/files
On Sat, 13 Mar 2021 22:45:30 GMT, Alex Blewitt
wrote:
> Sonar displays a warning message that modifiers should be declared in the
> order listed in the JLS; specifically, that isntead of using `final static`
> the `static final` should be preferred.
>
> This fixes th
On Thu, 18 Mar 2021 16:57:59 GMT, Alex Blewitt
wrote:
> Removed commented out value from `NTLMException`
See commentary on #2993
-
PR: https://git.openjdk.java.net/jdk/pull/3076
Removed commented out value from `NTLMException`
-
Commit messages:
- 8263825: Remove unused and commented out member from NTLMException
Changes: https://git.openjdk.java.net/jdk/pull/3076/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3076&range=00
Issue: https://bu
On Thu, 18 Mar 2021 17:03:28 GMT, Claes Redestad wrote:
>> If I have other fixes for different modules, should I file PRs with the same
>> bug number e.g. "8263658: Use the blessed modifier order in
>> java.logging/java.desktop" or should we have separate bug numbers for them?
>
>> If I have ot
On Thu, 18 Mar 2021 16:50:39 GMT, Claes Redestad wrote:
>> Is that there to indicate a placeholder value that was once used and is kept
>> for documentation purposes? Should the corresponding JavaDoc be removed as
>> well? Should I do this in the same commit/PR as this one, or submit a new
>>
ing.
>
> https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=java&resolved=false&rules=java%3AS1124
Alex Blewitt has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous co
On Thu, 18 Mar 2021 14:50:43 GMT, Claes Redestad wrote:
>> Sonar displays a warning message that modifiers should be declared in the
>> order listed in the JLS; specifically, that isntead of using `final static`
>> the `static final` should be preferred.
>>
>> This fixes the issues in the `jav
On Thu, 18 Mar 2021 15:08:09 GMT, Aleksey Shipilev wrote:
>> src/java.base/share/classes/com/sun/security/ntlm/NTLMException.java line 52:
>>
>>> 50: * from server.
>>> 51: */
>>> 52: //public static final int DOMAIN_UNMATCH = 3;
>>
>> Maybe this one ought to be removed instead?
>
Sonar displays a warning message that modifiers should be declared in the order
listed in the JLS; specifically, that isntead of using `final static` the
`static final` should be preferred.
This fixes the issues in the `java.base` package for ease of reviewing.
https://sonarcloud.io/project/iss
25 matches
Mail list logo
