On Tue, 1 Mar 2022 17:09:57 GMT, zzambers wrote:
> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was
> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() /
> Socket.shutdownOutput() and InputStream.close() / OutputStream.close()
> performed
On Wed, 23 Feb 2022 16:08:49 GMT, Xue-Lei Andrew Fan wrote:
> In the TlsChannelBinding.java implementation, the string operation is placed
> before the case conversion. The behavior may be not expected.
>
>
> String hashAlg = serverCertificate.getSigAlgName().
> -
On Fri, 5 Nov 2021 22:55:16 GMT, Jamil Nimeh wrote:
>> This fix handles cases where two or more threads may be acting on a single
>> SSLSocket instance. In cases where one thread closes the socket while the
>> other is in the middle of a read, a SocketException is appropriately thrown,
>>
On Mon, 8 Nov 2021 22:59:30 GMT, Bradford Wetmore wrote:
> Minor typos.
This pull request has now been integrated.
Changeset: 38e6d5d6
Author: Bradford Wetmore
URL:
https://git.openjdk.java.net/jdk/commit/38e6d5d6ed967f68e6ac1bfaa285efa16577c790
Stats: 3 lines in 2 files chan
Minor typos.
-
Commit messages:
- Forgot copyright date
- 8276677: Malformed Javadoc inline tags in JDK source in javax/net/ssl
Changes: https://git.openjdk.java.net/jdk/pull/6301/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6301=00
Issue:
On Fri, 5 Nov 2021 17:23:40 GMT, Jamil Nimeh wrote:
>> This fix handles cases where two or more threads may be acting on a single
>> SSLSocket instance. In cases where one thread closes the socket while the
>> other is in the middle of a read, a SocketException is appropriately thrown,
>>
On Wed, 6 Oct 2021 18:47:26 GMT, Andrey Turbanov
wrote:
>> 8274809: Update java.base classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274809: Update java.base classes to use
On Wed, 6 Oct 2021 18:47:26 GMT, Andrey Turbanov
wrote:
>> 8274809: Update java.base classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274809: Update java.base classes to use
On Wed, 6 Oct 2021 16:07:12 GMT, Bradford Wetmore wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274809: Update java.base classes to use try-with-resources
>> update copyrigh
On Tue, 5 Oct 2021 09:36:23 GMT, Andrey Turbanov
wrote:
> 8274809: Update java.base classes to use try-with-resources
I checked the rest. The one BufferedInputStream change is puzzling. Please
explain or address.
Files like HttpTimestamper need the copyright dates updated to 2021.
On Tue, 5 Oct 2021 09:36:23 GMT, Andrey Turbanov
wrote:
> 8274809: Update java.base classes to use try-with-resources
Reviewed the crypto/security files.
src/java.base/share/classes/sun/security/timestamp/HttpTimestamper.java line
115:
> 113:
> 114: // Send the request
> 115:
On Thu, 30 Sep 2021 01:22:56 GMT, Bradford Wetmore wrote:
> See comment, + a couple minor cleanups.
This pull request has now been integrated.
Changeset: c57ed22e
Author: Bradford Wetmore
URL:
https://git.openjdk.java.net/jdk/commit/c57ed22e779e7efc8ff7f3c7ec08ce2cb1a738cb
St
On Thu, 30 Sep 2021 04:45:15 GMT, Jamil Nimeh wrote:
>> See comment, + a couple minor cleanups.
>
> src/java.base/share/classes/sun/security/ssl/SSLSecretDerivation.java line
> 153:
>
>> 151: private final byte[] label;
>> 152:
>> 153: SecretSchedule(String label) {
>
> Why
See comment, + a couple minor cleanups.
-
Commit messages:
- Minor cleanup.
Changes: https://git.openjdk.java.net/jdk/pull/5765/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5765=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8274528
Stats: 13 lines in 1 file
On Fri, 27 Aug 2021 18:37:14 GMT, Bradford Wetmore wrote:
> Added missing @. Link now works.
This pull request has now been integrated.
Changeset: 1fb798d3
Author: Bradford Wetmore
URL:
https://git.openjdk.java.net/jdk/commit/1fb798d320c708dfcbc0bb157511a2937fafb9e6
Stats:
> Added missing @. Link now works.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Forgot copyright update
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5284/files
- new: https://git.openjdk.java.
Added missing @. Link now works.
-
Commit messages:
- 8272915: (doc) package-info typo in extLink
Changes: https://git.openjdk.java.net/jdk/pull/5284/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5284=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8272915
On Fri, 27 Aug 2021 01:35:17 GMT, Bradford Wetmore wrote:
> Did a quick sweep of some minor non-standard javadoc issues. This silences
> 3rd party tooling warnings and fixes some linkage issues.
This pull request has now been integrated.
Changeset: 76baace2
Author:Bradford Wetmor
> Did a quick sweep of some minor non-standard javadoc issues. This silences
> 3rd party tooling warnings and fixes some linkage issues.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Codereview Comment
-
C
On Fri, 27 Aug 2021 03:38:55 GMT, Xue-Lei Andrew Fan wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comment
>
> src/java.base/share/classes/javax/net/ssl/SNIHostName.
Did a quick sweep of some minor non-standard javadoc issues. This silences 3rd
party tooling warnings and fixes some linkage issues.
-
Commit messages:
- 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code
Changes:
On Thu, 12 Aug 2021 18:45:33 GMT, Xue-Lei Andrew Fan wrote:
> There is debug code in the DSAParameterGenerator that dump debug information
> to standard-err. It should be deleted.
>
> Simple code clean up, no new regression test.
Marked as reviewed by wetmore (Reviewer).
-
PR:
On Sat, 22 May 2021 00:20:11 GMT, Bradford Wetmore wrote:
> The JceSecurityManager is currently a subclass of
> java.security.SecurityManager. Now that JEP 411 has been integrated, this
> class should be updated to no longer subclass SecurityManager.
>
> The only r
On Tue, 27 Jul 2021 03:51:01 GMT, Mandy Chung wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Additional codereview comments
>
> src/java.base/share/classes/javax/crypto/J
api/org_ietf,jck:api/javax_xml/crypto
> with all green.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
More codereview comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4150/files
- new: https://g
api/org_ietf,jck:api/javax_xml/crypto
> with all green.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Additional codereview comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4150/files
- new: http
api/org_ietf,jck:api/javax_xml/crypto
> with all green.
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 22 commits:
- More codereview comments
- Merge branch 'master' into JDK-8267485
- Merge branch 'master' into JD
On Wed, 14 Jul 2021 10:06:59 GMT, Sibabrata Sahoo wrote:
> Few more Test cases added to verify MessageDigest instance generated through
> different providers.
Marked as reviewed by wetmore (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/250
api/org_ietf,jck:api/javax_xml/crypto
> with all green.
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 15 commits:
- Merge branch 'master' into JDK-8267485
- More Codereview Comments
- Merge branch 'master' into JDK
On Wed, 9 Jun 2021 20:19:12 GMT, Jack Hartstein
wrote:
> The RC5ParameterSpec class description contains the following sentence: "This
> class can be used to initialize a Cipher object that implements the RC5
> algorithm as supplied by RSA Security LLC, or any parties authorized by RSA
>
api/org_ietf,jck:api/javax_xml/crypto
> with all green.
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 14 commits:
- More Codereview Comments
- Merge branch 'master' into JDK-8267485
- Minor typo
- Reduced Sup
On Thu, 3 Jun 2021 21:41:02 GMT, Sean Mullan wrote:
>> For the static initializer that needs updating: I could move the code out
>> of the initializer up to the declaration, or I could create a dummy
>> declaration and then assign to INSTANCE.
>
> The latter is probably better so you don't
On Thu, 3 Jun 2021 17:58:45 GMT, Daniel Fuchs wrote:
>> Unfortunately, we are still calling AccessController, thus the annotation
>> needs to remain.
>
> But if you follow my suggestion you can simply apply it to this line:
>
>
> @SuppressWarnings("removal")
> final List stack =
>
On Thu, 3 Jun 2021 08:27:14 GMT, Daniel Fuchs wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Address codereview comments
>> - Merge branch 'master
On Thu, 3 Jun 2021 14:20:37 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Address codereview comments
>> - Merge branch 'master
api/org_ietf,jck:api/javax_xml/crypto
> with all green.
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains eight commits:
- Address codereview comments
- Merge branch 'master' into JDK-8267485
- Merge branch 'master'
On Wed, 2 Jun 2021 18:18:46 GMT, Daniel Fuchs wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains six commits:
>>
>> - Merge branch 'master' into JDK-8267485
>> - Merge br
api/org_ietf,jck:api/javax_xml/crypto
> with all green.
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains six commits:
- Merge branch 'master' into JDK-8267485
- Merge branch 'master' into JDK-8267485
- Replace m
The JceSecurityManager is currently a subclass of
java.security.SecurityManager. Now that JEP 411 has been integrated, this
class should be updated to no longer subclass SecurityManager.
The only reason for using SecurityManager to easily get the Class Context (call
stack), but we can achieve
On Wed, 26 May 2021 01:12:14 GMT, Bradford Wetmore wrote:
> Missed updating today's changeset with the new variable name.
>
> It's a "one character fix."
This pull request has now been integrated.
Changeset: b33b8bc8
Author: Bradford Wetmore
URL:
https://git.o
Missed updating today's changeset with the new variable name.
It's a "one character fix."
-
Commit messages:
- 8267750: Incomplete fix for JDK-8267683
Changes: https://git.openjdk.java.net/jdk/pull/4196/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4196=00
Issue:
Simple typo fix. Somehow the trailing "u" got omitted, so the code won't parse
when fed into the compiler.
Resulting javadoc output now compiles.
-
Commit messages:
- Codereview Comments.
- 8267683: rfc7301Grease8F value not displayed correctly in SSLParameters
javadoc
On Tue, 25 May 2021 18:03:51 GMT, Bradford Wetmore wrote:
> Simple typo fix. Somehow the trailing "u" got omitted, so the code won't
> parse when fed into the compiler.
>
> Resulting javadoc output now compiles.
This pull request has now been integrated.
Chan
On Wed, 5 May 2021 10:00:22 GMT, Sibabrata Sahoo wrote:
> This change is to remove the shell Test and convert to it's java equivalent.
> That is the reason the shell Tests are deleted and the equivalent Java
> implementation provided.
> The purpose of the Test TestExemption.java is with
On Wed, 28 Apr 2021 00:12:44 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java line 1694:
>>
>>> 1692: if (cause instanceof SocketException) {
>>> 1693: try {
>>> 1694: throw conContext.fatal(alert, cause);
>>
On Thu, 22 Apr 2021 04:13:54 GMT, Xue-Lei Andrew Fan wrote:
>> As described in the bug, by connecting the SSLEngine with a misbehaving peer
>> SSL implementation, it can get into a state where it calling `wrap` reports
>> getStatus == OK, getHandshakeStatus === NEED_WRAP but still doesn't
On Fri, 2 Apr 2021 04:14:44 GMT, Xue-Lei Andrew Fan wrote:
>> Improve the readability by adding more comments in the ECDH public key
>> validation implementation in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Sun, 28 Mar 2021 04:09:38 GMT, Xue-Lei Andrew Fan wrote:
> Per NIST SP 800-56A Rev 3 (section 5.7.1), the shared secret cannot be 1 or
> (p - 1). This update adds this validation in the JDK provider implementation.
>
> No new regression test, simple update and hard to construct a shared
On Sun, 28 Mar 2021 06:07:39 GMT, Bradford Wetmore wrote:
>> Per NIST SP 800-56A Rev 3 (section 5.7.1), the shared secret cannot be 1 or
>> (p - 1). This update adds this validation in the JDK provider
>> implementation.
>>
>> No new regression test, simpl
On Sun, 28 Mar 2021 04:09:38 GMT, Xue-Lei Andrew Fan wrote:
> Per NIST SP 800-56A Rev 3 (section 5.7.1), the shared secret cannot be 1 or
> (p - 1). This update adds this validation in the JDK provider implementation.
>
> No new regression test, simple update and hard to construct a shared
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote:
> Disable the "missing" target for java.smartcardio from doclint.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/2930
On Thu, 11 Mar 2021 14:53:22 GMT, Roger Riggs wrote:
>> Disable the "missing" target for java.smartcardio from doclint.
>
> Please assign a new bug and title to ignore/suppress the warnings.
> The original issue 8252833 should be left open.
> Thanks
Closing, as it's unclear which approach
Disable the "missing" target for java.smartcardio from doclint.
-
Commit messages:
- Forgot copyright date update
- 8252833: Correct "no comment" warnings from javadoc in java.smartcardio
module
Changes: https://git.openjdk.java.net/jdk/pull/2930/files
Webrev:
On Sat, 6 Mar 2021 07:31:09 GMT, Bradford Wetmore wrote:
> Fix various things pointed out by the most recent doclint run in the
> security-libs area.
>
> This is docs only: I will be checking doccheck/doclint, and will be running
> tier1/tier2 tests. Minor spot checks on
> Fix various things pointed out by the most recent doclint run in the
> security-libs area.
>
> This is docs only: I will be checking doccheck/doclint, and will be running
> tier1/tier2 tests. Minor spot checks on generated files.
Bradford Wetmore has updated the pull reques
On Mon, 8 Mar 2021 19:50:06 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/java/security/BasicPermission.java line 497:
>>
>>> 495: /**
>>> 496: * @serialData Default fields.
>>> 497: */
>>
>> FWIW, this doc com
On Wed, 10 Mar 2021 19:02:40 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More Codereview Comments
>
> src/java.base/share/classes/java/security/PrivilegedAc
On Wed, 10 Mar 2021 15:10:35 GMT, Roger Riggs wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comment
>
> src/java.base/share/classes/javax/crypto/SealedO
On Wed, 10 Mar 2021 14:53:53 GMT, Roger Riggs wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More Codereview Comments
>
> src/java.base/share/classes/java/security/AllPermi
> Fix various things pointed out by the most recent doclint run in the
> security-libs area.
>
> This is docs only: I will be checking doccheck/doclint, and will be running
> tier1/tier2 tests. Minor spot checks on generated files.
Bradford Wetmore has updated the pull reques
On Tue, 9 Mar 2021 16:10:11 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comment
>
> src/java.base/share/classes/javax/crypto/SealedO
> Fix various things pointed out by the most recent doclint run in the
> security-libs area.
>
> This is docs only: I will be checking doccheck/doclint, and will be running
> tier1/tier2 tests. Minor spot checks on generated files.
Bradford Wetmore has updated the pull reques
On Sat, 6 Mar 2021 19:20:39 GMT, Jonathan Gibbons wrote:
>> Fix various things pointed out by the most recent doclint run in the
>> security-libs area.
>>
>> This is docs only: I will be checking doccheck/doclint, and will be running
>> tier1/tier2 tests. Minor spot checks on generated
Fix various things pointed out by the most recent doclint run in the
security-libs area.
This is docs only: I will be checking doccheck/doclint, and will be running
tier1/tier2 tests. Minor spot checks on generated files.
-
Commit messages:
- Final First Draft
- Only 100
Thanks for the catch and submission, but this was fixed back in December.
The JDK code was moved from mercurial (hg.openjdk.java.net) to GitHub as
part of project Skara at the end of summer.
https://github.com/openjdk/jdk
You can use the "blame" function to see which changeset pushed it.
On Mon, 1 Mar 2021 03:07:12 GMT, John Jiang wrote:
> Per RFC 8446, section 4.1.2, the legacy_version field in ClientHello message
> MUST be set to 0x0303 (TLSv1.2).
> T13ClientHelloConsumer should do this check like that T13ServerHelloConsumer
> does.
Marked as reviewed by wetmore (Reviewer).
On Thu, 11 Feb 2021 10:10:58 GMT, John Jiang wrote:
>> This is a simple cleanup for sun.security.ssl.SSLExtension.
>> The comments for the extension groups would use the RFC numbers and the
>> protocol titles correspondingly.
>> It also removes a trailing space in extension token_binding, and
On Thu, 11 Feb 2021 01:54:53 GMT, John Jiang wrote:
>> This is a simple cleanup for sun.security.ssl.SSLExtension.
>> It converts protocol or draft names to RFC numbers correspondingly.
>> It also removes a trailing space in extension token_binding, and move
>> signature_algorithms_cert to RFC
On Tue, 12 Jan 2021 17:19:17 GMT, Xue-Lei Andrew Fan wrote:
>> The SSLSocketImpl and SSLEngineImpl implementation does not override the
>> toString() method. The old code did. BTW, I also made a few code clean up
>> in the SSLSocketImpl.java.
>>
>> Code clean up, trivial update, no new
On Mon, 4 Jan 2021 18:06:24 GMT, Xue-Lei Andrew Fan wrote:
> There are a few fields in the SunJSSE provider implementation could be final.
>
> Code clean up to easy the maintenance, no new test.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8259069
Marked as reviewed by wetmore
I haven't been following what OpenJDK has been doing recently, but IIRC,
the original call includes all of the server's requested key types,
copied directly from the CertificateRequest message. See:
https://tools.ietf.org/rfcmarkup?doc=2246#section-7.4.4
Have a look at the current code:
On Thu, 24 Dec 2020 21:55:02 GMT, Xue-Lei Andrew Fan wrote:
> The test javax/net/ssl/DTLS/RespondToRetransmit.java timed out
> intermittently. This is a request to add "intermittent" tag to the test.
>
> Test update, no new regression test.
>
> Bug:
On Tue, 22 Dec 2020 17:16:15 GMT, Xue-Lei Andrew Fan wrote:
> The local variable "knownSignatureSchemes" in the
> CRSignatureSchemesConsumer.consume() method is assigned, but it is not really
> queried. It is safe to remove the local variable and the related code.
>
> Code cleanup, no new
On Sat, 19 Dec 2020 05:48:53 GMT, Xue-Lei Andrew Fan wrote:
> It looks like the break is missed in the loop of the
> SSLCipher.createReadCipher() and createWriteCipher() methods. See the change
> set.
>
> Code cleanup, no new regression test.
>
> Bug:
On Thu, 3 Dec 2020 20:44:46 GMT, Xue-Lei Andrew Fan wrote:
> In sun.security.ssl.BaseSSLSocketImpl.java, the package of SocketChannel in
> the getChannel() spec is java.nio, which is incorrect. It should be
> java.nio.channels.
>
> Doc cleanup only, no new regression test.
>
> Bug:
On Thu, 3 Dec 2020 16:09:11 GMT, Anthony Scarpino wrote:
> It's missing a comma
Marked as reviewed by wetmore (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1601
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote:
> Certain TLS ALPN values can't be properly read or written by the SunJSSE
> provider. This is due to the choice of Strings as the API interface and the
> undocumented internal use of the UTF-8 Character Set which converts
>
On Thu, 26 Nov 2020 10:33:26 GMT, Daniel Fuchs wrote:
>> Certain TLS ALPN values can't be properly read or written by the SunJSSE
>> provider. This is due to the choice of Strings as the API interface and the
>> undocumented internal use of the UTF-8 Character Set which converts
>> characters
On Thu, 26 Nov 2020 20:26:36 GMT, Xue-Lei Andrew Fan wrote:
>> Certain TLS ALPN values can't be properly read or written by the SunJSSE
>> provider. This is due to the choice of Strings as the API interface and the
>> undocumented internal use of the UTF-8 Character Set which converts
>>
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote:
> Certain TLS ALPN values can't be properly read or written by the SunJSSE
> provider. This is due to the choice of Strings as the API interface and the
> undocumented internal use of the UTF-8 Character Set which converts
>
Certain TLS ALPN values can't be properly read or written by the SunJSSE
provider. This is due to the choice of Strings as the API interface and the
undocumented internal use of the UTF-8 Character Set which converts characters
larger than U+7F into multi-byte arrays that may not be
On Sun, 29 Nov 2020 20:29:42 GMT, Xue-Lei Andrew Fan wrote:
> This change cleanups the unused imports in the SunJSSE provider
> implementation. Cleanup only, no new regression test.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8257237
Looks good.
-
Marked as reviewed by
On Thu, 26 Nov 2020 17:57:03 GMT, Weijun Wang wrote:
>> Are you talking about the line 78? Yes, you are correct, I didn't update
>> anything beyond the initial comment. I can update that as well.
>
> Yes, the paragraph starting from line 77.
Got it, thanks for the reviews.
-
On Thu, 26 Nov 2020 16:34:53 GMT, Bradford Wetmore wrote:
> This is to fix some out-of-date information in the javadoc for the SHA1PRNG
> that has generated a customer bug.
This pull request has now been integrated.
Changeset: 62d72dec
Author:Bradford Wetmore
URL:
> This is to fix some out-of-date information in the javadoc for the SHA1PRNG
> that has generated a customer bug.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Code review comments
-
Changes:
- all:
On Thu, 26 Nov 2020 17:41:23 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor grammar error
>
> src/java.base/share/classes/sun/security/provider/Secur
> This is to fix some out-of-date information in the javadoc for the SHA1PRNG
> that has generated a customer bug.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Minor grammar error
-
Changes:
- all:
This is to fix some out-of-date information in the javadoc for the SHA1PRNG
that has generated a customer bug.
-
Commit messages:
- 8220730: sun.security.provider.SecureRandom default constructor has wrong
documentation
Changes: https://git.openjdk.java.net/jdk/pull/1461/files
Hi Xuelei/Jamil/Tony/others(?),
I need a reviewer for this CSR, in preparation for:
CSR: https://bugs.openjdk.java.net/browse/JDK-8256817
Bug: https://bugs.openjdk.java.net/browse/JDK-8254631
Draft Change: https://github.com/openjdk/jdk/pull/1440
8254631: Better support
On 10/8/2020 9:20 AM, Alexander Scheel wrote:
Hi all,
I saw that ALPN support from JEP 244 was backported to JDK8 and I've
recently had the time to take a closer look at it. For context, I'm
one of the maintainers of JSS, a NSS wrapper for Java. I've been
discussing this with another
Like XDH, these...
->
Like XDH (i.e. x25519/x448), these...
You might provide a link to the original XDH JEP (JDK-8181595) and later
CSR (JDK-8224520) and/or JDK-8171279.
and for use in automatic certificate selection for certificate messages.
->
and for use in certificate selection for
From a coding point of view, if Xuelei doesn't have a further
suggestion, using virtual threads like you have suggested seems to be a
good solution. I'm ok with this change for Project Loom. Loom has a
lot of promise for things like this.
I've never been thrilled with the threading of the
On Fri, 11 Sep 2020 07:15:26 GMT, Dmitriy Dumanskiy
wrote:
>> 1) This is un-necessary churn.
>> 2) I can't even be sure I am finding the ones in my area because there's so
>> much here
>> 3) The ones I can find have no need of whatever performance improvement this
>> might bring.
>> I think
Hi Norman,
There are a couple things in the stack trace that don't make sense. Am
I missing something?
This looks like a server side trace, so the initialization of the
RandomCookie should be inside the Task for the FINISHED message
consumption, which kicks off the NewSessionTicket
Assuming 'linux-aarch64' is correct, this looks ok to me.
As an aside, we are looking at a possible configuration problem in our
test environment that is not linking the host RNG to the VMs. I'm
hoping these can come off soon.
Brad
On 6/19/2020 10:07 AM, Daniel D. Daugherty wrote:
Approved. :)
Or if you want, I could review this much more carefully...
Brad
On 6/12/2020 2:43 PM, Xuelei Fan wrote:
Hi,
May I have the following typo correction reviewed in test file?
$ hg diff test/jdk/javax/net/ssl/SSLEngine/IllegalHandshakeMessage.java
@@ -70,7 +70,7 @@
Update the year, but otherwise looks good.
Brad
On 6/9/2020 4:04 PM, Xuelei Fan wrote:
A simple fix like this looks good to me. I may check this first, before
the EC available and signature checking.
Xuelei
On 6/9/2020 3:12 PM, Anthony Scarpino wrote:
Hi,
I need a code review of this
in a quick note here why you're doing this? i.e. to
avoid draining the system's entropy pool by using a seeded PRNG.
Thanks,
Brad
On 5/4/2020 6:12 PM, Bradford Wetmore wrote:
All minor nits, can be done later if it won't be a problem to make minor
API wording tweaks.
On 5/4/2020 10:17 AM, Anthony
All minor nits, can be done later if it won't be a problem to make minor
API wording tweaks.
On 5/4/2020 10:17 AM, Anthony Scarpino wrote:
On 2/25/20 12:49 PM, Anthony Scarpino wrote:
Hi
I need a code review for the EdDSA support in JEP 339. The code
builds on the existing java implemented
For keysize in things like KeyPairGenerator, why are we using 255/448
(externally and internally) instead of 256/456? From RFC 8032:
section 3.2: "An EdDSA private key is a b-bit string k"
+
section 5.1.5/Ed25519: "The private key is 32 octets (256 bits,
corresponding to b)
101 - 200 of 560 matches
Mail list logo
