Re: RFR: 8283665: Two Jarsigner tests needs to be updated with JDK-8267319

2022-03-25 Thread Daniel D . Daugherty
On Fri, 25 Mar 2022 05:11:18 GMT, Valerie Peng wrote: > Max, can you please help review this fix? It updates the two jarsigner tests > which are added to the main trunk during the code review of JDK-8267319. > > Mach5 run succeeds. > Thanks, > Valerie Is this fix going to be integrated soon? W

Re: RFR: 7192189: Support endpoint identification algorithm in RFC 6125 [v2]

2022-03-08 Thread Daniel D . Daugherty
On Tue, 8 Mar 2022 13:00:50 GMT, Sean Mullan wrote: >> Please review this change to fully support RFC 6125 in the TLS >> implementation. This change forbids wildcard domains in TLS certificates >> unless the wildcard is in the left-most component. Certificates of this >> nature should be rare

[jdk18] Integrated: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64

2022-01-05 Thread Daniel D . Daugherty
On Wed, 5 Jan 2022 17:22:54 GMT, Daniel D. Daugherty wrote: > A couple of trivial ProblemListings: > > JDK-8279529 ProblemList > java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 > JDK-8279532 ProblemList > sun/security/

Re: [jdk18] RFR: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64

2022-01-05 Thread Daniel D . Daugherty
On Wed, 5 Jan 2022 17:39:16 GMT, Jamil Nimeh wrote: >> A couple of trivial ProblemListings: >> >> JDK-8279529 ProblemList >> java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on >> macosx-aarch64 >> JDK-8279532 ProblemList >> sun/security/ssl/SSLSessionImpl/NoInvalidateSocketExcept

[jdk18] RFR: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64

2022-01-05 Thread Daniel D . Daugherty
A couple of trivial ProblemListings: JDK-8279529 ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 JDK-8279532 ProblemList sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java - Commit messages: - 8279532: ProblemList sun/secur

Re: RFR: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError

2021-12-02 Thread Daniel D . Daugherty
On Thu, 2 Dec 2021 01:20:30 GMT, Valerie Peng wrote: > Can someone help reviewing this trivial one-line fix? The assert check in > CK_MECHANISM.java is too strict and fail unexpectedly when digest-specific > PSS signature mechanisms are supported by the underlying PKCS#11 library. The > fix is

Re: RFR: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError

2021-12-02 Thread Daniel D . Daugherty
On Thu, 2 Dec 2021 01:20:30 GMT, Valerie Peng wrote: > Can someone help reviewing this trivial one-line fix? The assert check in > CK_MECHANISM.java is too strict and fail unexpectedly when digest-specific > PSS signature mechanisms are supported by the underlying PKCS#11 library. The > fix is

Re: RFR: Merge jdk17

2021-06-14 Thread Daniel D . Daugherty
On Mon, 14 Jun 2021 14:28:33 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 Thumbs up! Thanks for doing this sync forward. - Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4484

Re: RFR: 8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64

2021-04-24 Thread Daniel D . Daugherty
On Sat, 24 Apr 2021 15:56:55 GMT, Roger Riggs wrote: >> A trivial fix to ProblemList >> sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java >> on macOS-X64 and Linux-aarch64. It is already ProblemListed on linux-x64. > > Marked as reviewed by rriggs (Reviewer). @RogerRiggs an

Integrated: 8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64

2021-04-24 Thread Daniel D . Daugherty
On Sat, 24 Apr 2021 14:35:32 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java > on macOS-X64 and Linux-aarch64. It is already ProblemListed on linux-x64. This pull request has now been i

RFR: 8265890: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64

2021-04-24 Thread Daniel D . Daugherty
A trivial fix to ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on macOS-X64 and Linux-aarch64. It is already ProblemListed on linux-x64. - Commit messages: - Change 'linux-generic' -> 'linux-all'. - 8265890: ProblemList sun/security/ssl/SSLSock

Re: Integrated: 8264656: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on linux-x64

2021-04-02 Thread Daniel D . Daugherty
On Fri, 2 Apr 2021 18:09:48 GMT, Roger Riggs wrote: >> A trivial fix to ProblemList >> sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java >> on linux-x64 > > Marked as reviewed by rriggs (Reviewer). @RogerRiggs - Thanks for the blazingly fast review! - PR: http

Integrated: 8264656: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on linux-x64

2021-04-02 Thread Daniel D . Daugherty
On Fri, 2 Apr 2021 18:04:26 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java > on linux-x64 This pull request has now been integrated. Changeset: d0f3cc92 Author: Daniel D. Daugherty URL:

Integrated: 8264656: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on linux-x64

2021-04-02 Thread Daniel D . Daugherty
A trivial fix to ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on linux-x64 - Commit messages: - 8264656: ProblemList sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java on linux-x64 Changes: https://git.openjdk.java.net/jdk

Re: RFR: 8263549: 8263412 can cause jtreg testlibrary split [v3]

2021-03-13 Thread Daniel D . Daugherty
On Sat, 13 Mar 2021 06:44:12 GMT, Igor Ignatyev wrote: >> Hi all, >> >> could you please review this dull patch that replaces `ClassFileInstaller` >> w/ `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions >> to ensure we won't get split testlibrary, and removes >> `jdk/te

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-02 Thread Daniel D . Daugherty
On Tue, 2 Feb 2021 11:59:08 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Integrated: 8260864: ProblemList two security/krb5 tests on Linux

2021-02-01 Thread Daniel D . Daugherty
On Mon, 1 Feb 2021 22:41:16 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList these two tests on Linux: > > sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java > sun/security/krb5/auto/ReplayCacheTestProc.java > > We're rolling machines over to Linux 8.3

Re: RFR: 8260864: ProblemList two security/krb5 tests on Linux

2021-02-01 Thread Daniel D . Daugherty
On Mon, 1 Feb 2021 22:50:37 GMT, David Holmes wrote: >> A trivial fix to ProblemList these two tests on Linux: >> >> sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java >> sun/security/krb5/auto/ReplayCacheTestProc.java >> >> We're rolling machines over to Linux 8.3 and these two tests are s

RFR: 8260864: ProblemList two security/krb5 tests on Linux

2021-02-01 Thread Daniel D . Daugherty
A trivial fix to ProblemList these two tests on Linux: sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java sun/security/krb5/auto/ReplayCacheTestProc.java We're rolling machines over to Linux 8.3 and these two tests are starting to fail in the CI in Tier2 (so far). So we need to reduce the noi

Re: RFR: 8259582: Backout JDK-8237578 until all affected tests have been fixed

2021-01-11 Thread Daniel D . Daugherty
On Mon, 11 Jan 2021 19:25:28 GMT, Volker Simonis wrote: > [JDK-8237578](https://bugs.openjdk.java.net/browse/JDK-8237578) caused a few > internal and external tests to fail (see > [JDK-8259572](https://bugs.openjdk.java.net/browse/JDK-8259572)). > > Backout [JDK-8237578](https://bugs.openjdk.j

Re: RFR: 8253637: Update EC removal

2020-09-25 Thread Daniel D . Daugherty
On Fri, 25 Sep 2020 18:56:00 GMT, Anthony Scarpino wrote: > Hi, > > I need a quick review for two changes. The primary is a failure that shows > up on linux-aarch64 because the systems do > not have NSS. The default was to allow all curves tested, which before the > native library removal w

Re: RFR: 8253659: ProblemList sun/security/ec/TestEC.java on linux-aarch64

2020-09-25 Thread Daniel D . Daugherty
On Fri, 25 Sep 2020 19:37:25 GMT, Daniel D. Daugherty wrote: >> Looks like a trivial change to me. > > @iklam - thanks for the fast review. Tony - sorry about that. The last time I checked your bug (about 2 hours ago) it wasn't "in progress". Please update your fix

Integrated: 8253659: ProblemList sun/security/ec/TestEC.java on linux-aarch64

2020-09-25 Thread Daniel D . Daugherty
On Fri, 25 Sep 2020 17:15:01 GMT, Daniel D. Daugherty wrote: > Reduce noise in CI Tier2 by ProblemListing this test. This pull request has now been integrated. Changeset: 9150b902 Author: Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/commit/9150b902 Stats: 2 lines

Re: RFR: 8253659: ProblemList sun/security/ec/TestEC.java on linux-aarch64

2020-09-25 Thread Daniel D . Daugherty
On Fri, 25 Sep 2020 19:32:57 GMT, Ioi Lam wrote: >> Marked as reviewed by iklam (Reviewer). > > Looks like a trivial change to me. @iklam - thanks for the fast review. - PR: https://git.openjdk.java.net/jdk/pull/362

RFR: 8253659: ProblemList sun/security/ec/TestEC.java on linux-aarch64

2020-09-25 Thread Daniel D . Daugherty
Reduce noise in CI Tier2 by ProblemListing this test. - Commit messages: - Add 'aarch64' to the generic-ARCH comment so folks know what to use. - Use the correct bug ID: 8253637. - 8253659: ProblemList sun/security/ec/TestEC.java on linux-aarch64 Changes: https://git.openjdk.java.

Re: RFR: 8253659: ProblemList sun/security/ec/TestEC.java on linux-aarch64

2020-09-25 Thread Daniel D . Daugherty
On Fri, 25 Sep 2020 17:15:01 GMT, Daniel D. Daugherty wrote: > Reduce noise in CI Tier2 by ProblemListing this test. My Tier2 test job ran sun/security/ec/TestEC.java on all regular Oracle platforms except for linux-aarch64. I also updated the generic-ARCH header comment to include '

Re: RFR(T): 8248044: Backout ProblemList-ed tests introduced by JDK-8247876

2020-06-26 Thread Daniel D. Daugherty
Thumbs up. I agree that this is a trivial fix. Dan On 6/26/20 4:48 PM, Mikael Vidstedt wrote: Please review this trivial change which reenables the tests which were problem listed because of a linux-aarch64 machine configuration issue which has since been fixed: Note: I intend to push this t

Re: RFR(T): 8247876: ProblemList various crypto tests on aarch64

2020-06-19 Thread Daniel D. Daugherty
uming 'linux-aarch64' is correct, this looks ok to me. As an aside, we are looking at a possible configuration problem in our test environment that is not linking the host RNG to the VMs. I'm hoping these can come off soon. Brad On 6/19/2020 10:07 AM, Daniel D. Daugherty wro

RFR(T): 8247876: ProblemList various crypto tests on aarch64

2020-06-19 Thread Daniel D. Daugherty
Greetings, In order to reduce the noise in the JDK15 and JDK16 CIs, I'm ProblemListing some crypto tests on linux-aarch64.     JDK-8247876 ProblemList various crypto tests on aarch64     https://bugs.openjdk.java.net/browse/JDK-8247876 Here's the associated product bug:     JDK-8247359 SecureR

Re: RFR [15]: 8240684: ProblemList 70 security tests that are failing on Windows due to "Fetch artifact failed"

2020-03-06 Thread Daniel D. Daugherty
Thumbs up! Thanks for handling this. Dan On 3/6/20 12:31 PM, Sean Mullan wrote: Please review this change to ProblemList 70 security tests while we diagnose the artifactory issues. See https://bugs.openjdk.java.net/browse/JDK-8240684 for more info. diff -r 1c40993361d0 test/jdk/ProblemList