Re: dlsym(RTLD_DEFAULT, "getentropy") return non-NULL on Mac

2015-11-08 Thread Dmitry Samersoff
opy is available and you can't request more than 256 bytes of entropy at once. it might require changes in uplevel logic. -Dmitry On 2015-11-08 03:37, Wang Weijun wrote: > >> On Nov 8, 2015, at 4:29 AM, Dmitry Samersoff >> wrote: >> >> Wang Weijun, >>

Re: dlsym(RTLD_DEFAULT, "getentropy") return non-NULL on Mac

2015-11-07 Thread Dmitry Samersoff
re > else? How do I detect it and what shall I do to avoid it? > > Thanks > Max > > [1] http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man2/getentropy.2 > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.

hg: jdk8/tl/jdk: 8024071: In ManagementAgent.start it should be possible to set the jdp.name parameter.

2013-10-19 Thread dmitry . samersoff
Changeset: 392acefef659 Author:dsamersoff Date: 2013-10-19 20:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/392acefef659 8024071: In ManagementAgent.start it should be possible to set the jdp.name parameter. Summary: Pass one more property from Agent to JdpController Rev

hg: jdk8/tl/jdk: 8004213: JDP packet needs pid, broadcast interval and rmi server hostname fields

2013-10-18 Thread dmitry . samersoff
Changeset: 88436832cfd0 Author:dsamersoff Date: 2013-10-19 00:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88436832cfd0 8004213: JDP packet needs pid, broadcast interval and rmi server hostname fields Summary: Add some extra fileds to jdp packet Reviewed-by: allwin, sla,

hg: jdk8/tl/jdk: 8009213: sun/management/jdp/JdpTest.sh fails with exit code 1

2013-10-03 Thread dmitry . samersoff
Changeset: 5d6dc0cba08f Author:dsamersoff Date: 2013-10-03 16:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d6dc0cba08f 8009213: sun/management/jdp/JdpTest.sh fails with exit code 1 Summary: There's no guarantee that the java process has executed far enough to be found

Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

2013-08-08 Thread Dmitry Samersoff
t;>>> >>>>>> Here are the questions: >>>>>> 1. whether "example..com" is an valid IDN? >>>>>> As dot is used as label separators, there are three labels, >>>>>> "example", "", &qu

Re: Code review request: 8016594: Native Windows ccache still reads DES tickets

2013-08-07 Thread Dmitry Samersoff
I (or QE) are more familiar with > native krb5 on Mac? > > Thanks > Max > > On 8/7/13 9:09 PM, Xuelei Fan wrote: >> On 8/7/2013 7:53 PM, Dmitry Samersoff wrote: >>> Xuelei, >>> >>> 1. strncmp calls strlen at first, so explicit call to strlen is no

Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

2013-08-07 Thread Dmitry Samersoff
on throws > a StringIndexOutOfBoundsException. > >However, what empty domain name ("") really means? I would prefer to > return "." for "." instead. > >We need to address the issue in IDN. As dot is a label separator and root (empty) la

Re: Code review request: 8016594: Native Windows ccache still reads DES tickets

2013-08-07 Thread Dmitry Samersoff
Xuelei, 1. strncmp calls strlen at first, so explicit call to strlen is not necessary. 2. strlen("krbtgt") == sizeof("krbtgt")-1 as sizeof count terminating 0. -Dmitry On 2013-08-07 15:31, Xuelei Fan wrote: > On 8/7/2013 6:58 PM, Weijun Wang wrote: >> >> >

Re: Code review request: 8016594: Native Windows ccache still reads DES tickets

2013-08-07 Thread Dmitry Samersoff
, Weijun Wang wrote: > > > On 8/7/13 5:23 PM, Dmitry Samersoff wrote: >> Weijun, >> >> nativeccache.c: >> >> 322: Could you change strlen("krbtgt") to sizeof("krbtgt")-1 to save a >> bit of computer power? > > Sur

Re: Code review request: 8016594: Native Windows ccache still reads DES tickets

2013-08-07 Thread Dmitry Samersoff
; >http://cr.openjdk.java.net/~weijun/8016594/webrev.00/ > > Instead of always reading tickets with session key of DES/RC4 etypes, it > should accept any ticket in the default_tkt_enctypes setting. > > No reg test, needs a SQE test running with Windows 2008 as server. > >

Re: Code review request, 8020842 IDN do not throw IAE when hostname ends with a trailing dot

2013-08-06 Thread Dmitry Samersoff
ASCII(IDN.java:118) > > Case 2: > String host = IDN.toASCII("com.", IDN.USE_STD3_ASCII_RULES); > > Thanks, > Xuelei > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.

hg: jdk8/tl/jdk: 8011038: sourceObj validation during desereliazation of RelationNotification should be relaxed

2013-08-06 Thread dmitry . samersoff
Changeset: fce446b29577 Author:dsamersoff Date: 2013-08-06 14:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fce446b29577 8011038: sourceObj validation during desereliazation of RelationNotification should be relaxed Summary: sourceObj could be set to null by setSource()

hg: jdk8/tl/jdk: 8015604: JDP packets containing ideographic characters are broken

2013-06-05 Thread dmitry . samersoff
Changeset: df1b35c7901d Author:dsamersoff Date: 2013-06-05 18:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df1b35c7901d 8015604: JDP packets containing ideographic characters are broken Summary: Code uses string length rather than byte array length and non ascii entry b

hg: jdk8/tl/jdk: 8014420: Default JDP address does not match the one assigned by IANA

2013-05-28 Thread dmitry . samersoff
Changeset: 7d7bfce34a79 Author:dsamersoff Date: 2013-05-28 18:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d7bfce34a79 8014420: Default JDP address does not match the one assigned by IANA Summary: JDP protocol defaults changed to IANA assigned values Reviewed-by: dholme

Re: 8008793: SecurityManager.checkXXX behavior not specified for methods that check AWTPermission and AWT not present

2013-02-25 Thread Dmitry Samersoff
On 2013-02-25 17:49, Alan Bateman wrote: > On 25/02/2013 13:21, Dmitry Samersoff wrote: >> Alan, >> >> Did you consider to explicitly throw security exception with the message >> like "Permission couldn't be granted because of wrong profile" or >

Re: 8008793: SecurityManager.checkXXX behavior not specified for methods that check AWTPermission and AWT not present

2013-02-25 Thread Dmitry Samersoff
net/~alanb/8008793/webrev/ > > Note that the implementation changes are mostly just removing the "fake > permission" code (this was originally put in to ensure that > checkPermission was called with a permission that could never be > granted, it's not needed now). > &

hg: jdk8/tl/jdk: 8008095: TEST_BUG: JDK-8002048 one more testcase failure on Solaris

2013-02-13 Thread dmitry . samersoff
Changeset: 8181be9a3538 Author:dsamersoff Date: 2013-02-13 21:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8181be9a3538 8008095: TEST_BUG: JDK-8002048 one more testcase failure on Solaris Summary: fixed couple of more Solaris shell incompatibilities Reviewed-by: chegar

Re: RFR: JDK-8007607

2013-02-12 Thread Dmitry Samersoff
pile. > > So I'm speaking about *one particular case*, where returned value > could lead to misinterpretation of security context and lead to > security vulnerability or subtle bug. > > We have to throw OOM there and change all callers as well for this > case. > >

Re: RFR: JDK-8007607

2013-02-12 Thread Dmitry Samersoff
if (jcb == NULL) { >>> return GSS_C_NO_CHANNEL_BINDINGS; >>>} >>> cb = malloc(sizeof(struct gss_channel_bindings_struct)); >>> >>> if(cb == NULL) >>> return GSS_C_NO_CHANNEL_BINDINGS;* >>> &

hg: jdk8/tl/jdk: 8007786: JDK-8002048 testcase doesn't work on Solaris

2013-02-12 Thread dmitry . samersoff
Changeset: f7fb173ac833 Author:dsamersoff Date: 2013-02-12 16:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7fb173ac833 8007786: JDK-8002048 testcase doesn't work on Solaris Summary: test built in into Solaris shell doesn't have -e operator Reviewed-by: sla, sspitsyn !

hg: jdk8/tl/jdk: 8007536: Incorrect copyright header in JDP files

2013-02-11 Thread dmitry . samersoff
Changeset: 1df991184045 Author:dsamersoff Date: 2013-02-11 18:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1df991184045 8007536: Incorrect copyright header in JDP files Summary: Copyright header in JDP files missed the "classpath exception" rule. Reviewed-by: mikael ! s

Re: RFR: JDK-8007607

2013-02-08 Thread Dmitry Samersoff
gss_channel_bindings_t cb; >>>jobject jinetAddr; >>>jbyteArray value; >>> >>>if (jcb == NULL) { >>> return GSS_C_NO_CHANNEL_BINDINGS; >>>} >>> cb = malloc(sizeof(struct gss_channel_binding

Re: RFR: JDK-8007607

2013-02-08 Thread Dmitry Samersoff
cb = malloc(sizeof(struct gss_channel_bindings_struct)); >> >> if(cb == NULL) >> return GSS_C_NO_CHANNEL_BINDINGS;* >> >> There doesn't appear to be anything in our set of options that is more >> suggestive of a memory allocation fa

Re: RFR: JDK-8007607

2013-02-08 Thread Dmitry Samersoff
ear to be anything in our set of options that is more > suggestive of a memory allocation failure and the symbol: > GSS_C_NO_CHANNEL_BINDINGS seems to be logically correct. > > Ideas? > > On 02/06/2013 04:57 AM, Dmitry Samersoff wrote: >> John, >> >> Not sure GSS_C_NO_CHANNEL_BIND

hg: jdk8/tl/jdk: 8007277: JDK-8002048 testcase fails to compile

2013-02-06 Thread dmitry . samersoff
Changeset: 0e7d5dd84fdf Author:dsamersoff Date: 2013-02-06 16:53 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e7d5dd84fdf 8007277: JDK-8002048 testcase fails to compile Summary: sun.* classes is not included to ct.sym file and symbol file have to be ignored Reviewed-by: a

Re: RFR: JDK-8007607

2013-02-06 Thread Dmitry Samersoff
by > checking the return values of malloc() and realloc() calls. > > The webrev image of these changes is visible at: > http://cr.openjdk.java.net/~jzavgren/8007607/webrev.01/ > > Thanks! > John Zavgren > -- Dmitry Samersoff Oracle Java development team, Saint Peter

hg: jdk8/tl/jdk: 8002048: Protocol to discovery of manageable Java processes on a network

2013-02-03 Thread dmitry . samersoff
Changeset: 962d6612cace Author:dsamersoff Date: 2013-02-03 21:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/962d6612cace 8002048: Protocol to discovery of manageable Java processes on a network Summary: Introduce a protocol to discover manageble Java instances across a n

hg: jdk8/tl/jdk: 8005309: Missed tests for 6783290,6937053,7009998

2012-12-20 Thread dmitry . samersoff
Changeset: c1a55ee9618e Author:dsamersoff Date: 2012-12-20 20:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1a55ee9618e 8005309: Missed tests for 6783290,6937053,7009998 Summary: Missed tests for 6783290,6937053,7009998 Reviewed-by: sjiang, emcmanus Contributed-by: jaros

hg: jdk8/tl/jdk: 7009998: JMX synchronization during connection restart is faulty

2012-12-20 Thread dmitry . samersoff
Changeset: 3f014bc09297 Author:dsamersoff Date: 2012-12-20 17:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f014bc09297 7009998: JMX synchronization during connection restart is faulty Summary: add a return statement after the re-connecting has finished and the state is

hg: jdk8/tl/jdk: 6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure

2012-12-20 Thread dmitry . samersoff
Changeset: e43f90d5af11 Author:dsamersoff Date: 2012-12-20 16:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e43f90d5af11 6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure Summary: the catch block in the fetchNotifs() method is extended to expe

hg: jdk8/tl/jdk: 6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject

2012-12-20 Thread dmitry . samersoff
Changeset: b600d490dc57 Author:dsamersoff Date: 2012-12-20 16:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b600d490dc57 6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject Summary: call readObject in all cases Reviewed-by: emcmanus Contributed-by:

Re: 8002344 code review request: (was Re: [PATCH] for bug 2376501: Krb5LoginModule config class does not return proper KDC list from DNS)

2012-11-14 Thread Dmitry Samersoff
;>>> e.g. : >>>> >>>> @run main/othervm -Xbootclasspath/a:../classes/serviceability >>>> -XX:+UnlockDiagnosticVMOptions ... ParserTest >>> >>> Good suggestion, but the class is built into test.classes and test run >>> in scratch. I cann

Re: 8002344 code review request: (was Re: [PATCH] for bug 2376501: Krb5LoginModule config class does not return proper KDC list from DNS)

2012-11-13 Thread Dmitry Samersoff
class into scratch. > > Thanks > Max > > [1] http://tools.ietf.org/html/rfc2782 > >> >> >> -Dmitry >> >> On 2012-11-13 16:07, Weijun Wang wrote: >>> >>> >>> On 11/13/2012 07:44 PM, Dmitry Samersoff wrote: >>>>

Re: 8002344 code review request: (was Re: [PATCH] for bug 2376501: Krb5LoginModule config class does not return proper KDC list from DNS)

2012-11-13 Thread Dmitry Samersoff
12-11-13 16:07, Weijun Wang wrote: > > > On 11/13/2012 07:44 PM, Dmitry Samersoff wrote: >> Weijun, >> >> Config.java:1162 >> This code is unclear to me. >> if srvs[i] could be "" this code could insert extra space in &g

Re: 8002344 code review request: (was Re: [PATCH] for bug 2376501: Krb5LoginModule config class does not return proper KDC list from DNS)

2012-11-13 Thread Dmitry Samersoff
t;>>>> In Config.java, line 1234 in method getKDCFromDNS(String realm) >>>>> there is >>>>> a loop which discards earlier values of KDCs returned rather than >>>>> concatenating them. This results in a behaviour where only one KDC >>>>

Re: RFR 8000476, miscellaneous leaks, access to uninitialized memory, etc

2012-10-23 Thread Dmitry Samersoff
emory: leaks, access to uninitialized memory, etc. > > http://cr.openjdk.java.net/~chegar/8000476/webrev.00/ > > Thanks! > John Zavgren > john.zavg...@oracle.com > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ...

Re: Memory leak fix for: src/solaris/native/com/sun/security/auth/module/Unix.c

2012-10-23 Thread Dmitry Samersoff
dure in question exits in many places and in every case it's >> necessary to deallocate this memory. The leak occurred because returns were >> being made without freeing it. I fixed the leak by modifying the code so >> that there is a common "exit point", that is

Re: Memory leak fix for: src/solaris/native/com/sun/security/auth/module/Unix.c

2012-10-22 Thread Dmitry Samersoff
*env)->GetFieldID() if (fid_uid == 0 ) goto cleanup_and_return; fid_gid = (*env)->GetFieldID() // Set all required fields here -Dmitry -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ...

Re: Memory leak fix for: src/solaris/native/com/sun/security/auth/module/Unix.c

2012-10-22 Thread Dmitry Samersoff
n "exit point", that is reached from these same places via > goto statements, that performs this common function, immediately before the > "return" statement. > > Thanks! > John Zavgren > john.zavg...@oracle.com > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ...

hg: jdk8/tl/jdk: 6809322: javax.management.timer.Timer does not fire all notifications

2012-10-17 Thread dmitry . samersoff
Changeset: b2d8a99a049e Author:dsamersoff Date: 2012-10-17 18:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2d8a99a049e 6809322: javax.management.timer.Timer does not fire all notifications Summary: Some notifications get dropped due to ConcurrentModificationException t

hg: jdk8/tl/jdk: 7186723: TEST_BUG: Race condition in sun/management/jmxremote/startstop/JMXStartStopTest.sh

2012-10-02 Thread dmitry . samersoff
Changeset: 0c1c4b185451 Author:dsamersoff Date: 2012-09-29 15:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c1c4b185451 7186723: TEST_BUG: Race condition in sun/management/jmxremote/startstop/JMXStartStopTest.sh Summary: Make test self-terminating and independent to cyg

hg: jdk8/tl/jdk: 7194597: Typeo in com.sun.management.VMOption.toString()

2012-09-11 Thread dmitry . samersoff
Changeset: 2598dad9 Author:dsamersoff Date: 2012-09-11 19:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2598dad9 7194597: Typeo in com.sun.management.VMOption.toString() Summary: VMOption.toString() returns "...(read-only)" if writable "...(read-write)" otherwise

hg: jdk8/tl/jdk: 7183753: [TEST] Some colon in the diff for this test

2012-08-10 Thread dmitry . samersoff
Changeset: bf85c3ab2637 Author:dsamersoff Date: 2012-08-09 14:52 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf85c3ab2637 7183753: [TEST] Some colon in the diff for this test Summary: Reference output file contains extra colon Reviewed-by: sspitsyn, mgronlun ! test/sun/to

hg: jdk7/tl/jdk: 6964714: NetworkInterface getInetAddresses enumerates IPv6 addresses if java.net.preferIPvStack property set

2010-07-13 Thread dmitry . samersoff
Changeset: 25050030a320 Author:dsamersoff Date: 2010-07-13 15:32 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/25050030a320 6964714: NetworkInterface getInetAddresses enumerates IPv6 addresses if java.net.preferIPvStack property set Summary: User can disable ipv6 explicitly

hg: jdk7/tl/jdk: 6931566: NetworkInterface is not working when interface name is more than 15 characters long

2010-06-23 Thread dmitry . samersoff
Changeset: 887e525597f8 Author:dsamersoff Date: 2010-06-23 17:25 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/887e525597f8 6931566: NetworkInterface is not working when interface name is more than 15 characters long Summary: Separate Linux and Solaris code, use lifreq unde