On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
On Tue, 18 May 2021 22:41:06 GMT, Brent Christian wrote:
>> Please review this enhancement to add a new JFR event, generated whenever a
>> finalizer is run.
>> (The makeup is similar to the Deserialization event,
>> [JDK-8261160](https://bugs.openjdk.java.net/browse/JDK-8261160).)
>>
>> The ev
On Tue, 18 May 2021 22:41:06 GMT, Brent Christian wrote:
>> Please review this enhancement to add a new JFR event, generated whenever a
>> finalizer is run.
>> (The makeup is similar to the Deserialization event,
>> [JDK-8261160](https://bugs.openjdk.java.net/browse/JDK-8261160).)
>>
>> The ev
On Fri, 12 Feb 2021 16:26:09 GMT, Chris Hegarty wrote:
>> This issue adds a new event to improve diagnostic information of Java
>> deserialization. The event captures the details of deserialization activity
>> from ObjectInputStream. The event details are similar to that of the serial
>> filte
On Tue, 9 Feb 2021 12:35:27 GMT, Chris Hegarty wrote:
> This issue adds a new event to improve diagnostic information of Java
> deserialization. The event captures the details of deserialization activity
> from ObjectInputStream. The event details are similar to that of the serial
> filter, bu
On Wed, 23 Sep 2020 18:41:06 GMT, Philippe Marschall
wrote:
>> Hello, newbie here
>>
>> I picked JDK-8138732 to work on because it has a "starter" label and I
>> believe I understand what to do.
>>
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change `@sin
On Sat, 12 Sep 2020 00:19:00 GMT, Vladimir Kozlov wrote:
>> Philippe Marschall has refreshed the contents of this pull request, and
>> previous commits have been removed. The
>> incremental views will show differences compared to the previous content of
>> the PR. The pull request contains one
Looks good.
Erik
Hi,
These tests lack @requires vm.hasJFR, thus they are failing on AIX.
http://cr.openjdk.java.net/~goetz/wr18/8215334-JFR_requires/01/
Please review.
I will push this to jdk12 as it is a testbug if I miss the RDP deadline.
Best regards,
Goetz.
removed the variable names using underscore. Also optimized
some variable assignments in X509Impl.commitEvent(..)
http://cr.openjdk.java.net/~coffeys/webrev.8148188.v5/webrev/
regards,
Sean.
On 09/07/2018 18:01, Seán Coffey wrote:
Erik,
Thanks for reviewing. Comments inline..
On 09/07/18 17:21, Eri
ations carried out to
clean up the code up further.
http://cr.openjdk.java.net/~coffeys/webrev.8148188.v5/webrev/
This enhancement has a dependency on JDK-8203629
Regards,
Sean.
On 02/07/18 09:49, Erik Gahlin wrote:
On 29 Jun 2018, at 17:34, Seán Coffey wrote:
I've introduced a new test he
ffeys/webrev.8148188.v4/webrev/
>
> Regards,
> Sean.
>
> On 28/06/18 17:59, Seán Coffey wrote:
>> Comments inline.
>>
>>
>> On 28/06/2018 17:20, Erik Gahlin wrote:
>>> It's sufficient if an event object escapes to another method (regardless if
result the event class shouldn't
escape. If performance metrics highlight an issue, we should revisit.
regards,
Sean.
On 27/06/2018 20:57, Erik Gahlin wrote:
On 2018-06-27 21:14, Seán Coffey wrote:
On 27/06/2018 19:57, Xuelei Fan wrote:
Hi Sean,
I may reply in seve
Hi Sean,
Some of the changes in the webrev belongs to JDK-8203629 and should be
removed for clarity.
Some initial comments:
default.jfc, profile.jfr:
The events should not have control="enable-exceptions". The purpose of
the control attribute is so to provide parameterized configuration of
Hi,
Could I have a review of a small fix that removes references to jfr from
the package.access list.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8047368
Webrev:
http://cr.openjdk.java.net/~egahlin/8047368/
Thanks
Erik
Changeset: 894a4bae9e33
Author:egahlin
Date: 2013-11-20 12:32 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/894a4bae9e33
7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails
Reviewed-by: sla
! test/com/sun/jdi/BreakpointWithFullGC.sh
Changeset: d6195774dd1f
Author:egahlin
Date: 2013-11-19 11:47 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6195774dd1f
8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on
ProblemList.txt
Reviewed-by: alanb
! test/ProblemList.txt
Changeset: 256b3395346b
Author:egahlin
Date: 2013-11-13 18:41 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/256b3395346b
6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh
Reviewed-by: sla, sspitsyn
! test/com/sun/jdi/BreakpointWithFullGC.sh
Changeset: ddaa9a8acaed
Author:egahlin
Date: 2013-11-13 15:21 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddaa9a8acaed
6959636: testcase failing on windows
javax/management/loading/LibraryLoader/LibraryLoaderTest.java
Reviewed-by: sla, jbachorik
! test/ProblemList.txt
!
Changeset: d9f827e4d20c
Author:egahlin
Date: 2013-11-12 18:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9f827e4d20c
6849945: VM Periodic Task Thread CPU time = -1ns in
HotspotThreadMBean.getInternalThreadCpuTimes()
Reviewed-by: sla
! test/sun/management/HotspotThreadM
Changeset: 4cff9f59644f
Author:egahlin
Date: 2013-11-12 17:40 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4cff9f59644f
6543856: MonitorVmStartTerminate.sh fails intermittently
Reviewed-by: sla, dholmes
! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java
!
Changeset: 41dcb0c2e194
Author:egahlin
Date: 2013-11-12 14:52 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41dcb0c2e194
8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently
Reviewed-by: sla, jbachorik
! test/javax/management/monitor/ThreadPoolAccTe
Changeset: c077a2810782
Author:egahlin
Date: 2013-10-23 10:50 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c077a2810782
7105883: JDWP: agent crash if there exists a ThreadGroup with null name
Reviewed-by: sla, jbachorik
! src/share/back/ThreadGroupReferenceImpl.c
+ test/co
22 matches
Mail list logo
